Changeset 118740 in webkit

Timestamp:

May 29, 2012 2:10:41 AM (12 years ago)

Author:

hbono@chromium.org

Message:

Use WebSpellCheckClient::spellcheck to retrieve suggestions.
​https://bugs.webkit.org/show_bug.cgi?id=87690

Reviewed by Hajime Morita.

This change uses WebSpellCheckClient::spellcheck as a fallback method to
retrieve suggestions when a marker does not have any suggestions. (It consumes
lots of CPU power to get suggestions for misspelled word, i.e. Chromium cannot
afford to attach suggestions to all spelling markers.)

• src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Retrieve suggestions if markers do not have any.

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/ContextMenuClientImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-05-29  Hironori Bono  <hbono@chromium.org>
+
+        Use WebSpellCheckClient::spellcheck to retrieve suggestions.
+        https://bugs.webkit.org/show_bug.cgi?id=87690
+
+        Reviewed by Hajime Morita.
+
+        This change uses WebSpellCheckClient::spellcheck as a fallback method to
+        retrieve suggestions when a marker does not have any suggestions. (It consumes
+        lots of CPU power to get suggestions for misspelled word, i.e. Chromium cannot
+        afford to attach suggestions to all spelling markers.)
+
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Retrieve suggestions if markers do not have any.
+
 2012-05-28  Takashi Toyoshima  <toyoshim@chromium.org>
 

trunk/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

@@ -291 +291 @@
                         }
                     }
-                    data.dictionarySuggestions = suggestions;
                     data.misspelledWord = selectMisspelledWord(defaultMenu, selectedFrame);
+                    if (!suggestions.isEmpty())
+                        data.dictionarySuggestions = suggestions;
+                    else if (m_webView->spellCheckClient()) {
+                        int misspelledOffset, misspelledLength;
+                        m_webView->spellCheckClient()->spellCheck(data.misspelledWord, misspelledOffset, misspelledLength, &data.dictionarySuggestions);
+                    }
                 }
             }