Changeset 119549 in webkit


Ignore:
Timestamp:
Jun 5, 2012 6:57:53 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
https://bugs.webkit.org/show_bug.cgi?id=88342

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-05
Reviewed by Rob Buis.

RIM PR: 163141

Reviewed internally by Mike Fenton.

We set all options' type to TypeOption, which can't tell if an option belongs to a group,
introduce TypeOptionInGroup to fix it.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

Location:
trunk/Source/WebKit/blackberry
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/blackberry/ChangeLog

    r119527 r119549  
     12012-06-05  Crystal Zhang  <haizhang@rim.com>
     2
     3        [BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
     4        https://bugs.webkit.org/show_bug.cgi?id=88342
     5
     6        Reviewed by Rob Buis.
     7
     8        RIM PR: 163141
     9
     10        Reviewed internally by Mike Fenton.
     11
     12        We set all options' type to TypeOption, which can't tell if an option belongs to a group,
     13        introduce TypeOptionInGroup to fix it.
     14
     15        * WebKitSupport/InputHandler.cpp:
     16        (BlackBerry::WebKit::InputHandler::openSelectPopup):
     17
    1182012-06-05  Adam Barth  <abarth@webkit.org>
    219
  • trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

    r119134 r119549  
    11591159                enableds[i] = option->disabled() ? 0 : 1;
    11601160                selecteds[i] = option->selected();
    1161                 itemTypes[i] = TypeOption;
     1161                itemTypes[i] = option->parentNode() && option->parentNode()->hasTagName(HTMLNames::optgroupTag) ? TypeOptionInGroup : TypeOption;
    11621162            } else if (listItems[i]->hasTagName(HTMLNames::optgroupTag)) {
    11631163                HTMLOptGroupElement* optGroup = static_cast<HTMLOptGroupElement*>(listItems[i]);
Note: See TracChangeset for help on using the changeset viewer.