Changeset 119822 in webkit

Timestamp:

Jun 8, 2012 5:16:48 AM (12 years ago)

Author:

arko@motorola.com

Message:

Microdata: An element with an empty itemprop= should not get listed in the .properties list.
​https://bugs.webkit.org/show_bug.cgi?id=88235

Reviewed by Ryosuke Niwa.

Source/WebCore:

As per the specification change ​http://html5.org/r/6854, an element should be listed in .properties
if the elelement has an attribute itemprop specified and the element has one or more property names.

Test: fast/dom/MicroData/element-with-empty-itemprop.html

• html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::itemAfter):

LayoutTests:

• fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Added.
• fast/dom/MicroData/element-with-empty-itemprop.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/MicroData/element-with-empty-itemprop-expected.txt (added)
• LayoutTests/fast/dom/MicroData/element-with-empty-itemprop.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLPropertiesCollection.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-06-08  Arko Saha  <arko@motorola.com>
+
+        Microdata: An element with an empty itemprop='' should not get listed in the .properties list.
+        https://bugs.webkit.org/show_bug.cgi?id=88235
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Added.
+        * fast/dom/MicroData/element-with-empty-itemprop.html: Added.
+
 2012-06-08  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-08  Arko Saha  <arko@motorola.com>
+
+        Microdata: An element with an empty itemprop='' should not get listed in the .properties list.
+        https://bugs.webkit.org/show_bug.cgi?id=88235
+
+        Reviewed by Ryosuke Niwa.
+
+        As per the specification change http://html5.org/r/6854, an element should be listed in .properties
+        if the elelement has an attribute itemprop specified and the element has one or more property names.
+
+        Test: fast/dom/MicroData/element-with-empty-itemprop.html
+
+        * html/HTMLPropertiesCollection.cpp:
+        (WebCore::HTMLPropertiesCollection::itemAfter):
+
 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
 

trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp

@@ -129 +129 @@
             continue;
         HTMLElement* element = toHTMLElement(current);
-        if (element->fastHasAttribute(itempropAttr)) {
+        if (element->fastHasAttribute(itempropAttr) && element->itemProp()->length()) {
             return element;
         }