Changeset 119943 in webkit
- Timestamp:
- Jun 10, 2012 12:19:19 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r119940 r119943 1 2012-06-10 Darin Adler <darin@apple.com> 2 3 Some additional tweaks to keep TreeShared code simple/clean 4 https://bugs.webkit.org/show_bug.cgi?id=88738 5 6 Reviewed by Adam Barth. 7 8 * platform/TreeShared.h: Make constructor and destructor both protected. 9 It's slightly dangerous to have a public non-virtual destructor, and there 10 is no reason it needs to be public. 11 (WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual; 12 we were getting no value from it being virtual. Now that it's non-virtual, 13 there is no need to use an #if on it since it's an empty inline destructor 14 in non-debug builds. 15 1 16 2012-06-06 Jer Noble <jer.noble@apple.com> 2 17 -
trunk/Source/WebCore/platform/TreeShared.h
r119937 r119943 35 35 template<typename NodeType, typename ParentNodeType> class TreeShared { 36 36 WTF_MAKE_NONCOPYABLE(TreeShared); 37 p ublic:37 protected: 38 38 TreeShared() 39 39 : m_parent(0) … … 50 50 } 51 51 52 #ifndef NDEBUG 53 virtual ~TreeShared() 52 ~TreeShared() 54 53 { 55 54 ASSERT(isMainThread()); … … 58 57 ASSERT(!m_adoptionIsRequired); 59 58 } 60 #endif61 59 60 public: 62 61 void ref() 63 62 {
Note: See TracChangeset
for help on using the changeset viewer.