Changeset 119962 in webkit

Timestamp:

Jun 11, 2012 1:24:02 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Web Inspector: implement breaking from native callback
​https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-06-11
Reviewed by Pavel Feldman.

These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html

• bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::breakProgram):

• bindings/js/ScriptDebugServer.h:

(WebCore::supportsNativeBreakpoints):

Location:

trunk

Files:

• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/ScriptDebugServer.cpp (modified) (1 diff)
• Source/WebCore/bindings/js/ScriptDebugServer.h (modified) (1 diff)

trunk/LayoutTests/platform/qt/Skipped

@@ -271 +271 @@
 fast/text/hyphens.html
 fast/text/soft-hyphen-4.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=43332
-inspector/debugger/dom-breakpoints.html
-inspector/debugger/event-listener-breakpoints.html
-inspector/debugger/step-through-event-listeners.html
-inspector/debugger/xhr-breakpoints.html
 
 # JSC doesn't support heap profiling

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-11  Peter Wang  <peter.wang@torchmobile.com.cn>
+
+        [JSC] Web Inspector: implement breaking from native callback
+        https://bugs.webkit.org/show_bug.cgi?id=43332
+
+        Reviewed by Pavel Feldman.
+
+        These test cases were enabled:
+        LayoutTests/inspector/debugger/dom-breakpoints.html
+        LayoutTests/inspector/debugger/event-listener-breakpoints.html
+        LayoutTests/inspector/debugger/step-through-event-listeners.html
+        LayoutTests/inspector/debugger/xhr-breakpoints.html
+
+        * bindings/js/ScriptDebugServer.cpp:
+        (WebCore::ScriptDebugServer::breakProgram):
+        * bindings/js/ScriptDebugServer.h:
+        (WebCore::supportsNativeBreakpoints):
+
 2012-06-11  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp

@@ -153 +153 @@
 void ScriptDebugServer::breakProgram()
 {
-    // FIXME(WK43332): implement this.
+    if (m_paused || !m_currentCallFrame)
+        return;
+
+    m_pauseOnNextStatement = true;
+    pauseIfNeeded(m_currentCallFrame->dynamicGlobalObject());
 }
 

trunk/Source/WebCore/bindings/js/ScriptDebugServer.h

@@ -86 +86 @@
 
     bool causesRecompilation() { return true; }
-    bool supportsNativeBreakpoints() { return false; }
+    // FIXME: Need to remove this. Refer to bug: 88759.
+    bool supportsNativeBreakpoints() { return true; }
 
     void recompileAllJSFunctionsSoon();