Changeset 120030 in webkit


Ignore:
Timestamp:
Jun 11, 2012 7:51:59 PM (12 years ago)
Author:
scheib@chromium.org
Message:

Consolidate Pointer Lock runtime enabled flags to just one.
​https://bugs.webkit.org/show_bug.cgi?id=88810

Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):

  • dom/MouseEvent.idl:
  • page/Navigator.idl:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r120029 r120030  
     12012-06-11  Vincent Scheib  <scheib@chromium.org>
     2
     3        Consolidate Pointer Lock runtime enabled flags to just one.
     4        https://bugs.webkit.org/show_bug.cgi?id=88810
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        No new tests.
     9
     10        * bindings/generic/RuntimeEnabledFeatures.h:
     11        (WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
     12        (WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):
     13        * dom/MouseEvent.idl:
     14        * page/Navigator.idl:
     15
    1162012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
    217

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r118484 r120030  
    9797
    9898#if ENABLE(POINTER_LOCK)
    99     static bool webkitPointerLockEnabled() { return isPointerLockEnabled; }
    100     static void setWebkitPointerLockEnabled(bool isEnabled) { isPointerLockEnabled = isEnabled; }
    101     static bool webkitPointerEnabled() { return isPointerLockEnabled; }
    102     static bool webkitMovementXEnabled() { return isPointerLockEnabled; }
    103     static bool webkitMovementYEnabled() { return isPointerLockEnabled; }
     99    static bool pointerLockEnabled() { return isPointerLockEnabled; }
     100    static void setPointerLockEnabled(bool isEnabled) { isPointerLockEnabled = isEnabled; }
    104101#endif
    105102

  • trunk/Source/WebCore/dom/Document.idl

    r119895 r120030  
    335335        attribute [NotEnumerable, Conditional=FULLSCREEN_API] EventListener onwebkitfullscreenchange;
    336336        attribute [NotEnumerable, Conditional=FULLSCREEN_API] EventListener onwebkitfullscreenerror;
    337         attribute [NotEnumerable, Conditional=POINTER_LOCK] EventListener onwebkitpointerlockchange;
    338         attribute [NotEnumerable, Conditional=POINTER_LOCK] EventListener onwebkitpointerlockerror;
     337        attribute [NotEnumerable, Conditional=POINTER_LOCK, V8EnabledAtRuntime=pointerLock] EventListener onwebkitpointerlockchange;
     338        attribute [NotEnumerable, Conditional=POINTER_LOCK, V8EnabledAtRuntime=pointerLock] EventListener onwebkitpointerlockerror;
    339339#endif
    340340

  • trunk/Source/WebCore/dom/MouseEvent.idl

    r107304 r120030  
    2626        readonly attribute long             clientX;
    2727        readonly attribute long             clientY;
    28         readonly attribute [Conditional=POINTER_LOCK, V8EnabledAtRuntime] long webkitMovementX;
    29         readonly attribute [Conditional=POINTER_LOCK, V8EnabledAtRuntime] long webkitMovementY;
     28        readonly attribute [Conditional=POINTER_LOCK, V8EnabledAtRuntime=pointerLock] long webkitMovementX;
     29        readonly attribute [Conditional=POINTER_LOCK, V8EnabledAtRuntime=pointerLock] long webkitMovementY;
    3030        readonly attribute boolean          ctrlKey;
    3131        readonly attribute boolean          shiftKey;

  • trunk/Source/WebCore/page/Navigator.idl

    r108450 r120030  
    4141        readonly attribute boolean onLine;
    4242
    43 #if defined(ENABLE_POINTER_LOCK) && ENABLE_POINTER_LOCK
    44         readonly attribute [V8EnabledAtRuntime] PointerLock webkitPointer;
     43#if defined(ENABLE_POINTER_LOCK) && ENABLE_POINTER_LOCK // FIXME: Remove reliance on PointerLock.idl when removing old Pointer Lock API. (https://bugs.webkit.org/show_bug.cgi?id=84402)
     44        readonly attribute [Conditional=POINTER_LOCK, V8EnabledAtRuntime=pointerLock] PointerLock webkitPointer;
    4545#endif
    4646

  • trunk/Source/WebKit/chromium/ChangeLog

    r120029 r120030  
     12012-06-11  Vincent Scheib  <scheib@chromium.org>
     2
     3        Consolidate Pointer Lock runtime enabled flags to just one.
     4        https://bugs.webkit.org/show_bug.cgi?id=88810
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * src/WebRuntimeFeatures.cpp:
     9        (WebKit::WebRuntimeFeatures::enablePointerLock):
     10        (WebKit::WebRuntimeFeatures::isPointerLockEnabled):
     11
    1122012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
    213

  • trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r115109 r120030  
    398398{
    399399#if ENABLE(POINTER_LOCK)
    400     RuntimeEnabledFeatures::setWebkitPointerLockEnabled(enable);
     400    RuntimeEnabledFeatures::setPointerLockEnabled(enable);
    401401#else
    402402    UNUSED_PARAM(enable);
    … …  
    407407{
    408408#if ENABLE(POINTER_LOCK)
    409     return RuntimeEnabledFeatures::webkitPointerLockEnabled();
     409    return RuntimeEnabledFeatures::pointerLockEnabled();
    410410#else
    411411    return false;
Note: See TracChangeset for help on using the changeset viewer.