Changeset 120158 in webkit


Ignore:
Timestamp:
Jun 12, 2012 9:50:42 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Can't set el.type on a <button> element
​https://bugs.webkit.org/show_bug.cgi?id=14439

Patch by Edaena Salinas Jasso <​edaena@apple.com> on 2012-06-12
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLButtonElement/change-type.html

  • bindings/objc/PublicDOMInterfaces.h:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::setType): Added implementation of setType method.
(WebCore):

  • html/HTMLButtonElement.h:

(HTMLButtonElement): Added setType method.

  • html/HTMLButtonElement.idl: Removed readonly restriction to the type variable.

LayoutTests:

  • fast/dom/HTMLButtonElement/change-type-expected.txt: Added.
  • fast/dom/HTMLButtonElement/change-type.html: Added.
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r120157 r120158  
     12012-06-12  Edaena Salinas Jasso  <edaena@apple.com>
     2
     3        Can't set el.type on a <button> element
     4        https://bugs.webkit.org/show_bug.cgi?id=14439
     5
     6        Reviewed by Darin Adler.
     7
     8        * fast/dom/HTMLButtonElement/change-type-expected.txt: Added.
     9        * fast/dom/HTMLButtonElement/change-type.html: Added.
     10
    1112012-06-12  Dominic Cooney  <dominicc@chromium.org>
    212

  • trunk/Source/WebCore/ChangeLog

    r120156 r120158  
     12012-06-12  Edaena Salinas Jasso  <edaena@apple.com>
     2
     3        Can't set el.type on a <button> element
     4        https://bugs.webkit.org/show_bug.cgi?id=14439
     5
     6        Reviewed by Darin Adler.
     7
     8        Test: fast/dom/HTMLButtonElement/change-type.html
     9
     10        * bindings/objc/PublicDOMInterfaces.h:
     11        * html/HTMLButtonElement.cpp:
     12        (WebCore::HTMLButtonElement::setType): Added implementation of setType method.
     13        (WebCore):
     14        * html/HTMLButtonElement.h:
     15        (HTMLButtonElement): Added setType method.
     16        * html/HTMLButtonElement.idl: Removed readonly restriction to the type variable.
     17
    1182012-06-12  Kenichi Ishibashi  <bashi@chromium.org>
    219

  • trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h

    r119360 r120158  
    411411@property BOOL disabled;
    412412@property(copy) NSString *name;
    413 @property(readonly, copy) NSString *type;
     413@property(copy) NSString *type;
    414414@property(copy) NSString *value;
    415415@property BOOL autofocus AVAILABLE_IN_WEBKIT_VERSION_4_0;

  • trunk/Source/WebCore/html/HTMLButtonElement.cpp

    r118442 r120158  
    5252{
    5353    return adoptRef(new HTMLButtonElement(tagName, document, form));
     54}
     55
     56void HTMLButtonElement::setType(const String& type)
     57{
     58    setAttribute(typeAttr, type);
    5459}
    5560

  • trunk/Source/WebCore/html/HTMLButtonElement.h

    r117195 r120158  
    3333    static PassRefPtr<HTMLButtonElement> create(const QualifiedName&, Document*, HTMLFormElement*);
    3434
     35    void setType(const String&);
     36   
    3537    String value() const;
    3638

  • trunk/Source/WebCore/html/HTMLButtonElement.idl

    r109550 r120158  
    3131        attribute [Reflect] DOMString formTarget;
    3232        attribute [Reflect] DOMString name;
    33         readonly attribute DOMString type;
     33        attribute DOMString type;
    3434        attribute [Reflect] DOMString value;
    3535
Note: See TracChangeset for help on using the changeset viewer.