Changeset 120736 in webkit
- Timestamp:
- Jun 19, 2012 11:03:22 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r120735 r120736 1 2012-06-19 Dirk Pranke <dpranke@chromium.org> 2 3 new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled 4 https://bugs.webkit.org/show_bug.cgi?id=85446 5 6 Reviewed by Simon Fraser. 7 8 This change makes results.html aware of whether pixel tests were 9 enabled when the tests were run; if they weren't, we ignore 10 expected IMAGE tests that pass instead of reporting them as 11 'unexpected pass'. 12 13 * fast/harness/resources/results-test.js: 14 (mockResults): 15 * fast/harness/results.html: 16 1 17 2012-06-19 Andreas Kling <kling@webkit.org> 2 18 -
trunk/LayoutTests/fast/harness/resources/results-test.js
r117950 r120736 31 31 "has_pretty_patch": false, 32 32 "has_wdiff": false, 33 "revision": 12345 33 "revision": 12345, 34 "pixel_tests_enabled": true 34 35 }; 35 36 } -
trunk/LayoutTests/fast/harness/results.html
r117950 r120736 487 487 488 488 if (actual == 'PASS' && expected != 'PASS') { 489 globalState().unexpectedPassTests.push(testObject); 489 if (expected != 'IMAGE' || globalState().results.pixel_tests_enabled) { 490 globalState().unexpectedPassTests.push(testObject); 491 } 490 492 return; 491 493 } -
trunk/Tools/ChangeLog
r120699 r120736 1 2012-06-19 Dirk Pranke <dpranke@chromium.org> 2 3 new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled 4 https://bugs.webkit.org/show_bug.cgi?id=85446 5 6 Reviewed by Simon Fraser. 7 8 Embed whether pixel testing was enabled into the results.json. 9 10 * Scripts/webkitpy/layout_tests/controllers/manager.py: 11 (summarize_results): 12 1 13 2012-06-19 Zoltan Horvath <zoltan@webkit.org> 2 14 -
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
r120619 r120736 237 237 results['has_wdiff'] = port_obj.wdiff_available() 238 238 results['has_pretty_patch'] = port_obj.pretty_patch_available() 239 results['pixel_tests_enabled'] = port_obj.get_option('pixel_tests') 240 239 241 try: 240 242 # We only use the svn revision for using trac links in the results.html file,
Note: See TracChangeset
for help on using the changeset viewer.