Changeset 121019 in webkit


Ignore:
Timestamp:
Jun 22, 2012 5:54:04 AM (12 years ago)
Author:
yosin@chromium.org
Message:

REGRESSION(r117738):[Forms] validationMessage IDL attribute should not have range overflow message if value isn't range overflow
​https://bugs.webkit.org/show_bug.cgi?id=89736

Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/forms/date/input-date-validation-message.html

fast/forms/number/input-number-validation-message.html
fast/forms/range/input-range-validation-message.html

This patch changes comparison operator for range overflow message in
InputType::validationMessage().

  • html/InputType.cpp:

(WebCore::InputType::validationMessage):

LayoutTests:

Tests for HTMLInputElement.validationMessage attribute.

  • fast/forms/date/input-date-validation-message-expected.txt: Added.
  • fast/forms/date/input-date-validation-message.html: Added.
  • fast/forms/number/input-number-validation-message-expected.txt: Added.
  • fast/forms/number/input-number-validation-message.html: Added.
  • fast/forms/range/input-range-validation-message-expected.txt: Added.
  • fast/forms/range/input-range-validation-message.html: Added.
Location:
trunk
Files:
6 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r121014 r121019  
     12012-06-22  Yoshifumi Inoue  <yosin@chromium.org>
     2
     3        REGRESSION(r117738):[Forms] validationMessage IDL attribute should not have range overflow message if value isn't range overflow
     4        https://bugs.webkit.org/show_bug.cgi?id=89736
     5
     6        Reviewed by Kent Tamura.
     7
     8        Tests for HTMLInputElement.validationMessage attribute.
     9
     10        * fast/forms/date/input-date-validation-message-expected.txt: Added.
     11        * fast/forms/date/input-date-validation-message.html: Added.
     12        * fast/forms/number/input-number-validation-message-expected.txt: Added.
     13        * fast/forms/number/input-number-validation-message.html: Added.
     14        * fast/forms/range/input-range-validation-message-expected.txt: Added.
     15        * fast/forms/range/input-range-validation-message.html: Added.
     16
    1172012-06-21  Vsevolod Vlasov  <vsevik@chromium.org>
    218

  • trunk/Source/WebCore/ChangeLog

    r121017 r121019  
     12012-06-22  Yoshifumi Inoue  <yosin@chromium.org>
     2
     3        REGRESSION(r117738):[Forms] validationMessage IDL attribute should not have range overflow message if value isn't range overflow
     4        https://bugs.webkit.org/show_bug.cgi?id=89736
     5
     6        Reviewed by Kent Tamura.
     7
     8        Tests: fast/forms/date/input-date-validation-message.html
     9               fast/forms/number/input-number-validation-message.html
     10               fast/forms/range/input-range-validation-message.html
     11
     12        This patch changes comparison operator for range overflow message in
     13        InputType::validationMessage().
     14
     15        * html/InputType.cpp:
     16        (WebCore::InputType::validationMessage):
     17
    1182012-06-22  Taiju Tsuiki  <tzik@chromium.org>
    219

  • trunk/Source/WebCore/html/InputType.cpp

    r121004 r121019  
    375375        return validationMessageRangeUnderflowText(serialize(stepRange.minimum()));
    376376
    377     if (numericValue < stepRange.maximum())
     377    if (numericValue > stepRange.maximum())
    378378        return validationMessageRangeOverflowText(serialize(stepRange.maximum()));
    379379
Note: See TracChangeset for help on using the changeset viewer.