Changeset 121569 in webkit

Timestamp:

Jun 29, 2012 10:17:02 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] Add missing support for tiled shadow blur on fillRect
​https://bugs.webkit.org/show_bug.cgi?id=90082

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2012-06-29
Reviewed by Noam Rosenthal.

This overloaded fillRect implementation also supports this optimization in
certain situations.

• platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsContextQt.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-29  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
+
+        [Qt] Add missing support for tiled shadow blur on fillRect
+        https://bugs.webkit.org/show_bug.cgi?id=90082
+
+        Reviewed by Noam Rosenthal.
+
+        This overloaded fillRect implementation also supports this optimization in
+        certain situations.
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::fillRect):
+
 2012-06-29  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

@@ -675 +675 @@
         if (hasShadow()) {
             if (shadow->mustUseShadowBlur(this)) {
-                GraphicsContext* shadowContext = shadow->beginShadowLayer(this, normalizedRect);
-                if (shadowContext) {
-                    QPainter* shadowPainter = shadowContext->platformContext();
-                    shadowPainter->fillRect(normalizedRect, p->brush());
-                    shadow->endShadowLayer(this);
-                }
+                shadow->drawRectShadow(this, rect, RoundedRect::Radii());
             } else {
                 // Solid rectangle fill with no blur shadow or transformations applied can be done