Changeset 121635 in webkit


Ignore:
Timestamp:
Jul 1, 2012 2:01:34 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
​https://bugs.webkit.org/show_bug.cgi?id=90286

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-07-01
Reviewed by Daniel Bates.

Source/WebCore:

Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.

  • dom/ViewportArguments.h:

(ViewportArguments):

LayoutTests:

Unskip now passing tests.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r121632 r121635  
     12012-07-01  Konrad Piascik  <kpiascik@rim.com>
     2
     3        [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
     4        https://bugs.webkit.org/show_bug.cgi?id=90286
     5
     6        Reviewed by Daniel Bates.
     7
     8        Unskip now passing tests.
     9
     10        * platform/efl/TestExpectations:
     11        * platform/gtk/TestExpectations:
     12        * platform/qt/TestExpectations:
     13
    1142012-06-30  Emil A Eklund  <eae@chromium.org>
    215

  • trunk/LayoutTests/platform/efl/TestExpectations

    r121625 r121635  
    716716BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
    717717
    718 // Failing after r121555
    719 BUGWK90286 : fast/viewport/viewport-91.html = TEXT
    720 
    721718BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r121625 r121635  
    12401240BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
    12411241
    1242 // Failing after r121555
    1243 BUGWK90286 : fast/viewport/viewport-91.html = TEXT
    1244 
    12451242BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE
    12461243

  • trunk/LayoutTests/platform/qt/TestExpectations

    r121579 r121635  
    102102
    103103BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
    104 
    105 // Failing after r121555
    106 BUGWK90286 : fast/viewport/viewport-91.html = TEXT

  • trunk/Source/WebCore/ChangeLog

    r121628 r121635  
     12012-07-01  Konrad Piascik  <kpiascik@rim.com>
     2
     3        [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
     4        https://bugs.webkit.org/show_bug.cgi?id=90286
     5
     6        Reviewed by Daniel Bates.
     7
     8        Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
     9        was truncated.  Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.
     10
     11        * dom/ViewportArguments.h:
     12        (ViewportArguments):
     13
    1142012-06-30  Ian Vollick  <vollick@chromium.org>
    215

  • trunk/Source/WebCore/dom/ViewportArguments.h

    r121555 r121635  
    111111    // FIXME: We're going to keep this constant around until all embedders
    112112    // refactor their code to no longer need it.
    113     static const int deprecatedTargetDPI = 160;
     113    static const float deprecatedTargetDPI = 160;
    114114};
    115115
Note: See TracChangeset for help on using the changeset viewer.