Changeset 121661 in webkit


Ignore:
Timestamp:
Jul 2, 2012 12:35:28 AM (12 years ago)
Author:
kbalazs@webkit.org
Message:

[EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
https://bugs.webkit.org/show_bug.cgi?id=90286

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-07-02
Reviewed by Daniel Bates.

Source/WebCore:

Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
was truncated. Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.

  • dom/ViewportArguments.h:

(ViewportArguments):

LayoutTests:

Unskip now passing tests.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r121660 r121661  
     12012-07-02  Konrad Piascik  <kpiascik@rim.com>
     2
     3        [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
     4        https://bugs.webkit.org/show_bug.cgi?id=90286
     5
     6        Reviewed by Daniel Bates.
     7
     8        Unskip now passing tests.
     9
     10        * platform/efl/TestExpectations:
     11        * platform/gtk/TestExpectations:
     12        * platform/qt/TestExpectations:
     13
    1142012-07-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
    215
  • trunk/LayoutTests/platform/efl/TestExpectations

    r121657 r121661  
    719719BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
    720720
    721 // Failing after r121555
    722 BUGWK90286 : fast/viewport/viewport-91.html = TEXT
    723 
    724721BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r121651 r121661  
    12401240BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
    12411241
    1242 // Failing after r121555
    1243 BUGWK90286 : fast/viewport/viewport-91.html = TEXT
    1244 
    12451242BUGWK90334 : css3/flexbox/anonymous-block.html = IMAGE
    12461243
  • trunk/LayoutTests/platform/qt/TestExpectations

    r121651 r121661  
    102102
    103103BUGWK90007 : http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html = TEXT
    104 
    105 // Failing after r121555
    106 BUGWK90286 : fast/viewport/viewport-91.html = TEXT
  • trunk/Source/WebCore/ChangeLog

    r121658 r121661  
     12012-07-02  Konrad Piascik  <kpiascik@rim.com>
     2
     3        [EFL] [GTK] [QT] fast/viewport/viewport-91.html is failing after r121555
     4        https://bugs.webkit.org/show_bug.cgi?id=90286
     5
     6        Reviewed by Daniel Bates.
     7
     8        Since the deprecatedTargetDPI was an int and the deviceDPI was also an int the result
     9        was truncated.  Changed deprecatedTargetDPI to a float value. Viewport test 91 now passes.
     10
     11        * dom/ViewportArguments.h:
     12        (ViewportArguments):
     13
    1142012-06-28  Yury Semikhatsky  <yurys@chromium.org>
    215
  • trunk/Source/WebCore/dom/ViewportArguments.cpp

    r121555 r121661  
    4242namespace WebCore {
    4343
     44const float ViewportArguments::deprecatedTargetDPI = 160;
     45
    4446ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport)
    4547{
  • trunk/Source/WebCore/dom/ViewportArguments.h

    r121651 r121661  
    109109        return !(*this == other);
    110110    }
     111
    111112    // FIXME: We're going to keep this constant around until all embedders
    112113    // refactor their code to no longer need it.
    113     static const int deprecatedTargetDPI = 160;
     114    static const float deprecatedTargetDPI;
    114115};
    115116
Note: See TracChangeset for help on using the changeset viewer.