Changeset 121701 in webkit


Ignore:
Timestamp:
Jul 2, 2012 12:45:32 PM (12 years ago)
Author:
dpranke@chromium.org
Message:

REGRESSION(r121497): It switched off and broke many unittests
https://bugs.webkit.org/show_bug.cgi?id=90371

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2012-07-02
Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.

  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:

(ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r121699 r121701  
     12012-07-02  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        REGRESSION(r121497): It switched off and broke many unittests
     4        https://bugs.webkit.org/show_bug.cgi?id=90371
     5
     6        Reviewed by Adam Barth.
     7
     8        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
     9        (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
     10        * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
     11        (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
     12        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
     13        (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
     14
    1152012-07-02  Ojan Vafai  <ojan@chromium.org>
    216
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py

    r121595 r121701  
    3636class ChromiumMacPortTest(chromium_port_testcase.ChromiumPortTestCase):
    3737    os_name = 'mac'
    38     os_version = 'leopard'
     38    os_version = 'snowleopard'
    3939    port_name = 'chromium-mac'
    4040    port_maker = chromium_mac.ChromiumMacPort
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py

    r121497 r121701  
    6565            TestConfiguration('icecreamsandwich', 'x86', 'debug'),
    6666            TestConfiguration('icecreamsandwich', 'x86', 'release'),
    67             TestConfiguration('leopard', 'x86', 'debug'),
    68             TestConfiguration('leopard', 'x86', 'release'),
    6967            TestConfiguration('snowleopard', 'x86', 'debug'),
    7068            TestConfiguration('snowleopard', 'x86', 'release'),
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

    r121497 r121701  
    4545
    4646
    47 class PortTestCase(object):
     47class PortTestCase(unittest.TestCase):
    4848    """Tests that all Port implementations must pass."""
    4949    HTTP_PORTS = (8000, 8080, 8443)
Note: See TracChangeset for help on using the changeset viewer.