Changeset 121706 in webkit


Ignore:
Timestamp:
Jul 2, 2012 2:27:29 PM (12 years ago)
Author:
ojan@chromium.org
Message:

Delete unused rebaseline method in gardeningserver.py
​https://bugs.webkit.org/show_bug.cgi?id=90396

Reviewed by Eric Seidel.

As best I can tell, the only usage was in this unittest.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.updateexpectations):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaseline_new_port):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r121701 r121706  
     12012-07-02  Ojan Vafai  <ojan@chromium.org>
     2
     3        Delete unused rebaseline method in gardeningserver.py
     4        https://bugs.webkit.org/show_bug.cgi?id=90396
     5
     6        Reviewed by Eric Seidel.
     7
     8        As best I can tell, the only usage was in this unittest.
     9
     10        * Scripts/webkitpy/tool/servers/gardeningserver.py:
     11        (GardeningHTTPRequestHandler.updateexpectations):
     12        * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
     13        (GardeningServerTest.test_rebaseline_new_port):
     14
    1152012-07-02  Csaba Osztrogonác  <ossy@webkit.org>
    216

  • trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py

    r121699 r121706  
    141141        self._serve_text('success')
    142142
    143     # FIXME: Is this dead code?
    144     def rebaseline(self):
    145         builder = self.query['builder'][0]
    146         command = [ 'rebaseline-test' ]
    147 
    148         if 'suffixes' in self.query:
    149             command.append('--suffixes')
    150             command.append(self.query['suffixes'][0])
    151 
    152         command.append(builder)
    153         command.append(self.query['test'][0])
    154 
    155         command.extend(builders.fallback_port_names_for_new_port(builder))
    156         self._run_webkit_patch(command)
    157         self._serve_text('success')
    158 
    159143    def rebaselineall(self):
    160144        command = ['rebaseline-all']

  • trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py

    r121699 r121706  
    201201    def test_rebaseline_new_port(self):
    202202        builders._exact_matches = {"MOCK builder": {"port_name": "test-mac-leopard", "specifiers": set(["mock-specifier"]), "move_overwritten_baselines_to": ["mock-port-fallback", "mock-port-fallback2"]}}
    203         expected_stderr = "MOCK run_command: ['echo', 'rebaseline-test', '--suffixes', 'txt,png', 'MOCK builder', 'user-scripts/another-test.html', 'mock-port-fallback', 'mock-port-fallback2'], cwd=/mock-checkout\n"
    204         expected_stdout = "== Begin Response ==\nsuccess\n== End Response ==\n"
    205         self._post_to_path("/rebaseline?builder=MOCK+builder&test=user-scripts/another-test.html&suffixes=txt,png", expected_stderr=expected_stderr, expected_stdout=expected_stdout)
     203        expected_stderr = 'MOCK run_command: [\'echo\', \'rebaseline-all\'], cwd=/mock-checkout, input={"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}\n'
     204        expected_stdout = "== Begin Response ==\nsuccess\n== End Response ==\n"
     205        self._post_to_path("/rebaselineall", body='{"user-scripts/another-test.html":{"MOCK builder": ["txt","png"]}}', expected_stderr=expected_stderr, expected_stdout=expected_stdout)
    206206
    207207    def test_updateexpectations(self):
Note: See TracChangeset for help on using the changeset viewer.