Changeset 121790 in webkit

Timestamp:

Jul 3, 2012 10:47:24 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Anonymous scripts (evals) should not be added to Workspace.
​https://bugs.webkit.org/show_bug.cgi?id=90467

Reviewed by Pavel Feldman.

• inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):

• inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ResourceScriptMapping.js (modified) (3 diffs)
• inspector/front-end/ScriptSnippetModel.js (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-03  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Anonymous scripts (evals) should not be added to Workspace.
+        https://bugs.webkit.org/show_bug.cgi?id=90467
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/ResourceScriptMapping.js:
+        (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
+        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
+        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
+        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
+        * inspector/front-end/ScriptSnippetModel.js:
+        (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
+
 2012-07-03  Robert Hogan  <robert@webkit.org>
 

trunk/Source/WebCore/inspector/front-end/ResourceScriptMapping.js

@@ -162 +162 @@
     _uiSourceCodeAdded: function(rawSourceCode, uiSourceCode)
     {
+        if (!uiSourceCode.url)
+            return;
         this._rawSourceCodeForUISourceCode.put(uiSourceCode, rawSourceCode);
         this.dispatchEventToListeners(WebInspector.UISourceCodeProvider.Events.UISourceCodeAdded, uiSourceCode);
@@ -173 +175 @@
     _uiSourceCodeReplaced: function(rawSourceCode, oldUISourceCode, uiSourceCode)
     {
+        if (!uiSourceCode.url)
+            return;
         this._rawSourceCodeForUISourceCode.remove(oldUISourceCode);
         this._rawSourceCodeForUISourceCode.put(uiSourceCode, rawSourceCode);
@@ -189 +193 @@
     _uiSourceCodeRemoved: function(rawSourceCode, uiSourceCode)
     {
+        if (!uiSourceCode.url)
+            return;
         this._rawSourceCodeForUISourceCode.remove(uiSourceCode);
         this.dispatchEventToListeners(WebInspector.UISourceCodeProvider.Events.UISourceCodeRemoved, uiSourceCode);

trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js

@@ -290 +290 @@
         this._uiSourceCodeForScriptId[script.scriptId] = uiSourceCode;
         this._scriptForUISourceCode.put(uiSourceCode, script);
-        this._snippetScriptMapping._fireUISourceCodeAdded(uiSourceCode);
         script.setSourceMapping(this._snippetScriptMapping);
     },

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -248 +248 @@
     _uiSourceCodeAdded: function(uiSourceCode)
     {
-        if (!uiSourceCode.url || uiSourceCode.isSnippetEvaluation) {
-            // Anonymous sources and snippets evaluations are shown only when stepping.
-            return;
-        }
-
         this._addUISourceCode(uiSourceCode);
     },