Changeset 121837 in webkit

Timestamp:

Jul 4, 2012 1:05:18 AM (12 years ago)

Author:

sergio@webkit.org

Message:

[GTK] WebKit2 testing bot unable to find the build directory
​https://bugs.webkit.org/show_bug.cgi?id=90523

Reviewed by Carlos Garcia Campos.

The presence of GNUmakefile was used to determine whether a given
directory was a valid build directory or not. That's not correct for
testing bots as we export only the minimum required stuff to run the
tests.

• gtk/common.py:

(get_build_path.is_valid_build_directory): added an extra check.:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• gtk/common.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
+
+        [GTK] WebKit2 testing bot unable to find the build directory
+        https://bugs.webkit.org/show_bug.cgi?id=90523
+
+        Reviewed by Carlos Garcia Campos.
+
+        The presence of GNUmakefile was used to determine whether a given
+        directory was a valid build directory or not. That's not correct for
+        testing bots as we export only the minimum required stuff to run the
+        tests.
+
+        * gtk/common.py:
+        (get_build_path.is_valid_build_directory): added an extra check.:
+
 2012-07-04  Joe Thomas  <joethomas@motorola.com>
 

trunk/Tools/gtk/common.py

@@ -41 +41 @@
 
     def is_valid_build_directory(path):
-        return os.path.exists(os.path.join(path, 'GNUmakefile'))
+        return os.path.exists(os.path.join(path, 'GNUmakefile')) or \
+            os.path.exists(os.path.join(path, 'Programs', 'DumpRenderTree'))
 
     if len(sys.argv[1:]) > 1 and os.path.exists(sys.argv[-1]) and is_valid_build_directory(sys.argv[-1]):