Changeset 121877 in webkit

Timestamp:

Jul 4, 2012 8:30:32 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
​https://bugs.webkit.org/show_bug.cgi?id=90578

Patch by Li Yin <​li.yin@intel.com> on 2012-07-04
Reviewed by Chris Rogers.

Spec: ​http://www.w3.org/TR/webaudio/#AudioDestinationNode-section
An AudioSourceNode has no inputs and a single output.
An AudioDestinationNode has one input and no outputs.
Currently, the test webaudio/audionode.html has covered AudioSourceNode,
it is still required to cover AudioDestinationNode.

• webaudio/audionode-expected.txt:
• webaudio/audionode.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• webaudio/audionode-expected.txt (modified) (1 diff)
• webaudio/audionode.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-07-04  Li Yin  <li.yin@intel.com>
+
+        AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
+        https://bugs.webkit.org/show_bug.cgi?id=90578
+
+        Reviewed by Chris Rogers.
+
+        Spec: http://www.w3.org/TR/webaudio/#AudioDestinationNode-section
+        An AudioSourceNode has no inputs and a single output.
+        An AudioDestinationNode has one input and no outputs.
+        Currently, the test webaudio/audionode.html has covered AudioSourceNode,
+        it is still required to cover AudioDestinationNode.
+
+        * webaudio/audionode-expected.txt:
+        * webaudio/audionode.html:
+
 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
 

trunk/LayoutTests/webaudio/audionode-expected.txt

@@ -8 +8 @@
 PASS Source AudioNode has no inputs.
 PASS Source AudioNode has one output.
+PASS Destination AudioNode has one input.
+PASS Destination AudioNode has no outputs.
 PASS connect() exception thrown for illegal destination AudioNode.
 PASS connect() exception thrown for illegal output index.

trunk/LayoutTests/webaudio/audionode.html

@@ -32 +32 @@
     shouldThrow("audioNode.noteOff()");
 
-    // Check number of inputs and outputs.
-    if (audioNode.numberOfInputs == 0)
+    // Check input and output numbers of AudioSourceNode.
+    if (audioNode.numberOfInputs === 0)
         testPassed("Source AudioNode has no inputs.");
     else
         testFailed("Source AudioNode should not have inputs.");
     
-    if (audioNode.numberOfOutputs == 1)
+    if (audioNode.numberOfOutputs === 1)
         testPassed("Source AudioNode has one output.");
     else
         testFailed("Source AudioNode should have one output.");
+
+    // Check input and output numbers of AudioDestinationNode
+    if (context.destination.numberOfInputs === 1)
+        testPassed("Destination AudioNode has one input.");
+    else
+        testFailed("Destination AudioNode should have one input.");
+
+    if (context.destination.numberOfOutputs === 0)
+        testPassed("Destination AudioNode has no outputs.");
+    else
+        testFailed("Destination AudioNode should have no outputs.");
 
     // Try calling connect() method with illegal values.