Changeset 121895 in webkit

Timestamp:

Jul 5, 2012 2:34:46 AM (12 years ago)

Author:

zandobersek@gmail.com

Message:

Add Gamepad logging channel
​https://bugs.webkit.org/show_bug.cgi?id=90570

Reviewed by Carlos Garcia Campos.

Add a new logging channel for logging significant
events that are related to Gamepad API implementation.

No new tests - no new testable functionality.

• platform/Logging.cpp:

(WebCore):
(WebCore::getChannelFromName):

• platform/Logging.h:

(WebCore):

• platform/gtk/GamepadsGtk.cpp: Log when a device is

registered or unregistered.
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/Logging.cpp (modified) (2 diffs)
• platform/Logging.h (modified) (1 diff)
• platform/gtk/GamepadsGtk.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-05  Zan Dobersek  <zandobersek@gmail.com>
+
+        Add Gamepad logging channel
+        https://bugs.webkit.org/show_bug.cgi?id=90570
+
+        Reviewed by Carlos Garcia Campos.
+
+        Add a new logging channel for logging significant
+        events that are related to Gamepad API implementation.
+
+        No new tests - no new testable functionality.
+
+        * platform/Logging.cpp:
+        (WebCore):
+        (WebCore::getChannelFromName):
+        * platform/Logging.h:
+        (WebCore):
+        * platform/gtk/GamepadsGtk.cpp: Log when a device is
+        registered or unregistered.
+        (WebCore::GamepadsGtk::registerDevice):
+        (WebCore::GamepadsGtk::unregisterDevice):
+
 2012-07-05  Peter Wang  <peter.wang@torchmobile.com.cn>
 

trunk/Source/WebCore/platform/Logging.cpp

@@ -66 +66 @@
 WTFLogChannel LogWebAudio =          { 0x20000000, "WebCoreLogLevel", WTFLogChannelOff };
 WTFLogChannel LogCompositing =       { 0x40000000, "WebCoreLogLevel", WTFLogChannelOff };
+WTFLogChannel LogGamepad =           { 0x80000000, "WebCoreLogLevel", WTFLogChannelOff };
 
 
@@ -148 +149 @@
         return &LogCompositing;
 
+    if (equalIgnoringCase(channelName, String("Gamepad")))
+        return &LogGamepad;
+
     return 0;
 }

trunk/Source/WebCore/platform/Logging.h

@@ -64 +64 @@
     extern WTFLogChannel LogWebAudio;
     extern WTFLogChannel LogCompositing;
+    extern WTFLogChannel LogGamepad;
 
     void initializeLoggingChannelsIfNecessary();

trunk/Source/WebCore/platform/gtk/GamepadsGtk.cpp

@@ -31 +31 @@
 #include "GamepadDeviceLinux.h"
 #include "GamepadList.h"
+#include "Logging.h"
 #include <gio/gunixinputstream.h>
 #include <gudev/gudev.h>
@@ -37 +38 @@
 #include <wtf/gobject/GOwnPtr.h>
 #include <wtf/gobject/GRefPtr.h>
+#include <wtf/text/CString.h>
 #include <wtf/text/StringHash.h>
 
@@ -139 +141 @@
 void GamepadsGtk::registerDevice(String deviceFile)
 {
+    LOG(Gamepad, "GamepadsGtk::registerDevice %s", deviceFile.ascii().data());
     ASSERT(!m_deviceMap.contains(deviceFile));
 
@@ -152 +155 @@
 void GamepadsGtk::unregisterDevice(String deviceFile)
 {
+    LOG(Gamepad, "GamepadsGtk::unregisterDevice %s", deviceFile.ascii().data());
     ASSERT(m_deviceMap.contains(deviceFile));