Changeset 121899 in webkit

Timestamp:

Jul 5, 2012 4:21:47 AM (12 years ago)

Author:

kbalazs@webkit.org

Message:

[Qt] WTR crashes if a URL is passed as a parameter
​https://bugs.webkit.org/show_bug.cgi?id=88093

Reviewed by Zoltan Herczeg.

• Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedURLAPI):
Don't special case null string. It's handled
fine by WebURL and passing 0 is not suitable
to the API.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/API/c/WKSharedAPICast.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-07-05  Balazs Kelemen  <kbalazs@webkit.org>
+
+        [Qt] WTR crashes if a URL is passed as a parameter
+        https://bugs.webkit.org/show_bug.cgi?id=88093
+
+        Reviewed by Zoltan Herczeg.
+
+        * Shared/API/c/WKSharedAPICast.h:
+        (WebKit::toCopiedURLAPI):
+        Don't special case null string. It's handled
+        fine by WebURL and passing 0 is not suitable
+        to the API.
+
 2012-07-05  Dongwoo Im  <dw.im@samsung.com>
 

trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h

@@ -160 +160 @@
 inline WKURLRef toCopiedURLAPI(const String& string)
 {
-    if (!string)
-        return 0;
     RefPtr<WebURL> webURL = WebURL::create(string);
     return toAPI(webURL.release().leakRef());