Changeset 121913 in webkit


Ignore:
Timestamp:
Jul 5, 2012 10:37:35 AM (12 years ago)
Author:
ap@apple.com
Message:

[Mac][WK2] Enable HTTPS tests
​https://bugs.webkit.org/show_bug.cgi?id=90600

Reviewed by Brady Eidson.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.

It explained why we were doing this here instead of a frame load delegate, but that's
just history, not an explanation of why we need this code.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):

Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
for tests, it seems appropriate to have platform specific solutions in every WTR,
and not add a WebKit2 API.

LayoutTests:

Unskip in common wk2 skipped file, re-skip everywhere besides Mac.

  • platform/gtk-wk2/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r121912 r121913  
     12012-07-05  Alexey Proskuryakov  <ap@apple.com>
     2
     3        [Mac][WK2] Enable HTTPS tests
     4        https://bugs.webkit.org/show_bug.cgi?id=90600
     5
     6        Reviewed by Brady Eidson.
     7
     8        Unskip in common wk2 skipped file, re-skip everywhere besides Mac.
     9
     10        * platform/gtk-wk2/Skipped:
     11        * platform/qt-5.0-wk2/Skipped:
     12        * platform/win-wk2/Skipped:
     13        * platform/wk2/Skipped:
     14
    1152012-07-05  Nate Chapin  <japhet@chromium.org>
    216

  • trunk/LayoutTests/platform/gtk-wk2/Skipped

    r120595 r121913  
    321321http/tests/navigation/ping-cookie.html
    322322
     323# WebKitTestRunner needs to allow self-signed certificates for localhost.
     324http/tests/ssl
     325
    323326###############################################################################
    324327# TESTS FAILING

  • trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

    r121740 r121913  
    393393editing/pasteboard/copy-in-password-field.html
    394394editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html
     395
     396# WebKitTestRunner needs to allow self-signed certificates for localhost.
     397http/tests/ssl

  • trunk/LayoutTests/platform/win-wk2/Skipped

    r119659 r121913  
    950950# HiDPI tests require test infrastructure enhancements
    951951fast/hidpi
     952
     953# WebKitTestRunner needs to allow self-signed certificates for localhost.
     954http/tests/ssl

  • trunk/LayoutTests/platform/wk2/Skipped

    r121907 r121913  
    11781178http/tests/security/cross-frame-access-put.html
    11791179http/tests/security/originHeader/origin-header-for-https.html
    1180 http/tests/ssl/referer-301.html
    1181 http/tests/ssl/referer-303.html
    1182 http/tests/ssl/verify-ssl-enabled.php
    11831180http/tests/storage/callbacks-are-called-in-correct-context.html
    11841181media/controls-after-reload.html

  • trunk/Tools/ChangeLog

    r121901 r121913  
     12012-07-05  Alexey Proskuryakov  <ap@apple.com>
     2
     3        [Mac][WK2] Enable HTTPS tests
     4        https://bugs.webkit.org/show_bug.cgi?id=90600
     5
     6        Reviewed by Brady Eidson.
     7
     8        * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
     9        It explained why we were doing this here instead of a frame load delegate, but that's
     10        just history, not an explanation of why we need this code.
     11
     12        * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
     13        Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
     14        for tests, it seems appropriate to have platform specific solutions in every WTR,
     15        and not add a WebKit2 API.
     16
    1172012-07-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    218

  • trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

    r121464 r121913  
    863863    [WebCache empty];
    864864
    865     // <http://webkit.org/b/31200> In order to prevent extra frame load delegate logging being generated if the first test to use SSL
    866     // is set to log frame load delegate calls we ignore SSL certificate errors on localhost and 127.0.0.1.
    867865    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
    868866    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];

  • trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm

    r120629 r121913  
    2828#import <Foundation/Foundation.h>
    2929
     30@interface NSURLRequest (PrivateThingsWeShouldntReallyUse)
     31+(void)setAllowsAnyHTTPSCertificate:(BOOL)allow forHost:(NSString *)host;
     32@end
     33
     34
    3035namespace WTR {
    3136
    … …  
    4550        nil];
    4651
    47     [[NSUserDefaults standardUserDefaults] setVolatileDomain:dict forName:NSArgumentDomain];   
     52    [[NSUserDefaults standardUserDefaults] setVolatileDomain:dict forName:NSArgumentDomain];
     53
     54    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"localhost"];
     55    [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:@"127.0.0.1"];
    4856}
    4957
Note: See TracChangeset for help on using the changeset viewer.