Changeset 121981 in webkit

Timestamp:

Jul 6, 2012 9:54:04 AM (12 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: text editor scrolls 2px horizontally as one navigates the source code.
​https://bugs.webkit.org/show_bug.cgi?id=90682

Reviewed by Vsevolod Vlasov.

Removing the hack that is glueing the scroller to the left.

• inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype._updatePanelOffsets):
(WebInspector.TextEditorChunkedPanel.prototype._scroll):

• inspector/front-end/textEditor.css:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextEditor.js (modified) (2 diffs)
• inspector/front-end/textEditor.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-06  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: text editor scrolls 2px horizontally as one navigates the source code.
+        https://bugs.webkit.org/show_bug.cgi?id=90682
+
+        Reviewed by Vsevolod Vlasov.
+
+        Removing the hack that is glueing the scroller to the left.
+
+        * inspector/front-end/TextEditor.js:
+        (WebInspector.TextEditor.prototype._updatePanelOffsets):
+        (WebInspector.TextEditorChunkedPanel.prototype._scroll):
+        * inspector/front-end/textEditor.css:
+
 2012-07-06  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TextEditor.js

@@ -253 +253 @@
         var lineNumbersWidth = this._gutterPanel.element.offsetWidth;
         if (lineNumbersWidth)
-            this._mainPanel.element.style.setProperty("left", lineNumbersWidth + "px");
+            this._mainPanel.element.style.setProperty("left", (lineNumbersWidth + 2) + "px");
         else
             this._mainPanel.element.style.removeProperty("left"); // Use default value set in CSS.
@@ -655 +655 @@
     _scroll: function()
     {
-        // FIXME: Replace the "2" with the padding-left value from CSS.
-        if (this.element.scrollLeft <= 2)
-            this.element.scrollLeft = 0;
-
         this._scheduleRepaintAll();
         if (this._syncScrollListener)

trunk/Source/WebCore/inspector/front-end/textEditor.css

@@ -122 +122 @@
 }
 
-.webkit-line-content {
-    padding-left: 2px;
-}
-
 .webkit-breakpoint .webkit-line-number-outer {
     color: white;