Changeset 121984 in webkit

Timestamp:

Jul 6, 2012 10:19:25 AM (12 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: get rid of this._lastMarkedRange in TextEditor.
​https://bugs.webkit.org/show_bug.cgi?id=90691

Reviewed by Vsevolod Vlasov.

We don't need it, should use setSelection instead.

• inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleSelectionChange):
(WebInspector.TextEditor.prototype.setSelection):
(WebInspector.TextEditor.prototype._handleFocused):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextEditor.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-06  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of this._lastMarkedRange in TextEditor.
+        https://bugs.webkit.org/show_bug.cgi?id=90691
+
+        Reviewed by Vsevolod Vlasov.
+
+        We don't need it, should use setSelection instead.
+
+        * inspector/front-end/TextEditor.js:
+        (WebInspector.TextEditor.prototype.markAndRevealRange):
+        (WebInspector.TextEditor.prototype._handleSelectionChange):
+        (WebInspector.TextEditor.prototype.setSelection):
+        (WebInspector.TextEditor.prototype._handleFocused):
+
 2012-07-06  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TextEditor.js

@@ -160 +160 @@
     {
         if (range)
-            this._lastMarkedRange = range;
+            this.setSelection(range);
         this._mainPanel.markAndRevealRange(range);
     },
@@ -380 +380 @@
     {
         var textRange = this._mainPanel._getSelection();
-        if (textRange)
-            this._lastSelection = textRange;
+        if (textRange) {
+            // We do not restore selection after focus lost to avoid selection blinking. We restore only cursor position instead.
+            // FIXME: consider adding selection decoration to blurred editor.
+            this._lastSelection = WebInspector.TextRange.createFromLocation(textRange.endLine, textRange.endColumn);
+        }
         this._delegate.selectionChanged(textRange);
     },
@@ -407 +410 @@
     {
         this._lastSelection = textRange;
-        this._mainPanel._restoreSelection(textRange);
+        if (this.element.isAncestor(document.activeElement))
+            this._mainPanel._restoreSelection(textRange);
     },
 
@@ -421 +425 @@
     _handleFocused: function()
     {
-        // Convert last marked range into a selection upon focus. This is needed to focus the search result.
-        if (this._lastMarkedRange) {
-            this.setSelection(this._lastMarkedRange);
-            delete this._lastMarkedRange;
-            return;
-        }
-
-        if (this._lastSelection) {
-            // We do not restore selection after focus lost to avoid selection blinking. We restore only cursor position instead.
-            // FIXME: consider adding selection decoration to blurred editor.
-            var newSelection = WebInspector.TextRange.createFromLocation(this._lastSelection.endLine, this._lastSelection.endColumn);
-            this.setSelection(newSelection);
-        }
+        if (this._lastSelection)
+            this.setSelection(this._lastSelection);
     },