Changeset 122059 in webkit

Timestamp:

Jul 8, 2012 2:04:05 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
​https://bugs.webkit.org/show_bug.cgi?id=90697

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-07-08
Reviewed by Vsevolod Vlasov.

Fix to remove the statements with no effect. The check for errors is added only when some valid
statements exist.

No new tests as generator related patch.

• inspector/CodeGeneratorInspector.py:

(Generator.process_command):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/CodeGeneratorInspector.py (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-08  Vivek Galatage  <vivekgalatage@gmail.com>
+
+        Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
+        https://bugs.webkit.org/show_bug.cgi?id=90697
+
+        Reviewed by Vsevolod Vlasov.
+
+        Fix to remove the statements with no effect. The check for errors is added only when some valid
+        statements exist.
+
+        No new tests as generator related patch.
+
+        * inspector/CodeGeneratorInspector.py:
+        (Generator.process_command):
+
 2012-07-06  Lauro Neto  <lauro.neto@openbossa.org>
 

trunk/Source/WebCore/inspector/CodeGeneratorInspector.py

@@ -1790 +1790 @@
         $agentField->$methodName(&error$agentCallParams);
 
-        if (!error.length()) {
-${responseCook}        }
+${responseCook}
     }
     sendResponse(callId, result, String::format("Some arguments of method '%s' can't be processed", "$domainName.$methodName"), protocolErrors, error);
@@ -2805 +2804 @@
             response_cook_text = join(response_cook_list, "")
 
+            if len(response_cook_text) != 0:
+                response_cook_text = "        if (!error.length()) {\n" + response_cook_text + "        }"
+
         Generator.backend_method_implementation_list.append(Templates.backend_method.substitute(None,
             domainName=domain_name, methodName=json_command_name,