Changeset 122081 in webkit

Timestamp:

Jul 8, 2012 9:30:08 PM (12 years ago)

Author:

kseo@webkit.org

Message:

Remove unnecessary member HTMLTreeBuilder::m_lastScriptElementStartPosition
​https://bugs.webkit.org/show_bug.cgi?id=90726

Reviewed by Adam Barth.

HTMLTreeBuilder::m_lastScriptElementStartPosition is of no use. Currently,
m_lastScriptElementStartPosition is used to store the text position in
"script" start tag, and then the stored position is passed to m_scriptToProcessStartPosition
later in "script" end tag. Because HTMLTreeBuilder handles one script tag at
a time, we can store the text position directly to m_scriptToProcessStartPosition
in "script" start tag.

No behavior change, so no new tests.

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

• html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLTreeBuilder.cpp (modified) (4 diffs)
• html/parser/HTMLTreeBuilder.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-07  Kwang Yul Seo  <skyul@company100.net>
+
+        Remove unnecessary member HTMLTreeBuilder::m_lastScriptElementStartPosition
+        https://bugs.webkit.org/show_bug.cgi?id=90726
+
+        Reviewed by Adam Barth.
+
+        HTMLTreeBuilder::m_lastScriptElementStartPosition is of no use. Currently,
+        m_lastScriptElementStartPosition is used to store the text position in
+        "script" start tag, and then the stored position is passed to m_scriptToProcessStartPosition
+        later in "script" end tag. Because HTMLTreeBuilder handles one script tag at
+        a time, we can store the text position directly to m_scriptToProcessStartPosition
+        in "script" start tag.
+
+        No behavior change, so no new tests.
+
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
+        (WebCore::HTMLTreeBuilder::processEndTag):
+        (WebCore::HTMLTreeBuilder::processScriptStartTag):
+        * html/parser/HTMLTreeBuilder.h:
+        (HTMLTreeBuilder):
+
 2012-07-08  Philip Rogers  <pdr@google.com>
 

trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp

@@ -358 +358 @@
     , m_parser(parser)
     , m_scriptToProcessStartPosition(uninitializedPositionValue1())
-    , m_lastScriptElementStartPosition(TextPosition::belowRangePosition())
     , m_usePreHTML5ParserQuirks(usePreHTML5ParserQuirks)
 {
@@ -377 +376 @@
     , m_parser(parser)
     , m_scriptToProcessStartPosition(uninitializedPositionValue1())
-    , m_lastScriptElementStartPosition(TextPosition::belowRangePosition())
     , m_usePreHTML5ParserQuirks(usePreHTML5ParserQuirks)
 {
@@ -2133 +2131 @@
             ASSERT(m_tree.currentElement()->hasTagName(scriptTag));
             m_scriptToProcess = m_tree.currentElement();
-            m_scriptToProcessStartPosition = m_lastScriptElementStartPosition;
             m_tree.openElements()->pop();
             if (isParsingFragment() && m_fragmentContext.scriptingPermission() == DisallowScriptingContent)
@@ -2647 +2644 @@
     TextPosition position = m_parser->textPosition();
 
-    m_lastScriptElementStartPosition = position;
+    m_scriptToProcessStartPosition = position;
 
     setInsertionMode(TextMode);

trunk/Source/WebCore/html/parser/HTMLTreeBuilder.h

@@ -237 +237 @@
     TextPosition m_scriptToProcessStartPosition; // Starting line number of the script tag needing processing.
 
-    // FIXME: We probably want to remove this member.  Originally, it was
-    // created to service the legacy tree builder, but it seems to be used for
-    // some other things now.
-    TextPosition m_lastScriptElementStartPosition;
-
     bool m_usePreHTML5ParserQuirks;
 };