Changeset 122096 in webkit

Timestamp:

Jul 9, 2012 1:08:39 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
​https://bugs.webkit.org/show_bug.cgi?id=90608

Patch by Andrei Onea <​onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.

Source/WebCore:

Implemented NamedFlow::firstEmptyRegionIndex as per spec: ​http://www.w3.org/TR/css3-regions/#dom-named-flow

Test: fast/regions/webkit-named-flow-first-empty-region-index.html

• dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore):

• dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

• dom/WebKitNamedFlow.idl:

LayoutTests:

Added tests for NamedFlow::firstEmptyRegionIndex.

• fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
• fast/regions/webkit-named-flow-first-empty-region-index.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt (added)
• LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/WebKitNamedFlow.cpp (modified) (1 diff)
• Source/WebCore/dom/WebKitNamedFlow.h (modified) (1 diff)
• Source/WebCore/dom/WebKitNamedFlow.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-07-09  Andrei Onea  <onea@adobe.com>
+
+        [CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
+        https://bugs.webkit.org/show_bug.cgi?id=90608
+
+        Reviewed by Andreas Kling.
+
+        Added tests for NamedFlow::firstEmptyRegionIndex.
+
+        * fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
+        * fast/regions/webkit-named-flow-first-empty-region-index.html: Added.
+
 2012-07-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-09  Andrei Onea  <onea@adobe.com>
+
+        [CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
+        https://bugs.webkit.org/show_bug.cgi?id=90608
+
+        Reviewed by Andreas Kling.
+
+        Implemented NamedFlow::firstEmptyRegionIndex as per spec: http://www.w3.org/TR/css3-regions/#dom-named-flow
+
+        Test: fast/regions/webkit-named-flow-first-empty-region-index.html
+
+        * dom/WebKitNamedFlow.cpp:
+        (WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
+        (WebCore):
+        * dom/WebKitNamedFlow.h:
+        (WebKitNamedFlow):
+        * dom/WebKitNamedFlow.idl:
+
 2012-07-08  Yoshifumi Inoue  <yosin@chromium.org>
 

trunk/Source/WebCore/dom/WebKitNamedFlow.cpp

@@ -57 +57 @@
 }
 
+int WebKitNamedFlow::firstEmptyRegionIndex() const
+{
+    m_parentFlowThread->document()->updateLayoutIgnorePendingStylesheets();
+
+    const RenderRegionList& regionList = m_parentFlowThread->renderRegionList();
+    if (regionList.isEmpty())
+        return -1;
+    RenderRegionList::const_iterator iter = regionList.begin();
+    for (int index = 0; iter != regionList.end(); ++index, ++iter) {
+        const RenderRegion* renderRegion = *iter;
+        if (renderRegion->regionState() == RenderRegion::RegionEmpty)
+            return index;
+    }
+    return -1;
+}
+
 PassRefPtr<NodeList> WebKitNamedFlow::getRegionsByContentNode(Node* contentNode)
 {

trunk/Source/WebCore/dom/WebKitNamedFlow.h

@@ -52 +52 @@
     String name() const;
     bool overset() const;
+    int firstEmptyRegionIndex() const;
     PassRefPtr<NodeList> getRegionsByContentNode(Node*);
     PassRefPtr<NodeList> getContent();

trunk/Source/WebCore/dom/WebKitNamedFlow.idl

@@ -34 +34 @@
         readonly attribute DOMString name;
         readonly attribute boolean overset;
+        readonly attribute int firstEmptyRegionIndex;
         NodeList getRegionsByContentNode(in Node contentNode);
         NodeList getContent();