Changeset 122154 in webkit


Ignore:
Timestamp:
Jul 9, 2012 1:46:29 PM (12 years ago)
Author:
mihaip@chromium.org
Message:

Handle missing results in TestResultsServer better
https://bugs.webkit.org/show_bug.cgi?id=90816

Reviewed by Ojan Vafai.

If we can't load the results JSON, don't try to wrap it with the JSONP
callback invocation.

  • TestResultServer/handlers/testfilehandler.py:

(GetFile.get):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r122151 r122154  
     12012-07-09  Mihai Parparita  <mihaip@chromium.org>
     2
     3        Handle missing results in TestResultsServer better
     4        https://bugs.webkit.org/show_bug.cgi?id=90816
     5
     6        Reviewed by Ojan Vafai.
     7
     8        If we can't load the results JSON, don't try to wrap it with the JSONP
     9        callback invocation.
     10
     11        * TestResultServer/handlers/testfilehandler.py:
     12        (GetFile.get):
     13
    1142012-07-09  Sheriff Bot  <webkit.review.bot@gmail.com>
    215
  • trunk/Tools/TestResultServer/handlers/testfilehandler.py

    r114460 r122154  
    204204            json, date = self._get_file_content(master, builder, test_type, name)
    205205
    206         self._serve_json(_replace_jsonp_callback(json, callback_name), date)
     206        if json:
     207            json = _replace_jsonp_callback(json, callback_name)
     208
     209        self._serve_json(json, date)
    207210
    208211
Note: See TracChangeset for help on using the changeset viewer.