Changeset 122337 in webkit


Ignore:
Timestamp:
Jul 11, 2012 9:50:44 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
https://bugs.webkit.org/show_bug.cgi?id=90831

Patch by Min Qin <qinmin@chromium.org> on 2012-07-11
Reviewed by Adam Barth.

On android, DRT needs to run in a background thread to avoid ANR.
However, the java tests are running on UI thread by default.
We need to send an intent extra to the apk so that it can run on a sub thread.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start_once):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r122335 r122337  
     12012-07-11  Min Qin  <qinmin@chromium.org>
     2
     3        [Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
     4        https://bugs.webkit.org/show_bug.cgi?id=90831
     5
     6        Reviewed by Adam Barth.
     7
     8        On android, DRT needs to run in a background thread to avoid ANR.
     9        However, the java tests are running on UI thread by default.
     10        We need to send an intent extra to the apk so that it can run on a sub thread.
     11
     12        * Scripts/webkitpy/layout_tests/port/chromium_android.py:
     13        (ChromiumAndroidDriver._start_once):
     14
    1152012-07-11  Csaba Osztrogonác  <ossy@webkit.org>
    216
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py

    r122261 r122337  
    519519        self._port._run_adb_command(['logcat', '-c'])
    520520        self._port._run_adb_command(['shell', 'echo'] + self.cmd_line(pixel_tests, per_test_args) + ['>', COMMAND_LINE_FILE])
    521         start_result = self._port._run_adb_command(['shell', 'am', 'start', '-n', DRT_ACTIVITY_FULL_NAME])
     521        start_result = self._port._run_adb_command(['shell', 'am', 'start', '-e', 'RunInSubThread', '-n', DRT_ACTIVITY_FULL_NAME])
    522522        if start_result.find('Exception') != -1:
    523523            _log.error('Failed to start DumpRenderTree application. Exception:\n' + start_result)
Note: See TracChangeset for help on using the changeset viewer.