Changeset 122342 in webkit

Timestamp:

Jul 11, 2012 10:50:47 AM (12 years ago)

Author:

jchaffraix@webkit.org

Message:

REGRESSION (r116203): overflow sections don't have scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=90052

Reviewed by Simon Fraser.

This issue stems from RenderLayers with overlay scrollbars not being considered
self-painting.

After r120395 (follow-up of r116203), we ignore subtrees that have no self-painting layer for
painting. Normal scrollbars are painted by their renderer so they were properly painted. However
overlay scrollbars need to be painted by their RenderLayer as a separate phase (see bug 57057) so
they were not painted anymore. The fix is simple: make RenderLayer with overlay scrollbars
self-painting as they should have been in the first place.

Unfortunately no tests as I don't think we have a good way of testing overlay
scrollbars. Tested manually though on the super simple test case from the bug.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Overlay scrollbars make the layer self-painting.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Added a call to updateSelfPaintingLayer.

(WebCore::RenderLayer::styleChanged):
Moved the call to updateSelfPaintingLayer after recomputing the scrollbars to ensure proper behavior.
Added a comment underlining the reason.

(WebCore::RenderLayer::updateSelfPaintingLayer):
Renamed as it is now called during layout too.

• rendering/RenderLayer.h:

(RenderLayer): Updated after updateSelfPaintingLayer rename.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayer.cpp (modified) (4 diffs)
• rendering/RenderLayer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-11  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        REGRESSION (r116203): overflow sections don't have scrollbars
+        https://bugs.webkit.org/show_bug.cgi?id=90052
+
+        Reviewed by Simon Fraser.
+
+        This issue stems from RenderLayers with overlay scrollbars not being considered
+        self-painting.
+
+        After r120395 (follow-up of r116203), we ignore subtrees that have no self-painting layer for
+        painting. Normal scrollbars are painted by their renderer so they were properly painted. However
+        overlay scrollbars need to be painted by their RenderLayer as a separate phase (see bug 57057) so
+        they were not painted anymore. The fix is simple: make RenderLayer with overlay scrollbars
+        self-painting as they should have been in the first place.
+
+        Unfortunately no tests as I don't think we have a good way of testing overlay
+        scrollbars. Tested manually though on the super simple test case from the bug.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::shouldBeSelfPaintingLayer):
+        Overlay scrollbars make the layer self-painting.
+
+        (WebCore::RenderLayer::updateScrollbarsAfterLayout):
+        Added a call to updateSelfPaintingLayer.
+
+        (WebCore::RenderLayer::styleChanged):
+        Moved the call to updateSelfPaintingLayer after recomputing the scrollbars to ensure proper behavior.
+        Added a comment underlining the reason.
+
+        (WebCore::RenderLayer::updateSelfPaintingLayer):
+        Renamed as it is now called during layout too.
+
+        * rendering/RenderLayer.h:
+        (RenderLayer): Updated after updateSelfPaintingLayer rename.
+
 2012-07-11  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -2535 +2535 @@
             setHasVerticalScrollbar(hasVerticalOverflow);
 
+        updateSelfPaintingLayer();
+
 #if ENABLE(DASHBOARD_SUPPORT)
         // Force an update since we know the scrollbars have changed things.
@@ -4741 +4743 @@
 {
     return !isNormalFlowOnly()
+        || hasOverlayScrollbars()
         || renderer()->hasReflection()
         || renderer()->hasMask()
@@ -4751 +4754 @@
 }
 
-void RenderLayer::updateSelfPaintingLayerAfterStyleChange(const RenderStyle*)
+void RenderLayer::updateSelfPaintingLayer()
 {
     bool isSelfPaintingLayer = shouldBeSelfPaintingLayer();
@@ -4846 +4849 @@
     }
 
-    updateSelfPaintingLayerAfterStyleChange(oldStyle);
     updateStackingContextsAfterStyleChange(oldStyle);
     updateScrollbarsAfterStyleChange(oldStyle);
+    // Overlay scrollbars can make this layer self-painting so we need
+    // to recompute the bit once scrollbars have been updated.
+    updateSelfPaintingLayer();
 
     if (!hasReflection() && m_reflection)

trunk/Source/WebCore/rendering/RenderLayer.h

@@ -680 +680 @@
     bool shouldRepaintAfterLayout() const;
 
-    void updateSelfPaintingLayerAfterStyleChange(const RenderStyle* oldStyle);
+    void updateSelfPaintingLayer();
     void updateStackingContextsAfterStyleChange(const RenderStyle* oldStyle);