Changeset 122356 in webkit


Ignore:
Timestamp:
Jul 11, 2012 12:41:03 PM (12 years ago)
Author:
andersca@apple.com
Message:

Add -Wtautological-compare and -Wsign-compare warning flags
​https://bugs.webkit.org/show_bug.cgi?id=90994

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:
Location:
trunk/Source
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r122347 r122356  
     12012-07-11  Anders Carlsson  <andersca@apple.com>
     2
     3        Add -Wtautological-compare and -Wsign-compare warning flags
     4        https://bugs.webkit.org/show_bug.cgi?id=90994
     5
     6        Reviewed by Mark Rowe.
     7
     8        * Configurations/Base.xcconfig:
     9
    1102012-07-11  Benjamin Poulain  <bpoulain@apple.com>
    211

  • trunk/Source/JavaScriptCore/Configurations/Base.xcconfig

    r115501 r122356  
    2525
    2626COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
    27 COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
     27COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
    2828
    2929CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    5555GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
    5656GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     57GCC_WARN_SIGN_COMPARE = YES;
    5758LINKER_DISPLAYS_MANGLED_NAMES = YES;
    5859PREBINDING = NO;

  • trunk/Source/WTF/ChangeLog

    r122211 r122356  
     12012-07-11  Anders Carlsson  <andersca@apple.com>
     2
     3        Add -Wtautological-compare and -Wsign-compare warning flags
     4        https://bugs.webkit.org/show_bug.cgi?id=90994
     5
     6        Reviewed by Mark Rowe.
     7
     8        * Configurations/Base.xcconfig:
     9
    1102012-07-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
    211

  • trunk/Source/WTF/Configurations/Base.xcconfig

    r115501 r122356  
    2525
    2626COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
    27 COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
     27COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
    2828
    2929CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    5555GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
    5656GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     57GCC_WARN_SIGN_COMPARE = YES;
    5758LINKER_DISPLAYS_MANGLED_NAMES = YES;
    5859PREBINDING = NO;

  • trunk/Source/WebCore/ChangeLog

    r122354 r122356  
     12012-07-11  Anders Carlsson  <andersca@apple.com>
     2
     3        Add -Wtautological-compare and -Wsign-compare warning flags
     4        https://bugs.webkit.org/show_bug.cgi?id=90994
     5
     6        Reviewed by Mark Rowe.
     7
     8        * Configurations/Base.xcconfig:
     9
    1102012-07-11  Dean Jackson  <dino@apple.com>
    211

  • trunk/Source/WebCore/Configurations/Base.xcconfig

    r115501 r122356  
    2525
    2626COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
    27 COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
     27COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
    2828
    2929CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    5252GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
    5353GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     54GCC_WARN_SIGN_COMPARE = YES;
    5455LINKER_DISPLAYS_MANGLED_NAMES = YES;
    5556PREBINDING = NO;

  • trunk/Source/WebKit/mac/ChangeLog

    r122352 r122356  
     12012-07-11  Anders Carlsson  <andersca@apple.com>
     2
     3        Add -Wtautological-compare and -Wsign-compare warning flags
     4        https://bugs.webkit.org/show_bug.cgi?id=90994
     5
     6        Reviewed by Mark Rowe.
     7
     8        * Configurations/Base.xcconfig:
     9
    1102012-07-11  Mark Rowe  <mrowe@apple.com>
    211

  • trunk/Source/WebKit/mac/Configurations/Base.xcconfig

    r115501 r122356  
    2525
    2626COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
    27 COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
     27COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
    2828
    2929CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    5252GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
    5353GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     54GCC_WARN_SIGN_COMPARE = YES;
    5455LINKER_DISPLAYS_MANGLED_NAMES = YES;
    5556OTHER_MIGFLAGS = -F$(BUILT_PRODUCTS_DIR);

  • trunk/Source/WebKit2/ChangeLog

    r122355 r122356  
     12012-07-11  Anders Carlsson  <andersca@apple.com>
     2
     3        Add -Wtautological-compare and -Wsign-compare warning flags
     4        https://bugs.webkit.org/show_bug.cgi?id=90994
     5
     6        Reviewed by Mark Rowe.
     7
     8        * Configurations/Base.xcconfig:
     9
    1102012-07-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
    211

  • trunk/Source/WebKit2/Configurations/Base.xcconfig

    r115501 r122356  
    2525
    2626COMPILER_SPECIFIC_WARNING_CFLAGS = $(COMPILER_SPECIFIC_WARNING_CFLAGS_$(TARGET_GCC_VERSION));
    27 COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wglobal-constructors -Wexit-time-destructors;
     27COMPILER_SPECIFIC_WARNING_CFLAGS_LLVM_COMPILER = -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare;
    2828
    2929CLANG_WARN_CXX0X_EXTENSIONS = NO;
    … …  
    5050GCC_WARN_ABOUT_RETURN_TYPE = YES;
    5151GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
     52GCC_WARN_SIGN_COMPARE = YES;
    5253GCC_WARN_UNUSED_VARIABLE = YES;
    5354LINKER_DISPLAYS_MANGLED_NAMES = YES;
Note: See TracChangeset for help on using the changeset viewer.