Changeset 122372 in webkit


Ignore:
Timestamp:
Jul 11, 2012 2:20:50 PM (12 years ago)
Author:
Chris Fleizach
Message:

ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
​https://bugs.webkit.org/show_bug.cgi?id=77298

Reviewed by Anders Carlsson.

Source/WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

LayoutTests:

  • platform/mac/accessibility/aria-spinbutton-expected.txt:
  • platform/mac/accessibility/aria-spinbutton.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r122367 r122372  
     12012-07-11  Chris Fleizach  <cfleizach@apple.com>
     2
     3        ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
     4        https://bugs.webkit.org/show_bug.cgi?id=77298
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * platform/mac/accessibility/aria-spinbutton-expected.txt:
     9        * platform/mac/accessibility/aria-spinbutton.html:
     10
    1112012-07-11  Zan Dobersek  <zandobersek@gmail.com>
    212

  • trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton-expected.txt

    r41751 r122372  
    1 In accessibility, the following should be a progress indicator:
     1In accessibility, the following should be an incrementor:
    22
    33X
    44
    5 This test PASSES in DumpRenderTree. The role is AXRole: AXProgressIndicator
     5This test PASSES in DumpRenderTree. The role is AXRole: AXIncrementor

  • trunk/LayoutTests/platform/mac/accessibility/aria-spinbutton.html

    r120111 r122372  
    1414       
    1515        var result = document.getElementById("result");
    16         if (ariaRole == "AXRole: AXProgressIndicator")
     16        if (ariaRole == "AXRole: AXIncrementor")
    1717            result.innerText = "This test PASSES in DumpRenderTree. The role is " + ariaRole;
    1818        else
    19             result.innerText = "This test FAILS in DumpRenderTree. The ARIA role is " + ariaRole + ", but should be AXProgressIndicator";
     19            result.innerText = "This test FAILS in DumpRenderTree. The ARIA role is " + ariaRole + ", but should be AXIncrementor";
    2020    }
    2121</script>
    2222
    2323<div>
    24     <p>In accessibility, the following should be a progress indicator:</p>
     24    <p>In accessibility, the following should be an incrementor:</p>
    2525    <p><span tabindex="0" role="spinbutton" id="spinbutton" aria-valuenow=5 aria-valuemin=0 aria-valuemax=10>X</span></p>
    2626    <span id="result"></span>

  • trunk/Source/WebCore/ChangeLog

    r122368 r122372  
     12012-07-11  Chris Fleizach  <cfleizach@apple.com>
     2
     3        ARIA spinbutton role incorrectly mapped to ProgressIndicatorRole
     4        https://bugs.webkit.org/show_bug.cgi?id=77298
     5
     6        Reviewed by Anders Carlsson.
     7
     8        * accessibility/AccessibilityObject.cpp:
     9        (WebCore::createARIARoleMap):
     10
    1112012-07-11  Huang Dongsung  <luxtella@company100.net>
    212

  • trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

    r119012 r122372  
    14001400        { "separator", SplitterRole },
    14011401        { "slider", SliderRole },
    1402         { "spinbutton", ProgressIndicatorRole },
     1402        { "spinbutton", SpinButtonRole },
    14031403        { "status", ApplicationStatusRole },
    14041404        { "tab", TabRole },
Note: See TracChangeset for help on using the changeset viewer.