Changeset 122420 in webkit


Ignore:
Timestamp:
Jul 11, 2012 10:33:03 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Add dialog element feature toggle to InternalSettings
​https://bugs.webkit.org/show_bug.cgi?id=90934

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-07-11
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Added newly exported symbol.

Source/WebCore:

This enables layout tests to be written for dialog although the feature is disabled by default.

Tests: fast/dom/HTMLDialogElement/dialog-disabled.html

fast/dom/HTMLDialogElement/dialog-enabled.html

  • WebCore.exp.in: Added newly exported symbol.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Backup dialog feature flag.
(WebCore::InternalSettings::Backup::restoreTo): Restore dialog feature flag.
(WebCore::InternalSettings::setDialogElementEnabled): Added.
(WebCore):

  • testing/InternalSettings.h: Added support for dialog.

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl: Added support for dialog.

LayoutTests:

  • fast/dom/HTMLDialogElement/dialog-disabled-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-disabled.html: Added.
  • fast/dom/HTMLDialogElement/dialog-enabled-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-enabled.html: Added.
  • platform/efl/TestExpectations: Skipped because ENABLE_DIALOG_ELEMENT is off by default.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
Location:
trunk
Files:
5 added
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r122346 r122420  
     12012-07-11  Matt Falkenhagen  <falken@chromium.org>
     2
     3        Add dialog element feature toggle to InternalSettings
     4        https://bugs.webkit.org/show_bug.cgi?id=90934
     5
     6        Reviewed by Hajime Morita.
     7
     8        * Source/autotools/symbols.filter: Added newly exported symbol.
     9
    1102012-07-11  Arnaud Renevier  <a.renevier@sisa.samsung.com>
    211

  • trunk/LayoutTests/ChangeLog

    r122419 r122420  
     12012-07-11  Matt Falkenhagen  <falken@chromium.org>
     2
     3        Add dialog element feature toggle to InternalSettings
     4        https://bugs.webkit.org/show_bug.cgi?id=90934
     5
     6        Reviewed by Hajime Morita.
     7
     8        * fast/dom/HTMLDialogElement/dialog-disabled-expected.txt: Added.
     9        * fast/dom/HTMLDialogElement/dialog-disabled.html: Added.
     10        * fast/dom/HTMLDialogElement/dialog-enabled-expected.txt: Added.
     11        * fast/dom/HTMLDialogElement/dialog-enabled.html: Added.
     12        * platform/efl/TestExpectations: Skipped because ENABLE_DIALOG_ELEMENT is off by default.
     13        * platform/gtk/TestExpectations: Ditto.
     14        * platform/mac/TestExpectations: Ditto.
     15        * platform/qt/TestExpectations: Ditto.
     16
    1172012-07-11  Hayato Ito  <hayato@chromium.org>
    218

  • trunk/LayoutTests/platform/efl/TestExpectations

    r122314 r122420  
    136136BUGWK84186 SKIP : fast/text-autosizing = PASS
    137137
     138// Dialog element is not yet enabled.
     139BUGWK84635 SKIP : fast/dom/HTMLDialogElement = TEXT
    138140//////////////////////////////////////////////////////////////////////////////////////////
    139141// CRASHES

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r122367 r122420  
    350350BUGWK84186 SKIP : fast/text-autosizing = PASS
    351351
     352// Dialog element is not yet enabled.
     353BUGWK84635 SKIP : fast/dom/HTMLDialogElement = TEXT
    352354//////////////////////////////////////////////////////////////////////////////////////////
    353355// End of Expected failures

  • trunk/LayoutTests/platform/mac/TestExpectations

    r121907 r122420  
    290290// Text Autosizing is not enabled.
    291291BUGWK84186 SKIP : fast/text-autosizing = PASS
     292
     293// Dialog element is not yet enabled.
     294BUGWK84635 SKIP : fast/dom/HTMLDialogElement = TEXT

  • trunk/LayoutTests/platform/qt/TestExpectations

    r122324 r122420  
    111111// Text Autosizing is not enabled.
    112112BUGWK84186 SKIP : fast/text-autosizing = PASS
     113
     114// Dialog element is not yet enabled.
     115BUGWK84635 SKIP : fast/dom/HTMLDialogElement = TEXT

  • trunk/Source/WebCore/ChangeLog

    r122418 r122420  
     12012-07-11  Matt Falkenhagen  <falken@chromium.org>
     2
     3        Add dialog element feature toggle to InternalSettings
     4        https://bugs.webkit.org/show_bug.cgi?id=90934
     5
     6        Reviewed by Hajime Morita.
     7
     8        This enables layout tests to be written for dialog although the feature is disabled by default.
     9
     10        Tests: fast/dom/HTMLDialogElement/dialog-disabled.html
     11               fast/dom/HTMLDialogElement/dialog-enabled.html
     12
     13        * WebCore.exp.in: Added newly exported symbol.
     14        * testing/InternalSettings.cpp:
     15        (WebCore::InternalSettings::Backup::Backup): Backup dialog feature flag.
     16        (WebCore::InternalSettings::Backup::restoreTo): Restore dialog feature flag.
     17        (WebCore::InternalSettings::setDialogElementEnabled): Added.
     18        (WebCore):
     19        * testing/InternalSettings.h: Added support for dialog.
     20        (Backup):
     21        (InternalSettings):
     22        * testing/InternalSettings.idl: Added support for dialog.
     23
    1242012-07-11  Kent Tamura  <tkent@chromium.org>
    225

  • trunk/Source/WebCore/WebCore.exp.in

    r122400 r122420  
    23802380#endif
    23812381
     2382#if ENABLE(DIALOG_ELEMENT)
     2383__ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE
     2384#endif
     2385
    23822386#if ENABLE(SVG)
    23832387__ZN7WebCore14SVGSMILElement13isSMILElementEPNS_4NodeE

  • trunk/Source/WebCore/testing/InternalSettings.cpp

    r122326 r122420  
    9090    , m_originalTextAutosizingWindowSizeOverride(settings->textAutosizingWindowSizeOverride())
    9191#endif
     92#if ENABLE(DIALOG_ELEMENT)
     93    , m_originalDialogElementEnabled(RuntimeEnabledFeatures::dialogElementEnabled())
     94#endif
    9295{
    9396}
    … …  
    115118    settings->setTextAutosizingEnabled(m_originalTextAutosizingEnabled);
    116119    settings->setTextAutosizingWindowSizeOverride(m_originalTextAutosizingWindowSizeOverride);
     120#endif
     121#if ENABLE(DIALOG_ELEMENT)
     122    RuntimeEnabledFeatures::setDialogElementEnabled(m_originalDialogElementEnabled);
    117123#endif
    118124}
    … …  
    441447    InternalSettingsGuardForSettings();
    442448    settings()->setWindowFocusRestricted(restricted);
     449}
     450
     451void InternalSettings::setDialogElementEnabled(bool enabled, ExceptionCode& ec)
     452{
     453    UNUSED_PARAM(ec);
     454#if ENABLE(DIALOG_ELEMENT)
     455    RuntimeEnabledFeatures::setDialogElementEnabled(enabled);
     456#else
     457    UNUSED_PARAM(enabled);
     458#endif
    443459}
    444460
    … …  
    541557}
    542558
    543 
    544 }
     559}

  • trunk/Source/WebCore/testing/InternalSettings.h

    r122326 r122420  
    7272        IntSize m_originalTextAutosizingWindowSizeOverride;
    7373#endif
     74#if ENABLE(DIALOG_ELEMENT)
     75        bool m_originalDialogElementEnabled;
     76#endif
    7477    };
    7578
    … …  
    117120    void setSyncXHRInDocumentsEnabled(bool, ExceptionCode&);
    118121    void setWindowFocusRestricted(bool, ExceptionCode&);
     122    void setDialogElementEnabled(bool, ExceptionCode&);
    119123    void setJavaScriptProfilingEnabled(bool enabled, ExceptionCode&);
    120124    Vector<String> userPreferredLanguages() const;

  • trunk/Source/WebCore/testing/InternalSettings.idl

    r122326 r122420  
    6565        void setJavaScriptProfilingEnabled(in boolean creates) raises(DOMException);
    6666        void setWindowFocusRestricted(in boolean restricted) raises(DOMException);
     67        void setDialogElementEnabled(in boolean enabled) raises(DOMException);
    6768
    6869        void setPagination(in DOMString mode, in long gap) raises(DOMException);

  • trunk/Source/autotools/symbols.filter

    r122326 r122420  
    158158_ZN7WebCore22RuntimeEnabledFeatures18isShadowDOMEnabledE;
    159159_ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE;
     160_ZN7WebCore22RuntimeEnabledFeatures22isDialogElementEnabledE;
    160161_ZNK7WebCore8Document13nodesFromRectEiijjjjbb;
    161162_ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_8NodeListE;
Note: See TracChangeset for help on using the changeset viewer.