Changeset 122435 in webkit


Ignore:
Timestamp:
Jul 12, 2012 2:46:55 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
​https://bugs.webkit.org/show_bug.cgi?id=90867

Patch by Xingnan Wang <​xingnan.wang@intel.com> on 2012-07-12
Reviewed by Tony Chang.

Source/WebCore:

In the latest W3C spec upperOpen/lowerOpen are set to true in lowerBound()/upperBound(), which
we should keep aligned with.

No new tests - updated storage/indexeddb/keyrange.html to match new behavior.

  • Modules/indexeddb/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):

LayoutTests:

  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/resources/keyrange.js:

(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r122434 r122435  
     12012-07-12  Xingnan Wang  <xingnan.wang@intel.com>
     2
     3        [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
     4        https://bugs.webkit.org/show_bug.cgi?id=90867
     5
     6        Reviewed by Tony Chang.
     7
     8        * storage/indexeddb/keyrange-expected.txt:
     9        * storage/indexeddb/resources/keyrange.js:
     10        (checkLowerBoundKeyRange):
     11        (checkUpperBoundKeyRange):
     12
    1132012-07-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
    214

  • trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt

    r119161 r122435  
    4444PASS keyRange.lowerOpen is true
    4545PASS keyRange.upper is null
    46 PASS keyRange.upperOpen is false
     46PASS keyRange.upperOpen is true
    4747IDBKeyRange.lowerBound(11,false)
    4848PASS keyRange.lower is 11
    4949PASS keyRange.lowerOpen is false
    5050PASS keyRange.upper is null
    51 PASS keyRange.upperOpen is false
     51PASS keyRange.upperOpen is true
    5252IDBKeyRange.lowerBound(12,undefined)
    5353PASS keyRange.lower is 12
    5454PASS keyRange.lowerOpen is false
    5555PASS keyRange.upper is null
    56 PASS keyRange.upperOpen is false
     56PASS keyRange.upperOpen is true
    5757IDBKeyRange.lowerBound(10.1,true)
    5858PASS keyRange.lower is 10.1
    5959PASS keyRange.lowerOpen is true
    6060PASS keyRange.upper is null
    61 PASS keyRange.upperOpen is false
     61PASS keyRange.upperOpen is true
    6262IDBKeyRange.lowerBound(11.2,false)
    6363PASS keyRange.lower is 11.2
    6464PASS keyRange.lowerOpen is false
    6565PASS keyRange.upper is null
    66 PASS keyRange.upperOpen is false
     66PASS keyRange.upperOpen is true
    6767IDBKeyRange.lowerBound(12.3,undefined)
    6868PASS keyRange.lower is 12.3
    6969PASS keyRange.lowerOpen is false
    7070PASS keyRange.upper is null
    71 PASS keyRange.upperOpen is false
     71PASS keyRange.upperOpen is true
    7272IDBKeyRange.lowerBound('aa',true)
    7373PASS keyRange.lower is 'aa'
    7474PASS keyRange.lowerOpen is true
    7575PASS keyRange.upper is null
    76 PASS keyRange.upperOpen is false
     76PASS keyRange.upperOpen is true
    7777IDBKeyRange.lowerBound('ab',false)
    7878PASS keyRange.lower is 'ab'
    7979PASS keyRange.lowerOpen is false
    8080PASS keyRange.upper is null
    81 PASS keyRange.upperOpen is false
     81PASS keyRange.upperOpen is true
    8282IDBKeyRange.lowerBound('ac',undefined)
    8383PASS keyRange.lower is 'ac'
    8484PASS keyRange.lowerOpen is false
    8585PASS keyRange.upper is null
    86 PASS keyRange.upperOpen is false
     86PASS keyRange.upperOpen is true
    8787IDBKeyRange.upperBound(20,true)
    8888PASS keyRange.upper is 20
    8989PASS keyRange.upperOpen is true
    9090PASS keyRange.lower is null
    91 PASS keyRange.lowerOpen is false
     91PASS keyRange.lowerOpen is true
    9292IDBKeyRange.upperBound(21,false)
    9393PASS keyRange.upper is 21
    9494PASS keyRange.upperOpen is false
    9595PASS keyRange.lower is null
    96 PASS keyRange.lowerOpen is false
     96PASS keyRange.lowerOpen is true
    9797IDBKeyRange.upperBound(22,undefined)
    9898PASS keyRange.upper is 22
    9999PASS keyRange.upperOpen is false
    100100PASS keyRange.lower is null
    101 PASS keyRange.lowerOpen is false
     101PASS keyRange.lowerOpen is true
    102102IDBKeyRange.upperBound(20.2,true)
    103103PASS keyRange.upper is 20.2
    104104PASS keyRange.upperOpen is true
    105105PASS keyRange.lower is null
    106 PASS keyRange.lowerOpen is false
     106PASS keyRange.lowerOpen is true
    107107IDBKeyRange.upperBound(21.3,false)
    108108PASS keyRange.upper is 21.3
    109109PASS keyRange.upperOpen is false
    110110PASS keyRange.lower is null
    111 PASS keyRange.lowerOpen is false
     111PASS keyRange.lowerOpen is true
    112112IDBKeyRange.upperBound(22.4,undefined)
    113113PASS keyRange.upper is 22.4
    114114PASS keyRange.upperOpen is false
    115115PASS keyRange.lower is null
    116 PASS keyRange.lowerOpen is false
     116PASS keyRange.lowerOpen is true
    117117IDBKeyRange.upperBound('ba',true)
    118118PASS keyRange.upper is 'ba'
    119119PASS keyRange.upperOpen is true
    120120PASS keyRange.lower is null
    121 PASS keyRange.lowerOpen is false
     121PASS keyRange.lowerOpen is true
    122122IDBKeyRange.upperBound('bb',false)
    123123PASS keyRange.upper is 'bb'
    124124PASS keyRange.upperOpen is false
    125125PASS keyRange.lower is null
    126 PASS keyRange.lowerOpen is false
     126PASS keyRange.lowerOpen is true
    127127IDBKeyRange.upperBound('bc',undefined)
    128128PASS keyRange.upper is 'bc'
    129129PASS keyRange.upperOpen is false
    130130PASS keyRange.lower is null
    131 PASS keyRange.lowerOpen is false
     131PASS keyRange.lowerOpen is true
    132132IDBKeyRange.bound(30,40, undefined, undefined)
    133133PASS keyRange.lower is 30

  • trunk/LayoutTests/storage/indexeddb/resources/keyrange.js

    r119161 r122435  
    2323    shouldBe("keyRange.lowerOpen", "" + open);
    2424    shouldBeNull("keyRange.upper");
    25     shouldBeFalse("keyRange.upperOpen");
     25    shouldBeTrue("keyRange.upperOpen");
    2626}
    2727
    … …  
    3434    shouldBe("keyRange.upperOpen", "" + open);
    3535    shouldBeNull("keyRange.lower");
    36     shouldBeFalse("keyRange.lowerOpen");
     36    shouldBeTrue("keyRange.lowerOpen");
    3737}
    3838

  • trunk/Source/WebCore/ChangeLog

    r122432 r122435  
     12012-07-12  Xingnan Wang  <xingnan.wang@intel.com>
     2
     3        [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
     4        https://bugs.webkit.org/show_bug.cgi?id=90867
     5
     6        Reviewed by Tony Chang.
     7
     8        In the latest W3C spec upperOpen/lowerOpen are set to true in lowerBound()/upperBound(), which
     9        we should keep aligned with.
     10
     11        No new tests - updated storage/indexeddb/keyrange.html to match new behavior.
     12
     13        * Modules/indexeddb/IDBKeyRange.cpp:
     14        (WebCore::IDBKeyRange::lowerBound):
     15        (WebCore::IDBKeyRange::upperBound):
     16
    1172012-07-12  MORITA Hajime  <morrita@google.com>
    218

  • trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp

    r120888 r122435  
    6060    }
    6161
    62     return IDBKeyRange::create(bound, 0, open ? LowerBoundOpen : LowerBoundClosed, UpperBoundClosed);
     62    return IDBKeyRange::create(bound, 0, open ? LowerBoundOpen : LowerBoundClosed, UpperBoundOpen);
    6363}
    6464
    … …  
    7070    }
    7171
    72     return IDBKeyRange::create(0, bound, LowerBoundClosed, open ? UpperBoundOpen : UpperBoundClosed);
     72    return IDBKeyRange::create(0, bound, LowerBoundOpen, open ? UpperBoundOpen : UpperBoundClosed);
    7373}
    7474
Note: See TracChangeset for help on using the changeset viewer.