Changeset 122461 in webkit

Timestamp:

Jul 12, 2012 8:30:55 AM (12 years ago)

Author:

leandrogracia@chromium.org

Message:

[Chromium] Remove unrequired API in WebSurroundingText.
​https://bugs.webkit.org/show_bug.cgi?id=91067

Reviewed by Adam Barth.

Remove the unused first initialize method from WebSurroundingText.
Now both Chromium and LayoutTestController use the second method.

• public/WebSurroundingText.h:

(WebSurroundingText):

• src/WebSurroundingText.cpp:

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebSurroundingText.h (modified) (1 diff)
• src/WebSurroundingText.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-07-12  Leandro Gracia Gil  <leandrogracia@chromium.org>
+
+        [Chromium] Remove unrequired API in WebSurroundingText.
+        https://bugs.webkit.org/show_bug.cgi?id=91067
+
+        Reviewed by Adam Barth.
+
+        Remove the unused first initialize method from WebSurroundingText.
+        Now both Chromium and LayoutTestController use the second method.
+
+        * public/WebSurroundingText.h:
+        (WebSurroundingText):
+        * src/WebSurroundingText.cpp:
+
 2012-07-11  Mark Rowe  <mrowe@apple.com>
 

trunk/Source/WebKit/chromium/public/WebSurroundingText.h

@@ -49 +49 @@
     WEBKIT_EXPORT void reset();
 
-    // Initializes the object go get the surrounding text centered in the position described by the hit test.
-    // The maximum length of the contents retrieved is defined by maxLength.
-    WEBKIT_EXPORT void initialize(const WebHitTestResult&, size_t maxLength);
-
     // Initializes the object to get the surrounding text centered in the position relative to a provided node.
     // The maximum length of the contents retrieved is defined by maxLength.

trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp

@@ -41 +41 @@
 namespace WebKit {
 
-void WebSurroundingText::initialize(const WebHitTestResult& hitTestResult, size_t maxLength)
-{
-    Node* node = hitTestResult.node().unwrap<Node>();
-    if (!node || !node->renderer())
-        return;
-
-    m_private.reset(new SurroundingText(VisiblePosition(node->renderer()->positionForPoint(static_cast<IntPoint>(hitTestResult.localPoint()))), maxLength));
-}
-
 void WebSurroundingText::initialize(const WebNode& webNode, const WebPoint& nodePoint, size_t maxLength)
 {