Changeset 122535 in webkit

Timestamp:

Jul 12, 2012 6:53:17 PM (12 years ago)

Author:

arv@chromium.org

Message:

[V8] Simplify CodeGeneratorV8 since V8OnProto is only true for DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=91165

Reviewed by Nate Chapin.

The old code was dead code since V8OnProto only ever gets set to 1 for DOMWindow.

No new tests. No change in functionality.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-12  Erik Arvidsson  <arv@chromium.org>
+
+        [V8] Simplify CodeGeneratorV8 since V8OnProto is only true for DOMWindow
+        https://bugs.webkit.org/show_bug.cgi?id=91165
+
+        Reviewed by Nate Chapin.
+
+        The old code was dead code since V8OnProto only ever gets set to 1 for DOMWindow.
+
+        No new tests. No change in functionality.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateNormalAttrSetter):
+
 2012-07-12  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -1135 +1135 @@
         }
     } elsif ($attrExt->{"V8OnProto"}) {
-      if ($interfaceName eq "DOMWindow") {
         push(@implContentDecls, <<END);
-    v8::Handle<v8::Object> holder = info.Holder();
-END
-      } else {
-        # perform lookup first
-        push(@implContentDecls, <<END);
-    v8::Handle<v8::Object> holder = V8DOMWrapper::lookupDOMWrapper(V8${interfaceName}::GetTemplate(), info.This());
-    if (holder.IsEmpty())
-        return;
-END
-      }
-    push(@implContentDecls, <<END);
-    ${implClassName}* imp = V8${implClassName}::toNative(holder);
+    ${implClassName}* imp = V8${implClassName}::toNative(info.Holder());
 END
     } else {