Changeset 122555 in webkit

Timestamp:

Jul 13, 2012 2:38:50 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[V8Bindings] Implement generalised method to validates that the passed object is a sequence type.
​https://bugs.webkit.org/show_bug.cgi?id=91056

Patch by Vineet Chaudhary <Vineet> on 2012-07-13
Reviewed by Kentaro Hara.

Currently the V8 implementation validates that the passed object is a sequence type only
for MessagePort in V8Utilities::extractTransferables().
There should be generalised method for other types too.
Spec URL: ​http://www.w3.org/TR/2012/WD-WebIDL-20120207/#es-sequence

No new test, Just refactoring. There should be no behavioral changes.

• bindings/v8/V8Binding.h:

(WebCore::toV8Sequence): Added implementation of toV8Sequence().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8Binding.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-13  Vineet Chaudhary  <rgf748@motorola.com>
+
+        [V8Bindings] Implement generalised method to validates that the passed object is a sequence type.
+        https://bugs.webkit.org/show_bug.cgi?id=91056
+
+        Reviewed by Kentaro Hara.
+
+        Currently the V8 implementation validates that the passed object is a sequence type only
+        for MessagePort in V8Utilities::extractTransferables().
+        There should be generalised method for other types too.
+        Spec URL: http://www.w3.org/TR/2012/WD-WebIDL-20120207/#es-sequence
+
+        No new test, Just refactoring. There should be no behavioral changes.
+
+        * bindings/v8/V8Binding.h:
+        (WebCore::toV8Sequence): Added implementation of toV8Sequence().
+
 2012-07-13  Zeno Albisser  <zeno@webkit.org>
 

trunk/Source/WebCore/bindings/v8/V8Binding.h

@@ -35 +35 @@
 #include "DOMDataStore.h"
 #include "PlatformString.h"
+#include "V8BindingMacros.h"
 #include "V8DOMWrapper.h"
 #include "V8GCController.h"
@@ -438 +439 @@
         }
         return result;
+    }
+
+    // Validates that the passed object is a sequence type per WebIDL spec
+    // http://www.w3.org/TR/2012/WD-WebIDL-20120207/#es-sequence
+    inline v8::Handle<v8::Value> toV8Sequence(v8::Handle<v8::Value> value, uint32_t& length)
+    {
+        if (!value->IsObject()) {
+            V8Proxy::throwTypeError();
+            return v8::Local<v8::Value>();
+        }
+
+        v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(value));
+        v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(v8Value);
+
+        EXCEPTION_BLOCK(v8::Local<v8::Value>, lengthValue, object->Get(v8::String::New("length")));
+
+        if (lengthValue->IsUndefined() || lengthValue->IsNull()) {
+            V8Proxy::throwTypeError();
+            return v8::Local<v8::Value>();
+        }
+
+        EXCEPTION_BLOCK(uint32_t, sequenceLength, lengthValue->Int32Value());
+        length = sequenceLength;
+
+        return v8Value;
     }