Changeset 122563 in webkit


Ignore:
Timestamp:
Jul 13, 2012 4:24:25 AM (12 years ago)
Author:
gyuyoung.kim@samsung.com
Message:

[EFL] Add *explicit* keyword to constructor which has a parameter
​https://bugs.webkit.org/show_bug.cgi?id=91207

Reviewed by Zoltan Herczeg.

Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

  • WebCoreSupport/InspectorClientEfl.h:

(InspectorClientEfl):

  • WebCoreSupport/PageClientEfl.h:

(PageClientEfl):

  • WebCoreSupport/VibrationClientEfl.h:

(VibrationClientEfl):

Source/WebKit2:

  • WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::WebFrameNetworkingContext):

Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/efl/ChangeLog

    r122204 r122563  
     12012-07-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
     2
     3        [EFL] Add *explicit* keyword to constructor which has a parameter
     4        https://bugs.webkit.org/show_bug.cgi?id=91207
     5
     6        Reviewed by Zoltan Herczeg.
     7
     8        Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
     9
     10        * WebCoreSupport/EditorClientEfl.h:
     11        (EditorClientEfl):
     12        * WebCoreSupport/InspectorClientEfl.h:
     13        (InspectorClientEfl):
     14        * WebCoreSupport/PageClientEfl.h:
     15        (PageClientEfl):
     16        * WebCoreSupport/VibrationClientEfl.h:
     17        (VibrationClientEfl):
     18
    1192012-07-10  Adam Barth  <abarth@webkit.org>
    220

  • trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h

    r119192 r122563  
    7878
    7979public:
    80     EditorClientEfl(Evas_Object *view);
     80    explicit EditorClientEfl(Evas_Object* view);
    8181    ~EditorClientEfl();
    8282

  • trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h

    r121947 r122563  
    4444class InspectorClientEfl : public InspectorClient {
    4545public:
    46     InspectorClientEfl(Evas_Object*);
     46    explicit InspectorClientEfl(Evas_Object*);
    4747    ~InspectorClientEfl();
    4848

  • trunk/Source/WebKit/efl/WebCoreSupport/PageClientEfl.h

    r122057 r122563  
    3232class PageClientEfl {
    3333public:
    34     PageClientEfl(Evas_Object* view);
     34    explicit PageClientEfl(Evas_Object* view);
    3535    virtual ~PageClientEfl();
    3636

  • trunk/Source/WebKit/efl/WebCoreSupport/VibrationClientEfl.h

    r108272 r122563  
    2828class VibrationClientEfl : public VibrationClient {
    2929public:
    30     VibrationClientEfl(Evas_Object* view);
     30    explicit VibrationClientEfl(Evas_Object* view);
    3131    virtual ~VibrationClientEfl() { }
    3232

  • trunk/Source/WebKit2/ChangeLog

    r122554 r122563  
     12012-07-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
     2
     3        [EFL] Add *explicit* keyword to constructor which has a parameter
     4        https://bugs.webkit.org/show_bug.cgi?id=91207
     5
     6        Reviewed by Zoltan Herczeg.
     7
     8        Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
     9
     10        * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h:
     11        (WebFrameNetworkingContext::WebFrameNetworkingContext):
     12
    1132012-07-13  Zeno Albisser  <zeno@webkit.org>
    214

  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h

    r104168 r122563  
    3939
    4040private:
    41     WebFrameNetworkingContext(WebKit::WebFrame* frame)
     41    explicit WebFrameNetworkingContext(WebKit::WebFrame* frame)
    4242        : WebCore::FrameNetworkingContext(frame->coreFrame())
    4343    {
Note: See TracChangeset for help on using the changeset viewer.