Changeset 122622 in webkit


Ignore:
Timestamp:
Jul 13, 2012 12:54:37 PM (12 years ago)
Author:
dgrogan@chromium.org
Message:

IndexedDB: Re-enable indexeddb in test_shell
https://bugs.webkit.org/show_bug.cgi?id=91161

Reviewed by Tony Chang.

IDB used to be allowed to run if webView->permissionClient() was NULL,
as is the case in test_shell. This was inadvertently changed in
http://wkb.ug/90310.

We still don't have an automated test for this (http://crbug.com/113738)
Tested manually:

  • In test_shell:

1) Open an IDB page
2) Verify IDB has permission to open a DB

  • In chrome:

1) Open an IDB page
2) Verify IDB has permission to open a DB
3) Revoke IDB permissions in chrome://chrome/settings/content
4) Reload the IDB page
5) Verify IDB doesn't have permission to open a DB

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB):

Location:
trunk/Source/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r122606 r122622  
     12012-07-13  David Grogan  <dgrogan@chromium.org>
     2
     3        IndexedDB: Re-enable indexeddb in test_shell
     4        https://bugs.webkit.org/show_bug.cgi?id=91161
     5
     6        Reviewed by Tony Chang.
     7
     8        IDB used to be allowed to run if webView->permissionClient() was NULL,
     9        as is the case in test_shell. This was inadvertently changed in
     10        http://wkb.ug/90310.
     11
     12        We still don't have an automated test for this (http://crbug.com/113738)
     13        Tested manually:
     14
     15        * In test_shell:
     16        1) Open an IDB page
     17        2) Verify IDB has permission to open a DB
     18
     19        * In chrome:
     20        1) Open an IDB page
     21        2) Verify IDB has permission to open a DB
     22        3) Revoke IDB permissions in chrome://chrome/settings/content
     23        4) Reload the IDB page
     24        5) Verify IDB doesn't have permission to open a DB
     25
     26        * src/IDBFactoryBackendProxy.cpp:
     27        (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
     28
    1292012-07-13  Wei James  <james.wei@intel.com>
    230
  • trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp

    r122515 r122622  
    157157        WebFrameImpl* webFrame = WebFrameImpl::fromFrame(document->frame());
    158158        WebViewImpl* webView = webFrame->viewImpl();
    159         allowed = webView->permissionClient() && webView->permissionClient()->allowIndexedDB(webFrame, name, origin);
     159        // FIXME: webView->permissionClient() returns 0 in test_shell and content_shell http://crbug.com/137269
     160        allowed = !webView->permissionClient() || webView->permissionClient()->allowIndexedDB(webFrame, name, origin);
    160161    } else {
    161162        WorkerContext* workerContext = static_cast<WorkerContext*>(context);
Note: See TracChangeset for help on using the changeset viewer.