Changeset 122631 in webkit

Timestamp:

Jul 13, 2012 2:16:39 PM (12 years ago)

Author:

dpranke@chromium.org

Message:

webkitpy: hide yield_to_caller from callers in MessagePool :)
​https://bugs.webkit.org/show_bug.cgi?id=91269

Reviewed by Adam Barth.

yield_to_caller() was an optimization/hack to allow us to run
both manager and worker in a single process/loop without
starving the manager while the worker is running tests. The
worker was required to call yield_to_caller() periodically. It
turns out that I can get equivalent responsiveness by yielding
inside the MessagePool every time the worker posts a message, and this
allows me to no longer need the worker to call the routine. Thus
I rename yield_to_caller() to _yield_to_manager() to be a little
clearer about its purpose.

Tested by existing tests.

• Scripts/webkitpy/common/message_pool.py:

(_Worker.run):
(_Worker.post):
(_Worker._yield_to_manager):

• Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.handle):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/message_pool.py (modified) (2 diffs)
• Scripts/webkitpy/layout_tests/controllers/worker.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-07-13  Dirk Pranke  <dpranke@chromium.org>
+
+        webkitpy: hide yield_to_caller from callers in MessagePool :)
+        https://bugs.webkit.org/show_bug.cgi?id=91269
+
+        Reviewed by Adam Barth.
+
+        yield_to_caller() was an optimization/hack to allow us to run
+        both manager and worker in a single process/loop without
+        starving the manager while the worker is running tests. The
+        worker was required to call yield_to_caller() periodically. It
+        turns out that I can get equivalent responsiveness by yielding
+        inside the MessagePool every time the worker posts a message, and this
+        allows me to no longer need the worker to call the routine. Thus
+        I rename yield_to_caller() to _yield_to_manager() to be a little
+        clearer about its purpose.
+
+        Tested by existing tests.
+
+        * Scripts/webkitpy/common/message_pool.py:
+        (_Worker.run):
+        (_Worker.post):
+        (_Worker._yield_to_manager):
+        * Scripts/webkitpy/layout_tests/controllers/worker.py:
+        (Worker.handle):
+
 2012-07-13  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/common/message_pool.py

@@ -243 +243 @@
                 if message.from_user:
                     worker.handle(message.name, message.src, *message.args)
-                    self.yield_to_caller()
+                    self._yield_to_manager()
                 else:
                     assert message.name == 'stop', 'bad message %s' % repr(message)
@@ -265 +265 @@
     def post(self, name, *args):
         self._post(name, args, from_user=True)
-
-    def yield_to_caller(self):
+        self._yield_to_manager()
+
+    def _yield_to_manager(self):
         if self._running_inline:
             self._manager._loop(block=False)

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py

@@ -80 +80 @@
         for test_input in test_inputs:
             self._run_test(test_input)
-            self._caller.yield_to_caller()
         elapsed_time = time.time() - start_time
         self._caller.post('finished_test_list', test_list_name, len(test_inputs), elapsed_time)