Changeset 122638 in webkit

Timestamp:

Jul 13, 2012 3:46:41 PM (12 years ago)

Author:

staikos@webkit.org

Message:

[BlackBerry] Fix crash due to unguarded use of renderer in select
popup.
​https://bugs.webkit.org/show_bug.cgi?id=91287

Reviewed by Rob Buis.

No known testcase for this. Found in the wild.

• WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/SelectPopupClient.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-07-13  George Staikos  <staikos@webkit.org>
+
+        [BlackBerry] Fix crash due to unguarded use of renderer in select
+        popup.
+        https://bugs.webkit.org/show_bug.cgi?id=91287
+
+        Reviewed by Rob Buis.
+
+        No known testcase for this.  Found in the wild.
+
+        * WebCoreSupport/SelectPopupClient.cpp:
+        (WebCore::SelectPopupClient::setValueAndClosePopup):
+
 2012-07-13  Mike Fenton  <mifenton@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp

@@ -169 +169 @@
     // and the element doesn't automatically repaint itself.
     m_element->dispatchFormControlChangeEvent();
-    m_element->renderer()->repaint();
+    if (m_element->renderer())
+        m_element->renderer()->repaint();
     closePopup();
 }