Changeset 122657 in webkit

Timestamp:

Jul 13, 2012 7:09:44 PM (12 years ago)

Author:

dpranke@chromium.org

Message:

nrwt: actually print the exception name and message for otherwise unhandled exceptions
​https://bugs.webkit.org/show_bug.cgi?id=91305

Reviewed by Adam Barth.

Two more places where I was printing the stack trace but not the
exception itself :(. These two spots can't easily be
unit-tested, but I tested them by hand.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/run_webkit_tests.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-07-13  Dirk Pranke  <dpranke@chromium.org>
+
+        nrwt: actually print the exception name and message for otherwise unhandled exceptions
+        https://bugs.webkit.org/show_bug.cgi?id=91305
+
+        Reviewed by Adam Barth.
+
+        Two more places where I was printing the stack trace but not the
+        exception itself :(. These two spots can't easily be
+        unit-tested, but I tested them by hand.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+        (run):
+        (main):
+
 2012-07-13  Josh Hawn  <jhawn@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -133 +133 @@
         exception_type, exception_value, exception_traceback = sys.exc_info()
         if exception_type not in (KeyboardInterrupt, TestRunInterruptedException, WorkerException):
+            print >> sys.stderr, '\n%s raised: %s' % (exception_type.__name__, exception_value)
             stack_utils.log_traceback(_log.error, exception_traceback)
         raise
@@ -471 +472 @@
         print >> sys.stderr, str(e)
         return EXCEPTIONAL_EXIT_STATUS
-    except:
+    except Exception, e:
+        print >> sys.stderr, '\n%s raised: %s' % (e.__class__.__name__, str(e))
         traceback.print_exc(file=sys.stderr)
         raise