Changeset 122769 in webkit
- Timestamp:
- Jul 16, 2012 3:10:46 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 23 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r122763 r122769 1 2012-07-16 Emil A Eklund <eae@chromium.org> 2 3 Inconsistent rounding in table layout causes background color to bleed through 4 https://bugs.webkit.org/show_bug.cgi?id=91410 5 6 Reviewed by Eric Seidel. 7 8 Add test to ensure that the table background color doesn't bleed through 9 when the table and a cell are positioned on a subpixel bound. 10 11 * fast/sub-pixel/table-rows-no-gaps-expected.html: Added. 12 * fast/sub-pixel/table-rows-no-gaps.html: Added. 13 * platform/chromium-linux/css1/basic/inheritance-expected.png: 14 * platform/chromium-linux/plugins/embed-attributes-style-expected.png: 15 * platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: 16 * platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: 17 * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: 18 * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: 19 * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: 20 * platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png: 21 Updated expectations to match new rounding logic. The new results better 22 match the rendering prior to turning on subpixel layout. 23 24 * platform/efl/Skipped: 25 * platform/mac-lion/Skipped: 26 * platform/mac-snowleopard/Skipped: 27 * platform/mac-wk2/Skipped: 28 * platform/mac/Skipped: 29 * platform/qt-4.8/Skipped: 30 * platform/qt/Skipped: 31 * platform/win-wk2/Skipped: 32 * platform/win-xp/Skipped: 33 * platform/win/Skipped: 34 * platform/wincairo/Skipped: 35 * platform/wk2/Skipped: 36 Mark new test as skipped on platforms that have not enabled subpixel 37 layout. 38 1 39 2012-07-16 W. James MacLean <wjmaclean@chromium.org> 2 40 -
trunk/LayoutTests/platform/efl/Skipped
r122314 r122769 1112 1112 fast/sub-pixel/client-rect-has-subpixel-precision.html 1113 1113 fast/sub-pixel/client-width-height-snapping.html 1114 fast/sub-pixel/file-upload-control-at-fractional-offset.html 1114 1115 fast/sub-pixel/float-containing-block-with-margin.html 1115 1116 fast/sub-pixel/float-with-right-margin-zoom.html … … 1118 1119 fast/sub-pixel/inline-block-with-padding.html 1119 1120 fast/sub-pixel/layout-boxes-with-zoom.html 1121 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 1120 1122 fast/sub-pixel/size-of-box-with-zoom.html 1121 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 1122 fast/sub-pixel/file-upload-control-at-fractional-offset.html 1123 fast/sub-pixel/table-rows-no-gaps.html 1123 1124 1124 1125 # This should only be a layer change -
trunk/LayoutTests/platform/mac-lion/Skipped
r120357 r122769 105 105 fast/sub-pixel/client-rect-has-subpixel-precision.html 106 106 fast/sub-pixel/client-width-height-snapping.html 107 fast/sub-pixel/file-upload-control-at-fractional-offset.html 107 108 fast/sub-pixel/float-containing-block-with-margin.html 108 109 fast/sub-pixel/float-with-right-margin-zoom.html … … 111 112 fast/sub-pixel/inline-block-with-padding.html 112 113 fast/sub-pixel/layout-boxes-with-zoom.html 114 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 113 115 fast/sub-pixel/size-of-box-with-zoom.html 114 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 115 fast/sub-pixel/file-upload-control-at-fractional-offset.html 116 fast/sub-pixel/table-rows-no-gaps.html 116 117 117 118 # This media test always failed on Lion -
trunk/LayoutTests/platform/mac-snowleopard/Skipped
r120357 r122769 199 199 fast/sub-pixel/client-rect-has-subpixel-precision.html 200 200 fast/sub-pixel/client-width-height-snapping.html 201 fast/sub-pixel/file-upload-control-at-fractional-offset.html 201 202 fast/sub-pixel/float-containing-block-with-margin.html 202 203 fast/sub-pixel/float-with-right-margin-zoom.html … … 205 206 fast/sub-pixel/inline-block-with-padding.html 206 207 fast/sub-pixel/layout-boxes-with-zoom.html 208 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 207 209 fast/sub-pixel/size-of-box-with-zoom.html 208 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 209 fast/sub-pixel/file-upload-control-at-fractional-offset.html 210 fast/sub-pixel/table-rows-no-gaps.html 210 211 211 212 # Frame::findString does nothing on pages that prevent selection -
trunk/LayoutTests/platform/mac-wk2/Skipped
r121440 r122769 205 205 fast/sub-pixel/client-rect-has-subpixel-precision.html 206 206 fast/sub-pixel/client-width-height-snapping.html 207 fast/sub-pixel/file-upload-control-at-fractional-offset.html 207 208 fast/sub-pixel/float-containing-block-with-margin.html 208 209 fast/sub-pixel/float-with-right-margin-zoom.html … … 211 212 fast/sub-pixel/inline-block-with-padding.html 212 213 fast/sub-pixel/layout-boxes-with-zoom.html 214 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 213 215 fast/sub-pixel/size-of-box-with-zoom.html 214 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 215 fast/sub-pixel/file-upload-control-at-fractional-offset.html 216 fast/sub-pixel/table-rows-no-gaps.html 216 217 217 218 # fast/events/pagehide-timeout.html, pageshow-pagehide-on-back-cached-with-frames.html, and -
trunk/LayoutTests/platform/mac/Skipped
r122528 r122769 811 811 fast/sub-pixel/client-rect-has-subpixel-precision.html 812 812 fast/sub-pixel/client-width-height-snapping.html 813 fast/sub-pixel/file-upload-control-at-fractional-offset.html 813 814 fast/sub-pixel/float-containing-block-with-margin.html 814 815 fast/sub-pixel/float-with-right-margin-zoom.html … … 817 818 fast/sub-pixel/inline-block-with-padding.html 818 819 fast/sub-pixel/layout-boxes-with-zoom.html 820 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 819 821 fast/sub-pixel/size-of-box-with-zoom.html 820 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 821 fast/sub-pixel/file-upload-control-at-fractional-offset.html 822 fast/sub-pixel/table-rows-no-gaps.html 822 823 823 824 # No CORS support for media elements is implemented yet. -
trunk/LayoutTests/platform/qt-4.8/Skipped
r121971 r122769 92 92 fast/sub-pixel/client-rect-has-subpixel-precision.html 93 93 fast/sub-pixel/client-width-height-snapping.html 94 fast/sub-pixel/file-upload-control-at-fractional-offset.html 94 95 fast/sub-pixel/float-containing-block-with-margin.html 95 96 fast/sub-pixel/float-with-right-margin-zoom.html … … 98 99 fast/sub-pixel/inline-block-with-padding.html 99 100 fast/sub-pixel/layout-boxes-with-zoom.html 101 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 100 102 fast/sub-pixel/size-of-box-with-zoom.html 101 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 102 fast/sub-pixel/file-upload-control-at-fractional-offset.html 103 fast/sub-pixel/table-rows-no-gaps.html 103 104 104 105 # SVG Fonts are only supported when using QRawFont, which is not -
trunk/LayoutTests/platform/qt/Skipped
r122724 r122769 224 224 fast/sub-pixel/client-rect-has-subpixel-precision.html 225 225 fast/sub-pixel/client-width-height-snapping.html 226 fast/sub-pixel/file-upload-control-at-fractional-offset.html 226 227 fast/sub-pixel/float-containing-block-with-margin.html 227 228 fast/sub-pixel/float-with-right-margin-zoom.html … … 230 231 fast/sub-pixel/inline-block-with-padding.html 231 232 fast/sub-pixel/layout-boxes-with-zoom.html 233 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 232 234 fast/sub-pixel/size-of-box-with-zoom.html 233 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 234 fast/sub-pixel/file-upload-control-at-fractional-offset.html 235 fast/sub-pixel/table-rows-no-gaps.html 235 236 236 237 # CSS Regions support not yet enabled. http://webkit.org/b/57312 -
trunk/LayoutTests/platform/win-wk2/Skipped
r121913 r122769 938 938 fast/sub-pixel/client-rect-has-subpixel-precision.html 939 939 fast/sub-pixel/client-width-height-snapping.html 940 fast/sub-pixel/file-upload-control-at-fractional-offset.html 940 941 fast/sub-pixel/float-containing-block-with-margin.html 941 942 fast/sub-pixel/float-with-right-margin-zoom.html … … 944 945 fast/sub-pixel/inline-block-with-padding.html 945 946 fast/sub-pixel/layout-boxes-with-zoom.html 947 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 946 948 fast/sub-pixel/size-of-box-with-zoom.html 947 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 948 fast/sub-pixel/file-upload-control-at-fractional-offset.html 949 fast/sub-pixel/table-rows-no-gaps.html 949 950 950 951 # HiDPI tests require test infrastructure enhancements -
trunk/LayoutTests/platform/win-xp/Skipped
r119659 r122769 38 38 fast/sub-pixel/client-rect-has-subpixel-precision.html 39 39 fast/sub-pixel/client-width-height-snapping.html 40 fast/sub-pixel/file-upload-control-at-fractional-offset.html 40 41 fast/sub-pixel/float-containing-block-with-margin.html 41 42 fast/sub-pixel/float-with-right-margin-zoom.html … … 44 45 fast/sub-pixel/inline-block-with-padding.html 45 46 fast/sub-pixel/layout-boxes-with-zoom.html 47 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 46 48 fast/sub-pixel/size-of-box-with-zoom.html 47 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 48 fast/sub-pixel/file-upload-control-at-fractional-offset.html 49 fast/sub-pixel/table-rows-no-gaps.html 49 50 50 51 # REGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend / MarkStack::drain -
trunk/LayoutTests/platform/win/Skipped
r122668 r122769 1730 1730 fast/sub-pixel/client-rect-has-subpixel-precision.html 1731 1731 fast/sub-pixel/client-width-height-snapping.html 1732 fast/sub-pixel/file-upload-control-at-fractional-offset.html 1732 1733 fast/sub-pixel/float-containing-block-with-margin.html 1733 1734 fast/sub-pixel/float-with-right-margin-zoom.html … … 1736 1737 fast/sub-pixel/inline-block-with-padding.html 1737 1738 fast/sub-pixel/layout-boxes-with-zoom.html 1739 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 1738 1740 fast/sub-pixel/size-of-box-with-zoom.html 1739 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 1740 fast/sub-pixel/file-upload-control-at-fractional-offset.html 1741 fast/sub-pixel/table-rows-no-gaps.html 1741 1742 1742 1743 # No CORS support for media elements is implemented yet. -
trunk/LayoutTests/platform/wincairo/Skipped
r122668 r122769 2095 2095 fast/sub-pixel/client-rect-has-subpixel-precision.html 2096 2096 fast/sub-pixel/client-width-height-snapping.html 2097 fast/sub-pixel/file-upload-control-at-fractional-offset.html 2097 2098 fast/sub-pixel/float-containing-block-with-margin.html 2098 2099 fast/sub-pixel/float-with-right-margin-zoom.html … … 2101 2102 fast/sub-pixel/inline-block-with-padding.html 2102 2103 fast/sub-pixel/layout-boxes-with-zoom.html 2104 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 2103 2105 fast/sub-pixel/size-of-box-with-zoom.html 2104 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html 2105 fast/sub-pixel/file-upload-control-at-fractional-offset.html 2106 fast/sub-pixel/table-rows-no-gaps.html 2106 2107 2107 2108 #Battery Status API is not implemented. -
trunk/LayoutTests/platform/wk2/Skipped
r122668 r122769 88 88 fast/sub-pixel/client-rect-has-subpixel-precision.html 89 89 fast/sub-pixel/client-width-height-snapping.html 90 fast/sub-pixel/file-upload-control-at-fractional-offset.html 90 91 fast/sub-pixel/float-containing-block-with-margin.html 91 92 fast/sub-pixel/float-with-right-margin-zoom.html … … 94 95 fast/sub-pixel/inline-block-with-padding.html 95 96 fast/sub-pixel/layout-boxes-with-zoom.html 97 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 96 98 fast/sub-pixel/size-of-box-with-zoom.html 97 fast/sub-pixel/selection-gaps-at-fractional-offsets.html 98 fast/sub-pixel/file-upload-control-at-fractional-offset.html 99 fast/sub-pixel/table-rows-no-gaps.html 99 100 100 101 # CONSOLE MESSAGE: line 0: SVG animation pause API missing! -
trunk/Source/WebCore/ChangeLog
r122767 r122769 1 2012-07-16 Emil A Eklund <eae@chromium.org> 2 3 Inconsistent rounding in table layout causes background color to bleed through 4 https://bugs.webkit.org/show_bug.cgi?id=91410 5 6 Reviewed by Eric Seidel. 7 8 At certain zoom levels a rounding error in the table layout code cases 9 the table background color to bleed through between cells. Tables layout 10 happens on pixel bounds however the paint offset wasn't correctly rounded. 11 12 Test: fast/sub-pixel/table-rows-no-gaps.html 13 14 * rendering/RenderTable.cpp: 15 (WebCore::RenderTable::paintObject): 16 Round paintOffset before passing it to the paint method of the children. 17 1 18 2012-07-16 Sheriff Bot <webkit.review.bot@gmail.com> 2 19 -
trunk/Source/WebCore/rendering/RenderTable.cpp
r122636 r122769 576 576 info.updatePaintingRootForChildren(this); 577 577 578 IntPoint alignedOffset = roundedIntPoint(paintOffset); 579 578 580 for (RenderObject* child = firstChild(); child; child = child->nextSibling()) { 579 581 if (child->isBox() && !toRenderBox(child)->hasSelfPaintingLayer() && (child->isTableSection() || child->isTableCaption())) { 580 LayoutPoint childPoint = flipForWritingModeForChild(toRenderBox(child), paintOffset);582 LayoutPoint childPoint = flipForWritingModeForChild(toRenderBox(child), alignedOffset); 581 583 child->paint(info, childPoint); 582 584 }
Note: See TracChangeset
for help on using the changeset viewer.