Changeset 122910 in webkit

Timestamp:

Jul 17, 2012 6:08:39 PM (12 years ago)

Author:

kinuko@chromium.org

Message:

Record metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
​https://bugs.webkit.org/show_bug.cgi?id=90534

Reviewed by Jian Li.

We are removing ArrayBuffer support in Blob constructor (in favor of
ArrayBufferView) but before doing that we should record its use relative to ArrayBufferView.
​http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob

No new tests as this has no functional changes.

• fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• fileapi/WebKitBlobBuilder.cpp (modified) (4 diffs)
• fileapi/WebKitBlobBuilder.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-17  Kinuko Yasuda  <kinuko@chromium.org>
+
+        Record metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
+        https://bugs.webkit.org/show_bug.cgi?id=90534
+
+        Reviewed by Jian Li.
+
+        We are removing ArrayBuffer support in Blob constructor (in favor of
+        ArrayBufferView) but before doing that we should record its use relative to ArrayBufferView.
+        http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
+
+        No new tests as this has no functional changes.
+
+        * fileapi/WebKitBlobBuilder.cpp:
+        (WebCore::WebKitBlobBuilder::append):
+
 2012-07-17  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp

@@ -36 +36 @@
 #include "ExceptionCode.h"
 #include "File.h"
+#include "HistogramSupport.h"
 #include "LineEnding.h"
 #include "ScriptExecutionContext.h"
@@ -47 +48 @@
 
 namespace WebCore {
+
+enum BlobConstructorArrayBufferOrView {
+    BlobConstructorArrayBuffer,
+    BlobConstructorArrayBufferView,
+    BlobConstructorArrayBufferOrViewMax,
+};
 
 // static
@@ -102 +109 @@
     String consoleMessage("ArrayBuffer values are deprecated in Blob Constructor. Use ArrayBufferView instead.");
     context->addConsoleMessage(JSMessageSource, LogMessageType, WarningMessageLevel, consoleMessage);
+
+    HistogramSupport::histogramEnumeration("WebCore.Blob.constructor.ArrayBufferOrView", BlobConstructorArrayBuffer, BlobConstructorArrayBufferOrViewMax);
+
     if (!arrayBuffer)
         return;
-    Vector<char>& buffer = getBuffer();
-    size_t oldSize = buffer.size();
-    buffer.append(static_cast<const char*>(arrayBuffer->data()), arrayBuffer->byteLength());
-    m_size += buffer.size() - oldSize;
+
+    appendBytesData(arrayBuffer->data(), arrayBuffer->byteLength());
 }
 
 void WebKitBlobBuilder::append(ArrayBufferView* arrayBufferView)
 {
+    HistogramSupport::histogramEnumeration("WebCore.Blob.constructor.ArrayBufferOrView", BlobConstructorArrayBufferView, BlobConstructorArrayBufferOrViewMax);
+
     if (!arrayBufferView)
         return;
-    Vector<char>& buffer = getBuffer();
-    size_t oldSize = buffer.size();
-    buffer.append(static_cast<const char*>(arrayBufferView->baseAddress()), arrayBufferView->byteLength());
-    m_size += buffer.size() - oldSize;
+
+    appendBytesData(arrayBufferView->baseAddress(), arrayBufferView->byteLength());
 }
 #endif
@@ -142 +150 @@
 }
 
+
+void WebKitBlobBuilder::appendBytesData(const void* data, size_t length)
+{
+    Vector<char>& buffer = getBuffer();
+    size_t oldSize = buffer.size();
+    buffer.append(static_cast<const char*>(data), length);
+    m_size += buffer.size() - oldSize;
+}
+
 PassRefPtr<Blob> WebKitBlobBuilder::getBlob(const String& contentType)
 {

trunk/Source/WebCore/fileapi/WebKitBlobBuilder.h

@@ -65 +65 @@
     WebKitBlobBuilder();
 
+    void appendBytesData(const void*, size_t);
+
     Vector<char>& getBuffer();