Changeset 123194 in webkit

Timestamp:

Jul 20, 2012 1:41:16 AM (12 years ago)

Author:

kinuko@chromium.org

Message:

If value for responseType defined as type that not supported, it should not throw an exception in XHR 2
​https://bugs.webkit.org/show_bug.cgi?id=90976

Reviewed by Alexey Proskuryakov.

Source/WebCore:

​http://www.w3.org/TR/XMLHttpRequest2/#the-responsetype-attribute
The spec does not say it should throw an exception when a non-supported
type is set, and other browsers do not throw it either.

Test: fast/xmlhttprequest/xmlhttprequest-responsetype-set-type.html

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setResponseType): Stop throwing an exception when non-supported type is given.

LayoutTests:

Adding tests to see if setting invalid responseType does not throw an exception and does not change the value.

• fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt: Added.
• fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html: Added.
• fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
• fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Removed a line which tries to set invalid type (since we now have a separate test)

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt (modified) (1 diff)
• LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html (modified) (1 diff)
• LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt (added)
• LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/xml/XMLHttpRequest.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-07-17  Kinuko Yasuda  <kinuko@chromium.org>
+
+        If value for responseType defined as type that not supported, it should not throw an exception in XHR 2
+        https://bugs.webkit.org/show_bug.cgi?id=90976
+
+        Reviewed by Alexey Proskuryakov.
+
+        Adding tests to see if setting invalid responseType does not throw an exception and does not change the value.
+
+        * fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt: Added.
+        * fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html: Added.
+        * fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
+        * fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Removed a line which tries to set invalid type (since we now have a separate test)
+
 2012-07-20  Matt Falkenhagen  <falken@chromium.org>
 

trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt

@@ -11 +11 @@
 PASS xhr.responseType has been correctly set to 'document'.
 PASS xhr.responseType has been correctly set to 'arraybuffer'.
-PASS exception correctly thrown when xhr.responseType is set to invalid value : Error: SYNTAX_ERR: DOM Exception 12.
 PASS 'arraybuffer' .response does not exist when .readyState is 2.
 PASS 'arraybuffer' .response does not exist when .readyState is 3.

trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html

@@ -139 +139 @@
             testFailed("unable to set xhr.responseType to a valid value " + e + ".");
         }
-
-        // Make sure exception is thrown if responseType is set to invalid value.
-        try {
-            xhr.responseType = "dkjdfkjdfkj";
-        } catch(e) {
-            testPassed("exception correctly thrown when xhr.responseType is set to invalid value : " + e + ".");
-        }
     } catch(e) {
         testFailed("Caught exception " + e + ".");

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-07-17  Kinuko Yasuda  <kinuko@chromium.org>
+
+        If value for responseType defined as type that not supported, it should not throw an exception in XHR 2
+        https://bugs.webkit.org/show_bug.cgi?id=90976
+
+        Reviewed by Alexey Proskuryakov.
+
+        http://www.w3.org/TR/XMLHttpRequest2/#the-responsetype-attribute
+        The spec does not say it should throw an exception when a non-supported
+        type is set, and other browsers do not throw it either.
+
+        Test: fast/xmlhttprequest/xmlhttprequest-responsetype-set-type.html
+
+        * xml/XMLHttpRequest.cpp:
+        (WebCore::XMLHttpRequest::setResponseType): Stop throwing an exception when non-supported type is given.
+
 2012-07-20  Matt Falkenhagen  <falken@chromium.org>
 

trunk/Source/WebCore/xml/XMLHttpRequest.cpp

@@ -355 +355 @@
         m_responseTypeCode = ResponseTypeArrayBuffer;
     else
-        ec = SYNTAX_ERR;
+        logConsoleError(scriptExecutionContext(), "XMLHttpRequest.responseType \"" + responseType + "\" is not supported.");
 }