Changeset 123309 in webkit

Timestamp:

Jul 23, 2012 12:53:19 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Improve AudioChannelSplitter test
​https://bugs.webkit.org/show_bug.cgi?id=91962

Patch by Li Yin <​li.yin@intel.com> on 2012-07-23
Reviewed by Kentaro Hara.

Spec: ​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section
The numberOfOutputs parameter determines the number of outputs.
Values of up to 32 must be supported. If not specified, then 6 will be used.

• webaudio/audiochannelsplitter-expected.txt:
• webaudio/audiochannelsplitter.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• webaudio/audiochannelsplitter-expected.txt (modified) (1 diff)
• webaudio/audiochannelsplitter.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-07-23  Li Yin  <li.yin@intel.com>
+
+        Improve AudioChannelSplitter test
+        https://bugs.webkit.org/show_bug.cgi?id=91962
+
+        Reviewed by Kentaro Hara.
+
+        Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section
+        The numberOfOutputs parameter determines the number of outputs.
+        Values of up to 32 must be supported. If not specified, then 6 will be used.
+
+        * webaudio/audiochannelsplitter-expected.txt:
+        * webaudio/audiochannelsplitter.html:
+
 2012-07-22  Li Yin  <li.yin@intel.com>
 

trunk/LayoutTests/webaudio/audiochannelsplitter-expected.txt

@@ -5 +5 @@
 PASS Exception been thrown for numberOfOutputs <= 0.
 PASS Exception been thrown for numberOfOutputs >= 32.
+PASS AudioChannelSplitter created successfully with numberOfOutputs = 32.
+PASS AudioChannelSplitter has 32 outputs when it is created with numberOfOutputs = 32.
+PASS AudioChannelSplitter has one input.
+PASS AudioChannelSplitter created successfully with empty parameter.
+PASS AudioChannelSplitter has 6 outputs when it is created with empty parameter.
 PASS Correctly exchanged left and right channels.
 PASS successfullyParsed is true

trunk/LayoutTests/webaudio/audiochannelsplitter.html

@@ -98 +98 @@
     }
 
+    try {
+        var splitternode = context.createChannelSplitter(32);
+        testPassed("AudioChannelSplitter created successfully with numberOfOutputs = 32.");
+        if (splitternode.numberOfOutputs === 32)
+            testPassed("AudioChannelSplitter has 32 outputs when it is created with numberOfOutputs = 32.");
+        else
+            testFailed("AudioChannelSplitter should have 32 outputs when it is created with numberOfOutputs = 32.");
+
+        if (splitternode.numberOfInputs === 1)
+            testPassed("AudioChannelSplitter has one input.");
+        else
+            testFailed("AudioChannelSplitter should have one input.");
+    } catch(e) {
+        testFailed("Failed to create AudioChannelSplitter with numberOfInputs = 32.");
+    }
+
+    try {
+        var splitternode = context.createChannelSplitter();
+        testPassed("AudioChannelSplitter created successfully with empty parameter.");
+        if (splitternode.numberOfOutputs === 6)
+            testPassed("AudioChannelSplitter has 6 outputs when it is created with empty parameter.");
+        else
+            testFailed("AudioChannelSplitter should have 6 outputs when it is created with empty parameter.");
+    } catch(e) {
+        testFailed("Failed to create AudioChannelSplitter with empty parameter.");
+    }
+
     // Create a stereo buffer, with all +1 values in left channel, all -1 in right channel.
     sourceBuffer = createStereoBufferWithDCOffset(lengthInSampleFrames, sampleRate, 1);