Changeset 123376 in webkit

Timestamp:

Jul 23, 2012 1:53:35 PM (12 years ago)

Author:

Patrick Gansterer

Message:

Move JSC::parseDate() from DateConversion to JSDateMath
​https://bugs.webkit.org/show_bug.cgi?id=91982

Reviewed by Geoffrey Garen.

Moveing this function into the other files removes the dependency
on JSC spcific classes in DateConversion.{cpp|h}.

• runtime/DateConversion.cpp:
• runtime/DateConversion.h:

(JSC):

• runtime/JSDateMath.cpp:

(JSC::parseDate):
(JSC):

• runtime/JSDateMath.h:

(JSC):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/DateConversion.cpp (modified) (1 diff)
• runtime/DateConversion.h (modified) (2 diffs)
• runtime/JSDateMath.cpp (modified) (1 diff)
• runtime/JSDateMath.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-07-23  Patrick Gansterer  <paroga@webkit.org>
+
+        Move JSC::parseDate() from DateConversion to JSDateMath
+        https://bugs.webkit.org/show_bug.cgi?id=91982
+
+        Reviewed by Geoffrey Garen.
+
+        Moveing this function into the other files removes the dependency
+        on JSC spcific classes in DateConversion.{cpp|h}.
+
+        * runtime/DateConversion.cpp:
+        * runtime/DateConversion.h:
+        (JSC):
+        * runtime/JSDateMath.cpp:
+        (JSC::parseDate):
+        (JSC):
+        * runtime/JSDateMath.h:
+        (JSC):
+
 2012-07-23  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/JavaScriptCore/runtime/DateConversion.cpp

@@ -56 +56 @@
 namespace JSC {
 
-double parseDate(ExecState* exec, const UString &date)
-{
-    if (date == exec->globalData().cachedDateString)
-        return exec->globalData().cachedDateStringValue;
-    double value = parseES5DateFromNullTerminatedCharacters(date.utf8().data());
-    if (isnan(value))
-        value = parseDateFromNullTerminatedCharacters(exec, date.utf8().data());
-    exec->globalData().cachedDateString = date;
-    exec->globalData().cachedDateStringValue = value;
-    return value;
-}
-
 void formatDate(const GregorianDateTime &t, DateConversionBuffer& buffer)
 {

trunk/Source/JavaScriptCore/runtime/DateConversion.h

@@ -43 +43 @@
 #define DateConversion_h
 
-#include "UString.h"
-
 namespace JSC {
 
@@ -53 +51 @@
 typedef char DateConversionBuffer[DateConversionBufferSize];
 
-double parseDate(ExecState* exec, const UString&);
 void formatDate(const GregorianDateTime&, DateConversionBuffer&);
 void formatDateUTCVariant(const GregorianDateTime&, DateConversionBuffer&);

trunk/Source/JavaScriptCore/runtime/JSDateMath.cpp

@@ -260 +260 @@
 }
 
+double parseDate(ExecState* exec, const UString& date)
+{
+    if (date == exec->globalData().cachedDateString)
+        return exec->globalData().cachedDateStringValue;
+    double value = parseES5DateFromNullTerminatedCharacters(date.utf8().data());
+    if (isnan(value))
+        value = parseDateFromNullTerminatedCharacters(exec, date.utf8().data());
+    exec->globalData().cachedDateString = date;
+    exec->globalData().cachedDateStringValue = value;
+    return value;
+}
+
 } // namespace JSC

trunk/Source/JavaScriptCore/runtime/JSDateMath.h

@@ -49 +49 @@
 
 class ExecState;
+class UString;
 struct GregorianDateTime;
 
@@ -55 +56 @@
 double getUTCOffset(ExecState*);
 double parseDateFromNullTerminatedCharacters(ExecState*, const char* dateString);
+double parseDate(ExecState*, const UString&);
 
 // Intentionally overridding the default tm of the system.