Changeset 123724 in webkit


Ignore:
Timestamp:
Jul 26, 2012 3:34:09 AM (12 years ago)
Author:
tommyw@google.com
Message:

MediaStream API: Remove DeprecatedPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=92106

Reviewed by Adam Barth.

Source/WebCore:

Since we are getting ready to add an updated PeerConnection
the old DeprecatedPeerConnection will have to go.

No new tests, and old tests converted to use PeerConnection00.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/DeprecatedPeerConnection.cpp: Removed.
  • Modules/mediastream/DeprecatedPeerConnection.h: Removed.
  • Modules/mediastream/DeprecatedPeerConnection.idl: Removed.
  • Modules/mediastream/SignalingCallback.h: Removed.
  • Modules/mediastream/SignalingCallback.idl: Removed.
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • UseJSC.cmake:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Removed.
  • dom/EventTargetFactory.in:
  • platform/mediastream/DeprecatedPeerConnectionHandler.h: Removed.
  • platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Removed.
  • platform/mediastream/blackberry/DeprecatedPeerConnectionHandler.cpp: Removed.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandler.cpp: Removed.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.cpp: Removed.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.h: Removed.
  • platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Removed.

LayoutTests:

Changed all usages of DeprecatedPeerConnection to PeerConnection00.

  • fast/dom/call-a-constructor-as-a-function-expected.txt:
  • fast/dom/call-a-constructor-as-a-function.html:
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html:
  • fast/mediastream/peerconnection-mediastreamlist.html:
  • fast/mediastream/peerconnection-removestream-expected.txt:
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-argument-types.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js:
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt:
Location:
trunk
Files:
13 deleted
25 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r123722 r123724  
     12012-07-26  Tommy Widenflycht  <tommyw@google.com>
     2
     3        MediaStream API: Remove DeprecatedPeerConnection
     4        https://bugs.webkit.org/show_bug.cgi?id=92106
     5
     6        Reviewed by Adam Barth.
     7
     8        Changed all usages of DeprecatedPeerConnection to PeerConnection00.
     9
     10        * fast/dom/call-a-constructor-as-a-function-expected.txt:
     11        * fast/dom/call-a-constructor-as-a-function.html:
     12        * fast/mediastream/peerconnection-addstream-expected.txt:
     13        * fast/mediastream/peerconnection-argument-types-expected.txt:
     14        * fast/mediastream/peerconnection-eventlistener-optional-argument.html:
     15        * fast/mediastream/peerconnection-mediastreamlist.html:
     16        * fast/mediastream/peerconnection-removestream-expected.txt:
     17        * fast/mediastream/script-tests/peerconnection-addstream.js:
     18        * fast/mediastream/script-tests/peerconnection-argument-types.js:
     19        * fast/mediastream/script-tests/peerconnection-removestream.js:
     20        * platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
     21        * platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
     22        * platform/gtk/fast/js/global-constructors-expected.txt:
     23        * platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt:
     24
    1252012-07-26  Mike West  <mkwst@chromium.org>
    226
  • trunk/LayoutTests/fast/dom/call-a-constructor-as-a-function-expected.txt

    r110745 r123724  
    1919PASS Int8Array() threw exception TypeError: '[object Int8ArrayConstructor]' is not a function (evaluating 'Int8Array()').
    2020PASS MessageChannel() threw exception TypeError: '[object MessageChannelConstructor]' is not a function (evaluating 'MessageChannel()').
    21 SKIP webkitDeprecatedPeerConnection is not implemented.
    2221PASS SharedWorker() threw exception TypeError: '[object SharedWorkerConstructor]' is not a function (evaluating 'SharedWorker()').
    2322PASS Uint16Array() threw exception TypeError: '[object Uint16ArrayConstructor]' is not a function (evaluating 'Uint16Array()').
  • trunk/LayoutTests/fast/dom/call-a-constructor-as-a-function.html

    r110587 r123724  
    77description("This tests if TypeError is thrown or not when we call a constructor as a normal function.");
    88
    9 var test_constructors = ["ArrayBuffer", "AudioContext", "FormData", "DataView", "EventSource", "FileReader", "Float32Array", "Float64Array", "Audio", "Image", "Option", "Int16Array", "Int32Array", "Int8Array", "MessageChannel", "webkitDeprecatedPeerConnection", "SharedWorker", "Uint16Array", "Uint32Array", "Uint8Array", "WebKitCSSMatrix", "WebKitPoint", "WebSocket", "Worker", "XMLHttpRequest", "XSLTProcessor"];
     9var test_constructors = ["ArrayBuffer", "AudioContext", "FormData", "DataView", "EventSource", "FileReader", "Float32Array", "Float64Array", "Audio", "Image", "Option", "Int16Array", "Int32Array", "Int8Array", "MessageChannel", "SharedWorker", "Uint16Array", "Uint32Array", "Uint8Array", "WebKitCSSMatrix", "WebKitPoint", "WebSocket", "Worker", "XMLHttpRequest", "XSLTProcessor"];
    1010
    1111test_constructors.forEach(function (constructor) {
  • trunk/LayoutTests/fast/mediastream/peerconnection-addstream-expected.txt

    r110587 r123724  
    1 Tests DeprecatedPeerConnection::addStream().
     1Tests PeerConnection00::addStream().
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
  • trunk/LayoutTests/fast/mediastream/peerconnection-argument-types-expected.txt

    r116511 r123724  
    1 Tests the acceptable types for arguments to method for DeprecatedPeerConnection defination.
     1Tests the acceptable types for arguments to method for PeerConnection00 defination.
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    44
    55
    6 PASS typeof webkitDeprecatedPeerConnection === 'function' is true
    7 PASS new webkitDeprecatedPeerConnection() threw exception TypeError: Not enough arguments.
    8 PASS new webkitDeprecatedPeerConnection("STUN 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
    9 PASS new webkitDeprecatedPeerConnection("STUN relay.example.net:3478") threw exception TypeError: Not enough arguments.
    10 PASS new webkitDeprecatedPeerConnection("STUN example.net") threw exception TypeError: Not enough arguments.
    11 PASS new webkitDeprecatedPeerConnection("STUNS 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
    12 PASS new webkitDeprecatedPeerConnection("STUNS relay.example.net:3478") threw exception TypeError: Not enough arguments.
    13 PASS new webkitDeprecatedPeerConnection("STUNS example.net") threw exception TypeError: Not enough arguments.
    14 PASS new webkitDeprecatedPeerConnection("TURN 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
    15 PASS new webkitDeprecatedPeerConnection("TURN relay.example.net:3478") threw exception TypeError: Not enough arguments.
    16 PASS new webkitDeprecatedPeerConnection("TURN example.net") threw exception TypeError: Not enough arguments.
    17 PASS new webkitDeprecatedPeerConnection("TURNS 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
    18 PASS new webkitDeprecatedPeerConnection("TURNS relay.example.net:3478") threw exception TypeError: Not enough arguments.
    19 PASS new webkitDeprecatedPeerConnection("TURNS example.net") threw exception TypeError: Not enough arguments.
    20 PASS new webkitDeprecatedPeerConnection("TURN NONE") threw exception TypeError: Not enough arguments.
    21 PASS new webkitDeprecatedPeerConnection("TURNS NONE") threw exception TypeError: Not enough arguments.
    22 PASS new webkitDeprecatedPeerConnection("STUN NONE") threw exception TypeError: Not enough arguments.
    23 PASS new webkitDeprecatedPeerConnection("STUNS NONE") threw exception TypeError: Not enough arguments.
    24 PASS new webkitDeprecatedPeerConnection("undefined") threw exception TypeError: Not enough arguments.
    25 PASS new webkitDeprecatedPeerConnection("null") threw exception TypeError: Not enough arguments.
    26 PASS new webkitDeprecatedPeerConnection({}) threw exception TypeError: Not enough arguments.
    27 PASS new webkitDeprecatedPeerConnection(42) threw exception TypeError: Not enough arguments.
    28 PASS new webkitDeprecatedPeerConnection(Infinity) threw exception TypeError: Not enough arguments.
    29 PASS new webkitDeprecatedPeerConnection(-Infinity) threw exception TypeError: Not enough arguments.
    30 PASS new webkitDeprecatedPeerConnection(emptyFunction) threw exception TypeError: Not enough arguments.
    31 PASS new webkitDeprecatedPeerConnection("STUN 203.0.113.2:2478",emptyFunction) did not throw exception.
    32 PASS new webkitDeprecatedPeerConnection("STUN relay.example.net:3478",emptyFunction) did not throw exception.
    33 PASS new webkitDeprecatedPeerConnection("STUN example.net",emptyFunction) did not throw exception.
    34 PASS new webkitDeprecatedPeerConnection("STUNS 203.0.113.2:2478",emptyFunction) did not throw exception.
    35 PASS new webkitDeprecatedPeerConnection("STUNS relay.example.net:3478",emptyFunction) did not throw exception.
    36 PASS new webkitDeprecatedPeerConnection("STUNS example.net",emptyFunction) did not throw exception.
    37 PASS new webkitDeprecatedPeerConnection("TURN 203.0.113.2:2478",emptyFunction) did not throw exception.
    38 PASS new webkitDeprecatedPeerConnection("TURN relay.example.net:3478",emptyFunction) did not throw exception.
    39 PASS new webkitDeprecatedPeerConnection("TURN example.net",emptyFunction) did not throw exception.
    40 PASS new webkitDeprecatedPeerConnection("TURNS 203.0.113.2:2478",emptyFunction) did not throw exception.
    41 PASS new webkitDeprecatedPeerConnection("TURNS relay.example.net:3478",emptyFunction) did not throw exception.
    42 PASS new webkitDeprecatedPeerConnection("TURNS example.net",emptyFunction) did not throw exception.
    43 PASS new webkitDeprecatedPeerConnection("TURN NONE",emptyFunction) did not throw exception.
    44 PASS new webkitDeprecatedPeerConnection("TURNS NONE",emptyFunction) did not throw exception.
    45 PASS new webkitDeprecatedPeerConnection("STUN NONE",emptyFunction) did not throw exception.
    46 PASS new webkitDeprecatedPeerConnection("STUNS NONE",emptyFunction) did not throw exception.
    47 PASS new webkitDeprecatedPeerConnection("TURN NONE",undefined) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    48 PASS new webkitDeprecatedPeerConnection("TURNS NONE",{}) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    49 PASS new webkitDeprecatedPeerConnection("STUN NONE",42) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    50 PASS new webkitDeprecatedPeerConnection("STUNS NONE",Infinity) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    51 PASS new webkitDeprecatedPeerConnection("STUNS NONE",-Infinity) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
     6PASS typeof webkitPeerConnection00 === 'function' is true
     7PASS new webkitPeerConnection00() threw exception TypeError: Not enough arguments.
     8PASS new webkitPeerConnection00("STUN 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
     9PASS new webkitPeerConnection00("STUN relay.example.net:3478") threw exception TypeError: Not enough arguments.
     10PASS new webkitPeerConnection00("STUN example.net") threw exception TypeError: Not enough arguments.
     11PASS new webkitPeerConnection00("STUNS 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
     12PASS new webkitPeerConnection00("STUNS relay.example.net:3478") threw exception TypeError: Not enough arguments.
     13PASS new webkitPeerConnection00("STUNS example.net") threw exception TypeError: Not enough arguments.
     14PASS new webkitPeerConnection00("TURN 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
     15PASS new webkitPeerConnection00("TURN relay.example.net:3478") threw exception TypeError: Not enough arguments.
     16PASS new webkitPeerConnection00("TURN example.net") threw exception TypeError: Not enough arguments.
     17PASS new webkitPeerConnection00("TURNS 203.0.113.2:2478") threw exception TypeError: Not enough arguments.
     18PASS new webkitPeerConnection00("TURNS relay.example.net:3478") threw exception TypeError: Not enough arguments.
     19PASS new webkitPeerConnection00("TURNS example.net") threw exception TypeError: Not enough arguments.
     20PASS new webkitPeerConnection00("TURN NONE") threw exception TypeError: Not enough arguments.
     21PASS new webkitPeerConnection00("TURNS NONE") threw exception TypeError: Not enough arguments.
     22PASS new webkitPeerConnection00("STUN NONE") threw exception TypeError: Not enough arguments.
     23PASS new webkitPeerConnection00("STUNS NONE") threw exception TypeError: Not enough arguments.
     24PASS new webkitPeerConnection00("undefined") threw exception TypeError: Not enough arguments.
     25PASS new webkitPeerConnection00("null") threw exception TypeError: Not enough arguments.
     26PASS new webkitPeerConnection00({}) threw exception TypeError: Not enough arguments.
     27PASS new webkitPeerConnection00(42) threw exception TypeError: Not enough arguments.
     28PASS new webkitPeerConnection00(Infinity) threw exception TypeError: Not enough arguments.
     29PASS new webkitPeerConnection00(-Infinity) threw exception TypeError: Not enough arguments.
     30PASS new webkitPeerConnection00(emptyFunction) threw exception TypeError: Not enough arguments.
     31PASS new webkitPeerConnection00("STUN 203.0.113.2:2478",emptyFunction) did not throw exception.
     32PASS new webkitPeerConnection00("STUN relay.example.net:3478",emptyFunction) did not throw exception.
     33PASS new webkitPeerConnection00("STUN example.net",emptyFunction) did not throw exception.
     34PASS new webkitPeerConnection00("STUNS 203.0.113.2:2478",emptyFunction) did not throw exception.
     35PASS new webkitPeerConnection00("STUNS relay.example.net:3478",emptyFunction) did not throw exception.
     36PASS new webkitPeerConnection00("STUNS example.net",emptyFunction) did not throw exception.
     37PASS new webkitPeerConnection00("TURN 203.0.113.2:2478",emptyFunction) did not throw exception.
     38PASS new webkitPeerConnection00("TURN relay.example.net:3478",emptyFunction) did not throw exception.
     39PASS new webkitPeerConnection00("TURN example.net",emptyFunction) did not throw exception.
     40PASS new webkitPeerConnection00("TURNS 203.0.113.2:2478",emptyFunction) did not throw exception.
     41PASS new webkitPeerConnection00("TURNS relay.example.net:3478",emptyFunction) did not throw exception.
     42PASS new webkitPeerConnection00("TURNS example.net",emptyFunction) did not throw exception.
     43PASS new webkitPeerConnection00("TURN NONE",emptyFunction) did not throw exception.
     44PASS new webkitPeerConnection00("TURNS NONE",emptyFunction) did not throw exception.
     45PASS new webkitPeerConnection00("STUN NONE",emptyFunction) did not throw exception.
     46PASS new webkitPeerConnection00("STUNS NONE",emptyFunction) did not throw exception.
     47PASS new webkitPeerConnection00("TURN NONE",undefined) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
     48PASS new webkitPeerConnection00("TURNS NONE",{}) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
     49PASS new webkitPeerConnection00("STUN NONE",42) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
     50PASS new webkitPeerConnection00("STUNS NONE",Infinity) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
     51PASS new webkitPeerConnection00("STUNS NONE",-Infinity) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    5252PASS successfullyParsed is true
    5353
  • trunk/LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument.html

    r110587 r123724  
    1111description("This test confirms if the third argument of addEventListener() and removeEventListener() is optional.");
    1212
    13 var pc = new webkitDeprecatedPeerConnection("some.server.com", function() {});
     13var pc = new webkitPeerConnection00("some.server.com", function() {});
    1414shouldBe('pc.addEventListener("foo", function() {})', 'undefined');
    1515shouldBe('pc.addEventListener("foo", function() {}, false)', 'undefined');
  • trunk/LayoutTests/fast/mediastream/peerconnection-mediastreamlist.html

    r110587 r123724  
    1212description("This test confirms that out-of-bounds access of MediaStreamList returns undefined.");
    1313
    14 var pc = new webkitDeprecatedPeerConnection("", function() {});
     14var pc = new webkitPeerConnection00("", function() {});
    1515
    1616shouldBeUndefined('pc.localStreams[0xbadc0ded]');
  • trunk/LayoutTests/fast/mediastream/peerconnection-removestream-expected.txt

    r110587 r123724  
    1 Tests DeprecatedPeerConnection::removeStream().
     1Tests PeerConnection00::removeStream().
    22
    33On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    44
    55
    6 PASS pc.removeStream() threw TypeError: Not enough arguments
    7 PASS pc.removeStream(undefined) threw Error: TYPE_MISMATCH_ERR: DOM Exception 17
    8 PASS pc.removeStream(null) threw Error: TYPE_MISMATCH_ERR: DOM Exception 17
    9 PASS pc.removeStream(new Array()) threw TypeError: Type error
    10 PASS pc.removeStream({}) threwTypeError: Type error
    11 PASS pc.removeStream(42) threwTypeError: Type error
    12 PASS pc.removeStream(Infinity) threwTypeError: Type error
    13 PASS pc.removeStream(-Infinity) threwTypeError: Type error
     6PASS pc.removeStream(); threw exception TypeError: Not enough arguments.
     7PASS pc.removeStream(undefined); threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
     8PASS pc.removeStream(null); threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
     9PASS pc.removeStream(new Array()); threw exception TypeError: Type error.
     10PASS pc.removeStream({}); threw exception TypeError: Type error.
     11PASS pc.removeStream(42); threw exception TypeError: Type error.
     12PASS pc.removeStream(Infinity); threw exception TypeError: Type error.
     13PASS pc.removeStream(-Infinity); threw exception TypeError: Type error.
    1414PASS successfullyParsed is true
    1515
  • trunk/LayoutTests/fast/mediastream/script-tests/peerconnection-addstream.js

    r110587 r123724  
    1 description("Tests DeprecatedPeerConnection::addStream().");
     1description("Tests PeerConnection00::addStream().");
    22
    3 var pc = new webkitDeprecatedPeerConnection("STUN some.server.com", function() {});
     3var pc = new webkitPeerConnection00("STUN some.server.com", function() {});
    44
    55try {
  • trunk/LayoutTests/fast/mediastream/script-tests/peerconnection-argument-types.js

    r116511 r123724  
    1 description("Tests the acceptable types for arguments to method for DeprecatedPeerConnection defination.");
     1description("Tests the acceptable types for arguments to method for PeerConnection00 defination.");
    22
    33function test(expression, expressionShouldThrow, expectedException) {
     
    2222var objectThrowingException = new ObjectThrowingException();
    2323
    24 shouldBeTrue("typeof webkitDeprecatedPeerConnection === 'function'");
     24shouldBeTrue("typeof webkitPeerConnection00 === 'function'");
    2525
    2626// 0 Argument
    27 test('new webkitDeprecatedPeerConnection()', true,'TypeError: Not enough arguments');
     27test('new webkitPeerConnection00()', true,'TypeError: Not enough arguments');
    2828
    29 // 1 Argument (new webkitDeprecatedPeerConnection requires at least 2 arguments).
    30 test('new webkitDeprecatedPeerConnection("STUN 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
    31 test('new webkitDeprecatedPeerConnection("STUN relay.example.net:3478")', true, 'TypeError: Not enough arguments');
    32 test('new webkitDeprecatedPeerConnection("STUN example.net")', true, 'TypeError: Not enough arguments');
    33 test('new webkitDeprecatedPeerConnection("STUNS 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
    34 test('new webkitDeprecatedPeerConnection("STUNS relay.example.net:3478")', true, 'TypeError: Not enough arguments');
    35 test('new webkitDeprecatedPeerConnection("STUNS example.net")', true, 'TypeError: Not enough arguments');
    36 test('new webkitDeprecatedPeerConnection("TURN 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
    37 test('new webkitDeprecatedPeerConnection("TURN relay.example.net:3478")', true, 'TypeError: Not enough arguments');
    38 test('new webkitDeprecatedPeerConnection("TURN example.net")', true, 'TypeError: Not enough arguments');
    39 test('new webkitDeprecatedPeerConnection("TURNS 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
    40 test('new webkitDeprecatedPeerConnection("TURNS relay.example.net:3478")', true, 'TypeError: Not enough arguments');
    41 test('new webkitDeprecatedPeerConnection("TURNS example.net")', true, 'TypeError: Not enough arguments');
    42 test('new webkitDeprecatedPeerConnection("TURN NONE")', true, 'TypeError: Not enough arguments');
    43 test('new webkitDeprecatedPeerConnection("TURNS NONE")', true, 'TypeError: Not enough arguments');
    44 test('new webkitDeprecatedPeerConnection("STUN NONE")', true, 'TypeError: Not enough arguments');
    45 test('new webkitDeprecatedPeerConnection("STUNS NONE")', true, 'TypeError: Not enough arguments');
    46 test('new webkitDeprecatedPeerConnection("undefined")', true, 'TypeError: Not enough arguments');
    47 test('new webkitDeprecatedPeerConnection("null")', true, 'TypeError: Not enough arguments');
    48 test('new webkitDeprecatedPeerConnection({})', true, 'TypeError: Not enough arguments');
    49 test('new webkitDeprecatedPeerConnection(42)', true, 'TypeError: Not enough arguments');
    50 test('new webkitDeprecatedPeerConnection(Infinity)', true, 'TypeError: Not enough arguments');
    51 test('new webkitDeprecatedPeerConnection(-Infinity)', true, 'TypeError: Not enough arguments');
    52 test('new webkitDeprecatedPeerConnection(emptyFunction)', true, 'TypeError: Not enough arguments');
     29// 1 Argument (new webkitPeerConnection00 requires at least 2 arguments).
     30test('new webkitPeerConnection00("STUN 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
     31test('new webkitPeerConnection00("STUN relay.example.net:3478")', true, 'TypeError: Not enough arguments');
     32test('new webkitPeerConnection00("STUN example.net")', true, 'TypeError: Not enough arguments');
     33test('new webkitPeerConnection00("STUNS 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
     34test('new webkitPeerConnection00("STUNS relay.example.net:3478")', true, 'TypeError: Not enough arguments');
     35test('new webkitPeerConnection00("STUNS example.net")', true, 'TypeError: Not enough arguments');
     36test('new webkitPeerConnection00("TURN 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
     37test('new webkitPeerConnection00("TURN relay.example.net:3478")', true, 'TypeError: Not enough arguments');
     38test('new webkitPeerConnection00("TURN example.net")', true, 'TypeError: Not enough arguments');
     39test('new webkitPeerConnection00("TURNS 203.0.113.2:2478")', true, 'TypeError: Not enough arguments');
     40test('new webkitPeerConnection00("TURNS relay.example.net:3478")', true, 'TypeError: Not enough arguments');
     41test('new webkitPeerConnection00("TURNS example.net")', true, 'TypeError: Not enough arguments');
     42test('new webkitPeerConnection00("TURN NONE")', true, 'TypeError: Not enough arguments');
     43test('new webkitPeerConnection00("TURNS NONE")', true, 'TypeError: Not enough arguments');
     44test('new webkitPeerConnection00("STUN NONE")', true, 'TypeError: Not enough arguments');
     45test('new webkitPeerConnection00("STUNS NONE")', true, 'TypeError: Not enough arguments');
     46test('new webkitPeerConnection00("undefined")', true, 'TypeError: Not enough arguments');
     47test('new webkitPeerConnection00("null")', true, 'TypeError: Not enough arguments');
     48test('new webkitPeerConnection00({})', true, 'TypeError: Not enough arguments');
     49test('new webkitPeerConnection00(42)', true, 'TypeError: Not enough arguments');
     50test('new webkitPeerConnection00(Infinity)', true, 'TypeError: Not enough arguments');
     51test('new webkitPeerConnection00(-Infinity)', true, 'TypeError: Not enough arguments');
     52test('new webkitPeerConnection00(emptyFunction)', true, 'TypeError: Not enough arguments');
    5353
    5454//2 Argument
    55 test('new webkitDeprecatedPeerConnection("STUN 203.0.113.2:2478",emptyFunction)', false);
    56 test('new webkitDeprecatedPeerConnection("STUN relay.example.net:3478",emptyFunction)', false);
    57 test('new webkitDeprecatedPeerConnection("STUN example.net",emptyFunction)',false);
    58 test('new webkitDeprecatedPeerConnection("STUNS 203.0.113.2:2478",emptyFunction)', false);
    59 test('new webkitDeprecatedPeerConnection("STUNS relay.example.net:3478",emptyFunction)', false);
    60 test('new webkitDeprecatedPeerConnection("STUNS example.net",emptyFunction)', false);
    61 test('new webkitDeprecatedPeerConnection("TURN 203.0.113.2:2478",emptyFunction)', false);
    62 test('new webkitDeprecatedPeerConnection("TURN relay.example.net:3478",emptyFunction)', false);
    63 test('new webkitDeprecatedPeerConnection("TURN example.net",emptyFunction)', false);
    64 test('new webkitDeprecatedPeerConnection("TURNS 203.0.113.2:2478",emptyFunction)', false);
    65 test('new webkitDeprecatedPeerConnection("TURNS relay.example.net:3478",emptyFunction)', false);
    66 test('new webkitDeprecatedPeerConnection("TURNS example.net",emptyFunction)', false);
    67 test('new webkitDeprecatedPeerConnection("TURN NONE",emptyFunction)', false);
    68 test('new webkitDeprecatedPeerConnection("TURNS NONE",emptyFunction)',false);
    69 test('new webkitDeprecatedPeerConnection("STUN NONE",emptyFunction)', false);
    70 test('new webkitDeprecatedPeerConnection("STUNS NONE",emptyFunction)', false);
    71 test('new webkitDeprecatedPeerConnection("TURN NONE",undefined)',  true);
    72 test('new webkitDeprecatedPeerConnection("TURNS NONE",{})', true);
    73 test('new webkitDeprecatedPeerConnection("STUN NONE",42)',  true);
    74 test('new webkitDeprecatedPeerConnection("STUNS NONE",Infinity)', true);
    75 test('new webkitDeprecatedPeerConnection("STUNS NONE",-Infinity)', true);
    76 
    77 
     55test('new webkitPeerConnection00("STUN 203.0.113.2:2478",emptyFunction)', false);
     56test('new webkitPeerConnection00("STUN relay.example.net:3478",emptyFunction)', false);
     57test('new webkitPeerConnection00("STUN example.net",emptyFunction)',false);
     58test('new webkitPeerConnection00("STUNS 203.0.113.2:2478",emptyFunction)', false);
     59test('new webkitPeerConnection00("STUNS relay.example.net:3478",emptyFunction)', false);
     60test('new webkitPeerConnection00("STUNS example.net",emptyFunction)', false);
     61test('new webkitPeerConnection00("TURN 203.0.113.2:2478",emptyFunction)', false);
     62test('new webkitPeerConnection00("TURN relay.example.net:3478",emptyFunction)', false);
     63test('new webkitPeerConnection00("TURN example.net",emptyFunction)', false);
     64test('new webkitPeerConnection00("TURNS 203.0.113.2:2478",emptyFunction)', false);
     65test('new webkitPeerConnection00("TURNS relay.example.net:3478",emptyFunction)', false);
     66test('new webkitPeerConnection00("TURNS example.net",emptyFunction)', false);
     67test('new webkitPeerConnection00("TURN NONE",emptyFunction)', false);
     68test('new webkitPeerConnection00("TURNS NONE",emptyFunction)',false);
     69test('new webkitPeerConnection00("STUN NONE",emptyFunction)', false);
     70test('new webkitPeerConnection00("STUNS NONE",emptyFunction)', false);
     71test('new webkitPeerConnection00("TURN NONE",undefined)',  true);
     72test('new webkitPeerConnection00("TURNS NONE",{})', true);
     73test('new webkitPeerConnection00("STUN NONE",42)',  true);
     74test('new webkitPeerConnection00("STUNS NONE",Infinity)', true);
     75test('new webkitPeerConnection00("STUNS NONE",-Infinity)', true);
    7876
    7977window.jsTestIsAsync = false;
  • trunk/LayoutTests/fast/mediastream/script-tests/peerconnection-removestream.js

    r110587 r123724  
    1 description("Tests DeprecatedPeerConnection::removeStream().");
     1description("Tests PeerConnection00::removeStream().");
    22
    3 var pc = new webkitDeprecatedPeerConnection("STUN some.server.com", function() {});
     3var pc = new webkitPeerConnection00("STUN some.server.com", function() {});
    44
    5 try {
    6     pc.removeStream();
    7 } catch(e) {
    8     testPassed('pc.removeStream() threw ' + e);
    9 }
    10 
    11 try {
    12     pc.removeStream(undefined);
    13 } catch(e) {
    14     testPassed('pc.removeStream(undefined) threw ' + e);
    15 }
    16 
    17 try {
    18     pc.removeStream(null);
    19 } catch(e) {
    20     testPassed('pc.removeStream(null) threw ' + e);
    21 }
    22 
    23 try {
    24     pc.removeStream(new Array());
    25 } catch(e) {
    26     testPassed('pc.removeStream(new Array()) threw ' + e);
    27 }
    28 try {
    29     pc.removeStream({});
    30 } catch(e) {
    31     testPassed('pc.removeStream({}) threw' + e);
    32 }
    33 try {
    34     pc.removeStream(42);
    35 } catch(e) {
    36     testPassed('pc.removeStream(42) threw' + e);
    37 }
    38 try {
    39     pc.removeStream(Infinity);
    40 } catch(e) {
    41     testPassed('pc.removeStream(Infinity) threw' + e);
    42 }
    43 try {
    44     pc.removeStream(-Infinity);
    45 } catch(e) {
    46     testPassed('pc.removeStream(-Infinity) threw' + e);
    47 }
     5shouldThrow('pc.removeStream();');
     6shouldThrow('pc.removeStream(undefined);');
     7shouldThrow('pc.removeStream(null);');
     8shouldThrow('pc.removeStream(new Array());');
     9shouldThrow('pc.removeStream({});');
     10shouldThrow('pc.removeStream(42);');
     11shouldThrow('pc.removeStream(Infinity);');
     12shouldThrow('pc.removeStream(-Infinity);');
    4813
    4914window.successfullyParsed = true;
  • trunk/LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt

    r110587 r123724  
    1919PASS Int8Array() threw exception TypeError: DOM object constructor cannot be called as a function..
    2020PASS MessageChannel() threw exception TypeError: DOM object constructor cannot be called as a function..
    21 PASS webkitDeprecatedPeerConnection() threw exception TypeError: DOM object constructor cannot be called as a function..
    2221SKIP SharedWorker is not implemented.
    2322PASS Uint16Array() threw exception TypeError: DOM object constructor cannot be called as a function..
  • trunk/LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt

    r110603 r123724  
    1919PASS Int8Array() threw exception TypeError: '[object Int8ArrayConstructor]' is not a function (evaluating 'Int8Array()').
    2020PASS MessageChannel() threw exception TypeError: '[object MessageChannelConstructor]' is not a function (evaluating 'MessageChannel()').
    21 PASS webkitDeprecatedPeerConnection() threw exception TypeError: '[object DeprecatedPeerConnectionConstructor]' is not a function (evaluating 'webkitDeprecatedPeerConnection()').
    2221PASS SharedWorker() threw exception TypeError: '[object SharedWorkerConstructor]' is not a function (evaluating 'SharedWorker()').
    2322PASS Uint16Array() threw exception TypeError: '[object Uint16ArrayConstructor]' is not a function (evaluating 'Uint16Array()').
  • trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt

    r118915 r123724  
    343343PASS XPathResult.toString() is '[object XPathResultConstructor]'
    344344PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]'
    345 FAIL webkitDeprecatedPeerConnection.toString() should be [object webkitDeprecatedPeerConnectionConstructor]. Was [object DeprecatedPeerConnectionConstructor].
    346345FAIL webkitMediaStream.toString() should be [object webkitMediaStreamConstructor]. Was [object MediaStreamConstructor].
    347346FAIL webkitPeerConnection00.toString() should be [object webkitPeerConnection00Constructor]. Was [object PeerConnection00Constructor].
  • trunk/LayoutTests/platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt

    r118554 r123724  
    1919PASS Int8Array() threw exception TypeError: '[object Int8ArrayConstructor]' is not a function (evaluating 'Int8Array()').
    2020PASS MessageChannel() threw exception TypeError: '[object MessageChannelConstructor]' is not a function (evaluating 'MessageChannel()').
    21 SKIP webkitDeprecatedPeerConnection is not implemented.
    2221PASS SharedWorker() threw exception TypeError: '[object SharedWorkerConstructor]' is not a function (evaluating 'SharedWorker()').
    2322PASS Uint16Array() threw exception TypeError: '[object Uint16ArrayConstructor]' is not a function (evaluating 'Uint16Array()').
  • trunk/Source/WebCore/CMakeLists.txt

    r123722 r123724  
    190190    Modules/intents/NavigatorIntents.idl
    191191
    192     Modules/mediastream/DeprecatedPeerConnection.idl
    193192    Modules/mediastream/DOMWindowMediaStream.idl
    194193    Modules/mediastream/IceCallback.idl
     
    207206    Modules/mediastream/PeerConnection00.idl
    208207    Modules/mediastream/SessionDescription.idl
    209     Modules/mediastream/SignalingCallback.idl
    210208
    211209    Modules/networkinfo/NavigatorNetworkInfoConnection.idl
     
    815813    Modules/intents/NavigatorIntents.cpp
    816814
    817     Modules/mediastream/DeprecatedPeerConnection.cpp
    818815    Modules/mediastream/IceCandidate.cpp
    819816    Modules/mediastream/LocalMediaStream.cpp
  • trunk/Source/WebCore/ChangeLog

    r123722 r123724  
     12012-07-26  Tommy Widenflycht  <tommyw@google.com>
     2
     3        MediaStream API: Remove DeprecatedPeerConnection
     4        https://bugs.webkit.org/show_bug.cgi?id=92106
     5
     6        Reviewed by Adam Barth.
     7
     8        Since we are getting ready to add an updated PeerConnection
     9        the old DeprecatedPeerConnection will have to go.
     10
     11        No new tests, and old tests converted to use PeerConnection00.
     12
     13        * CMakeLists.txt:
     14        * GNUmakefile.list.am:
     15        * Modules/mediastream/DOMWindowMediaStream.idl:
     16        * Modules/mediastream/DeprecatedPeerConnection.cpp: Removed.
     17        * Modules/mediastream/DeprecatedPeerConnection.h: Removed.
     18        * Modules/mediastream/DeprecatedPeerConnection.idl: Removed.
     19        * Modules/mediastream/SignalingCallback.h: Removed.
     20        * Modules/mediastream/SignalingCallback.idl: Removed.
     21        * PlatformBlackBerry.cmake:
     22        * PlatformEfl.cmake:
     23        * UseJSC.cmake:
     24        * WebCore.gypi:
     25        * bindings/generic/RuntimeEnabledFeatures.h:
     26        * bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Removed.
     27        * dom/EventTargetFactory.in:
     28        * platform/mediastream/DeprecatedPeerConnectionHandler.h: Removed.
     29        * platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Removed.
     30        * platform/mediastream/blackberry/DeprecatedPeerConnectionHandler.cpp: Removed.
     31        * platform/mediastream/chromium/DeprecatedPeerConnectionHandler.cpp: Removed.
     32        * platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.cpp: Removed.
     33        * platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.h: Removed.
     34        * platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Removed.
     35
    1362012-07-26  Mike West  <mkwst@chromium.org>
    237
  • trunk/Source/WebCore/GNUmakefile.list.am

    r123722 r123724  
    111111        DerivedSources/WebCore/JSDedicatedWorkerContext.cpp \
    112112        DerivedSources/WebCore/JSDedicatedWorkerContext.h \
    113         DerivedSources/WebCore/JSDeprecatedPeerConnection.cpp \
    114         DerivedSources/WebCore/JSDeprecatedPeerConnection.h \
    115113        DerivedSources/WebCore/JSDeviceMotionEvent.cpp \
    116114        DerivedSources/WebCore/JSDeviceMotionEvent.h \
     
    508506        DerivedSources/WebCore/JSSharedWorker.cpp \
    509507        DerivedSources/WebCore/JSSharedWorker.h \
    510         DerivedSources/WebCore/JSSignalingCallback.cpp \
    511         DerivedSources/WebCore/JSSignalingCallback.h \
    512508        DerivedSources/WebCore/JSSourceBuffer.cpp \
    513509        DerivedSources/WebCore/JSSourceBuffer.h \
     
    705701        $(WebCore)/Modules/mediasource/SourceBuffer.idl \
    706702        $(WebCore)/Modules/mediasource/SourceBufferList.idl \
    707         $(WebCore)/Modules/mediastream/DeprecatedPeerConnection.idl \
    708703        $(WebCore)/Modules/mediastream/DOMWindowMediaStream.idl \
    709704        $(WebCore)/Modules/mediastream/IceCallback.idl \
     
    722717        $(WebCore)/Modules/mediastream/PeerConnection00.idl \
    723718        $(WebCore)/Modules/mediastream/SessionDescription.idl \
    724         $(WebCore)/Modules/mediastream/SignalingCallback.idl \
    725719        $(WebCore)/Modules/notifications/Notification.idl \
    726720        $(WebCore)/Modules/notifications/NotificationCenter.idl \
     
    11791173        Source/WebCore/Modules/mediasource/SourceBufferList.cpp \
    11801174        Source/WebCore/Modules/mediasource/SourceBufferList.h \
    1181         Source/WebCore/Modules/mediastream/DeprecatedPeerConnection.cpp \
    1182         Source/WebCore/Modules/mediastream/DeprecatedPeerConnection.h \
    11831175        Source/WebCore/Modules/mediastream/IceCallback.h \
    11841176        Source/WebCore/Modules/mediastream/IceCandidate.cpp \
     
    12091201        Source/WebCore/Modules/mediastream/SessionDescription.cpp \
    12101202        Source/WebCore/Modules/mediastream/SessionDescription.h \
    1211         Source/WebCore/Modules/mediastream/SignalingCallback.h \
    12121203        Source/WebCore/Modules/mediastream/UserMediaClient.h \
    12131204        Source/WebCore/Modules/mediastream/UserMediaController.h \
     
    14371428        Source/WebCore/bindings/js/JSDataViewCustom.cpp \
    14381429        Source/WebCore/bindings/js/JSDedicatedWorkerContextCustom.cpp \
    1439         Source/WebCore/bindings/js/JSDeprecatedPeerConnectionCustom.cpp \
    14401430        Source/WebCore/bindings/js/JSDeviceMotionEventCustom.cpp \
    14411431        Source/WebCore/bindings/js/JSDeviceOrientationEventCustom.cpp \
     
    35403530        Source/WebCore/platform/linux/GamepadDeviceLinux.cpp \
    35413531        Source/WebCore/platform/linux/GamepadDeviceLinux.h \
    3542         Source/WebCore/platform/mediastream/DeprecatedPeerConnectionHandler.h \
    3543         Source/WebCore/platform/mediastream/DeprecatedPeerConnectionHandlerClient.h \
    35443532        Source/WebCore/platform/mediastream/IceCandidateDescriptor.cpp \
    35453533        Source/WebCore/platform/mediastream/IceCandidateDescriptor.h \
     
    35603548        Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.cpp \
    35613549        Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.h \
    3562         Source/WebCore/platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp \
    35633550        Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp \
    35643551        Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h \
  • trunk/Source/WebCore/Modules/mediastream/DOMWindowMediaStream.idl

    r111876 r123724  
    3131        Supplemental=DOMWindow
    3232    ] DOMWindowMediaStream {
    33         attribute [V8EnabledAtRuntime] DeprecatedPeerConnectionConstructor webkitDeprecatedPeerConnection;
    3433        attribute [V8EnabledAtRuntime] MediaStreamConstructor webkitMediaStream;
    3534        attribute [V8EnabledAtRuntime] PeerConnection00Constructor webkitPeerConnection00;
  • trunk/Source/WebCore/PlatformBlackBerry.cmake

    r123068 r123724  
    237237if (ENABLE_MEDIA_STREAM)
    238238    LIST(APPEND WebCore_SOURCES
    239         platform/mediastream/blackberry/DeprecatedPeerConnectionHandler.cpp
    240239        platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp
    241240    )
  • trunk/Source/WebCore/PlatformEfl.cmake

    r123218 r123724  
    8080  platform/image-decoders/webp/WEBPImageDecoder.cpp
    8181  platform/linux/GamepadDeviceLinux.cpp
    82   platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp
    8382  platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp
    8483  platform/network/soup/CookieJarSoup.cpp
  • trunk/Source/WebCore/UseJSC.cmake

    r123434 r123724  
    5050    bindings/js/JSCustomVoidCallback.cpp
    5151    bindings/js/JSCustomXPathNSResolver.cpp
    52     bindings/js/JSDeprecatedPeerConnectionCustom.cpp
    5352    bindings/js/JSDictionary.cpp
    5453    bindings/js/JSDOMBinding.cpp
  • trunk/Source/WebCore/WebCore.gypi

    r123722 r123724  
    437437            'platform/mac/WebCoreView.h',
    438438            'platform/mac/WebFontCache.h',
    439             'platform/mediastream/DeprecatedPeerConnectionHandler.h',
    440             'platform/mediastream/DeprecatedPeerConnectionHandlerClient.h',
    441439            'platform/mediastream/IceCandidateDescriptor.cpp',
    442440            'platform/mediastream/IceCandidateDescriptor.h',
     
    455453            'platform/mediastream/SessionDescriptionDescriptor.cpp',
    456454            'platform/mediastream/SessionDescriptionDescriptor.h',
    457             'platform/mediastream/chromium/DeprecatedPeerConnectionHandler.cpp',
    458             'platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.cpp',
    459             'platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.h',
    460455            'platform/mediastream/chromium/MediaStreamCenterChromium.cpp',
    461456            'platform/mediastream/chromium/MediaStreamCenterChromium.h',
     
    831826            'Modules/mediasource/SourceBuffer.idl',
    832827            'Modules/mediasource/SourceBufferList.idl',
    833             'Modules/mediastream/DeprecatedPeerConnection.idl',
    834828            'Modules/mediastream/DOMWindowMediaStream.idl',
    835829            'Modules/mediastream/IceCallback.idl',
     
    848842            'Modules/mediastream/PeerConnection00.idl',
    849843            'Modules/mediastream/SessionDescription.idl',
    850             'Modules/mediastream/SignalingCallback.idl',
    851844            'Modules/notifications/DOMWindowNotifications.idl',
    852845            'Modules/notifications/Notification.idl',
     
    15481541            'Modules/mediasource/SourceBufferList.cpp',
    15491542            'Modules/mediasource/SourceBufferList.h',
    1550             'Modules/mediastream/DeprecatedPeerConnection.cpp',
    1551             'Modules/mediastream/DeprecatedPeerConnection.h',
    15521543            'Modules/mediastream/IceCallback.h',
    15531544            'Modules/mediastream/IceCandidate.cpp',
     
    15781569            'Modules/mediastream/SessionDescription.cpp',
    15791570            'Modules/mediastream/SessionDescription.h',
    1580             'Modules/mediastream/SignalingCallback.h',
    15811571            'Modules/mediastream/UserMediaClient.h',
    15821572            'Modules/mediastream/UserMediaController.cpp',
     
    19781968            'bindings/js/JSDataViewCustom.cpp',
    19791969            'bindings/js/JSDedicatedWorkerContextCustom.cpp',
    1980             'bindings/js/JSDeprecatedPeerConnectionCustom.cpp',
    19811970            'bindings/js/JSDesktopNotificationsCustom.cpp',
    19821971            'bindings/js/JSDeviceMotionEventCustom.cpp',
  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r123424 r123724  
    188188    static bool peerConnectionEnabled() { return isMediaStreamEnabled && isPeerConnectionEnabled; }
    189189    static void setPeerConnectionEnabled(bool isEnabled) { isPeerConnectionEnabled = isEnabled; }
    190     static bool webkitDeprecatedPeerConnectionEnabled() { return peerConnectionEnabled(); }
    191190    static bool webkitPeerConnection00Enabled() { return peerConnectionEnabled(); }
    192191#endif
  • trunk/Source/WebCore/dom/EventTargetFactory.in

    r123627 r123724  
    66DOMApplicationCache
    77DOMWindow
    8 DeprecatedPeerConnection conditional=MEDIA_STREAM
    98EventSource
    109FileReader conditional=BLOB
Note: See TracChangeset for help on using the changeset viewer.