Changeset 123772 in webkit


Ignore:
Timestamp:
Jul 26, 2012 11:02:42 AM (12 years ago)
Author:
enne@google.com
Message:

Source/WebCore: [chromium] Remove redundant surface origin transforms
​https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit2: [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
​https://bugs.webkit.org/show_bug.cgi?id=92387

Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:

(EWK2UnitTestServer::EWK2UnitTestServer):

LayoutTests: [Qt] css3/filters, editing/undo, fast/block/lineboxcontain, fast/js and tables/layering tests need update after rebaseline and new testfonts
​https://bugs.webkit.org/show_bug.cgi?id=92292

Reviewed by Alexis Menard.

  • platform/qt-5.0/Skipped:
  • platform/qt/css3/filters/effect-blur-expected.txt:
  • platform/qt/css3/filters/effect-blur-hw-expected.txt:
  • platform/qt/css3/filters/regions-expanding-expected.txt:
  • platform/qt/editing/undo/5378473-expected.txt:
  • platform/qt/editing/undo/undo-misspellings-expected.txt:
  • platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-box-expected.txt:
  • platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
  • platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
  • platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt:
  • platform/qt/fast/block/lineboxcontain/none-expected.png:
  • platform/qt/fast/block/lineboxcontain/none-expected.txt:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/qt/fast/block/lineboxcontain/replaced-expected.png:
  • platform/qt/fast/block/lineboxcontain/replaced-expected.txt:
Location:
trunk
Files:
21 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r123767 r123772  
     12012-07-26  Luciano Wolf  <luciano.wolf@openbossa.org>
     2
     3        [Qt] css3/filters, editing/undo, fast/block/lineboxcontain, fast/js and tables/layering tests need update after rebaseline and new testfonts
     4        https://bugs.webkit.org/show_bug.cgi?id=92292
     5
     6        Reviewed by Alexis Menard.
     7
     8        * platform/qt-5.0/Skipped:
     9        * platform/qt/css3/filters/effect-blur-expected.txt:
     10        * platform/qt/css3/filters/effect-blur-hw-expected.txt:
     11        * platform/qt/css3/filters/regions-expanding-expected.txt:
     12        * platform/qt/editing/undo/5378473-expected.txt:
     13        * platform/qt/editing/undo/undo-misspellings-expected.txt:
     14        * platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
     15        * platform/qt/fast/block/lineboxcontain/inline-box-expected.txt:
     16        * platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
     17        * platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
     18        * platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
     19        * platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt:
     20        * platform/qt/fast/block/lineboxcontain/none-expected.png:
     21        * platform/qt/fast/block/lineboxcontain/none-expected.txt:
     22        * platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
     23        * platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
     24        * platform/qt/fast/block/lineboxcontain/replaced-expected.png:
     25        * platform/qt/fast/block/lineboxcontain/replaced-expected.txt:
     26
    1272012-07-26  Chris Fleizach  <cfleizach@apple.com>
    228

  • trunk/LayoutTests/platform/qt-5.0/Skipped

    r123750 r123772  
    135135# due to this we are skipping tons of tests. They will be unskipped in batches ASAP.
    136136# https://bugs.webkit.org/show_bug.cgi?id=85203
    137 css3/filters/effect-blur-hw.html
    138 css3/filters/effect-blur.html
    139 css3/filters/regions-expanding.html
    140137editing/pasteboard/3976872.html
    141138editing/pasteboard/4076267-2.html
    … …  
    213210editing/pasteboard/undoable-fragment-removes.html
    214211editing/pasteboard/unrendered-br.html
    215 editing/undo/5378473.html
    216 editing/undo/undo-misspellings.html
    217 editing/undo/undo-typing-001.html
    218 fast/block/lineboxcontain/inline-box-vertical.html
    219 fast/block/lineboxcontain/inline-box.html
    220 fast/block/lineboxcontain/inline-replaced.html
    221 fast/block/lineboxcontain/none.html
    222 fast/block/lineboxcontain/parsing-invalid.html
    223 fast/block/lineboxcontain/replaced.html
    224 fast/js/constructor-length.html
    225 fast/js/custom-constructors.html
    226 fast/js/instanceof-XMLHttpRequest.html
    227212svg/custom/SVGMatrix-interface.svg
    228213svg/custom/SVGPoint-matrixTransform.svg
    … …  
    422407svg/custom/viewbox-syntax.svg
    423408svg/custom/viewport-em.svg
    424 tables/layering/paint-test-layering-1.html
    425 tables/layering/paint-test-layering-2.html
    426409
    427410# [Qt] Tests still fail after the update to new fonts

  • trunk/LayoutTests/platform/qt/css3/filters/effect-blur-expected.txt

    r104560 r123772  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderText {#text} at (180,94) size 4x21
    7         text run at (180,94) width 4: " "
    8       RenderText {#text} at (364,94) size 4x21
    9         text run at (364,94) width 4: " "
    10       RenderText {#text} at (548,94) size 4x21
    11         text run at (548,94) width 4: " "
     6      RenderText {#text} at (180,95) size 4x19
     7        text run at (180,95) width 4: " "
     8      RenderText {#text} at (364,95) size 4x19
     9        text run at (364,95) width 4: " "
     10      RenderText {#text} at (548,95) size 4x19
     11        text run at (548,95) width 4: " "
    1212      RenderText {#text} at (0,0) size 0x0
    1313layer at (18,18) size 160x90

  • trunk/LayoutTests/platform/qt/css3/filters/effect-blur-hw-expected.txt

    r107898 r123772  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderText {#text} at (180,94) size 4x21
    7         text run at (180,94) width 4: " "
    8       RenderText {#text} at (364,94) size 4x21
    9         text run at (364,94) width 4: " "
    10       RenderText {#text} at (548,94) size 4x21
    11         text run at (548,94) width 4: " "
     6      RenderText {#text} at (180,95) size 4x19
     7        text run at (180,95) width 4: " "
     8      RenderText {#text} at (364,95) size 4x19
     9        text run at (364,95) width 4: " "
     10      RenderText {#text} at (548,95) size 4x19
     11        text run at (548,95) width 4: " "
    1212      RenderText {#text} at (0,0) size 0x0
    1313layer at (18,18) size 160x90

  • trunk/LayoutTests/platform/qt/css3/filters/regions-expanding-expected.txt

    r104560 r123772  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderText {#text} at (160,74) size 4x21
    7         text run at (160,74) width 4: " "
     6      RenderText {#text} at (160,75) size 4x19
     7        text run at (160,75) width 4: " "
    88      RenderText {#text} at (0,0) size 0x0
    9       RenderText {#text} at (324,74) size 4x21
    10         text run at (324,74) width 4: " "
     9      RenderText {#text} at (324,75) size 4x19
     10        text run at (324,75) width 4: " "
    1111      RenderText {#text} at (0,0) size 0x0
    1212      RenderText {#text} at (0,0) size 0x0

  • trunk/LayoutTests/platform/qt/editing/undo/5378473-expected.txt

    r98015 r123772  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderBlock {DIV} at (0,0) size 784x21
     6      RenderBlock {DIV} at (0,0) size 784x19
    77caret: position 0 of child 0 {DIV} of body

  • trunk/LayoutTests/platform/qt/editing/undo/undo-misspellings-expected.txt

    r98015 r123772  
    3939  RenderBlock {HTML} at (0,0) size 800x600
    4040    RenderBody {BODY} at (8,8) size 784x584
    41       RenderBlock {DIV} at (0,0) size 784x21
     41      RenderBlock {DIV} at (0,0) size 784x19
    4242caret: position 0 of child 0 {DIV} of body

  • trunk/LayoutTests/platform/qt/fast/block/lineboxcontain/inline-box-expected.txt

    r98015 r123772  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x229
    4   RenderBlock {HTML} at (0,0) size 800x229
    5     RenderBody {BODY} at (8,8) size 784x213
    6       RenderBlock (anonymous) at (0,0) size 784x21
    7         RenderText {#text} at (0,0) size 555x21
    8           text run at (0,0) width 294: "You should see a green rectangle below. "
    9           text run at (294,0) width 261: "If you see any red, the test has failed."
    10       RenderBlock {DIV} at (0,21) size 384x192 [bgcolor=#FF0000]
     3layer at (0,0) size 800x227
     4  RenderBlock {HTML} at (0,0) size 800x227
     5    RenderBody {BODY} at (8,8) size 784x211
     6      RenderBlock (anonymous) at (0,0) size 784x19
     7        RenderText {#text} at (0,0) size 471x19
     8          text run at (0,0) width 248: "You should see a green rectangle below. "
     9          text run at (248,0) width 223: "If you see any red, the test has failed."
     10      RenderBlock {DIV} at (0,19) size 384x192 [bgcolor=#FF0000]
    1111        RenderInline {SPAN} at (0,0) size 384x97 [bgcolor=#008000]
    1212        RenderBR {BR} at (384,32) size 0x65

  • trunk/LayoutTests/platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt

    r98015 r123772  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 229x600
    4   RenderBlock {HTML} at (0,0) size 229x600
    5     RenderBody {BODY} at (8,8) size 213x584
    6       RenderBlock (anonymous) at (0,0) size 21x584
    7         RenderText {#text} at (0,0) size 21x555
    8           text run at (0,0) width 294: "You should see a green rectangle below. "
    9           text run at (0,294) width 261: "If you see any red, the test has failed."
    10       RenderBlock {DIV} at (21,0) size 192x384 [bgcolor=#FF0000]
     3layer at (0,0) size 227x600
     4  RenderBlock {HTML} at (0,0) size 227x600
     5    RenderBody {BODY} at (8,8) size 211x584
     6      RenderBlock (anonymous) at (0,0) size 19x584
     7        RenderText {#text} at (0,0) size 19x471
     8          text run at (0,0) width 248: "You should see a green rectangle below. "
     9          text run at (0,248) width 223: "If you see any red, the test has failed."
     10      RenderBlock {DIV} at (19,0) size 192x384 [bgcolor=#FF0000]
    1111        RenderInline {SPAN} at (0,0) size 97x384 [bgcolor=#008000]
    1212        RenderBR {BR} at (0,384) size 65x0

  • trunk/LayoutTests/platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt

    r98015 r123772  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x294
    4   RenderBlock {HTML} at (0,0) size 800x294
    5     RenderBody {BODY} at (8,8) size 784x278
    6       RenderBlock (anonymous) at (0,0) size 784x21
    7         RenderText {#text} at (0,0) size 555x21
    8           text run at (0,0) width 294: "You should see a green rectangle below. "
    9           text run at (294,0) width 261: "If you see any red, the test has failed."
    10       RenderBlock {DIV} at (0,21) size 384x257 [bgcolor=#FF0000]
     3layer at (0,0) size 800x292
     4  RenderBlock {HTML} at (0,0) size 800x292
     5    RenderBody {BODY} at (8,8) size 784x276
     6      RenderBlock (anonymous) at (0,0) size 784x19
     7        RenderText {#text} at (0,0) size 471x19
     8          text run at (0,0) width 248: "You should see a green rectangle below. "
     9          text run at (248,0) width 223: "If you see any red, the test has failed."
     10      RenderBlock {DIV} at (0,19) size 384x257 [bgcolor=#FF0000]
    1111        RenderInline {SPAN} at (0,0) size 384x129 [bgcolor=#008000]
    1212        RenderBR {BR} at (384,51) size 0x65

  • trunk/LayoutTests/platform/qt/fast/block/lineboxcontain/none-expected.txt

    r112079 r123772  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x101
    4   RenderBlock {HTML} at (0,0) size 800x101
    5     RenderBody {BODY} at (8,8) size 784x85
    6       RenderBlock (anonymous) at (0,0) size 784x21
    7         RenderText {#text} at (0,0) size 515x21
    8           text run at (0,0) width 254: "You should see a green line below. "
    9           text run at (254,0) width 261: "If you see any red, the test has failed."
    10       RenderBlock {DIV} at (0,85) size 784x0 [bgcolor=#FF0000]
     3layer at (0,0) size 800x99
     4  RenderBlock {HTML} at (0,0) size 800x99
     5    RenderBody {BODY} at (8,8) size 784x83
     6      RenderBlock (anonymous) at (0,0) size 784x19
     7        RenderText {#text} at (0,0) size 437x19
     8          text run at (0,0) width 214: "You should see a green line below. "
     9          text run at (214,0) width 223: "If you see any red, the test has failed."
     10      RenderBlock {DIV} at (0,83) size 784x0 [bgcolor=#FF0000]
    1111        RenderInline {SPAN} at (0,0) size 320x65 [color=#FF0000]
    1212          RenderText {#text} at (0,-52) size 320x65

  • trunk/LayoutTests/platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt

    r115875 r123772  
    1 layer at (0,0) size 784x1501
     1layer at (0,0) size 784x1499
    22  RenderView at (0,0) size 784x600
    3 layer at (0,0) size 784x1501
    4   RenderBlock {HTML} at (0,0) size 784x1501
    5     RenderBody {BODY} at (8,8) size 768x1461
    6       RenderBlock (anonymous) at (0,0) size 768x21
    7         RenderText {#text} at (0,0) size 288x21
    8           text run at (0,0) width 288: "All of these blocks should look the same."
    9 layer at (8,61) size 320x256
    10   RenderBlock {DIV} at (0,53) size 320x256 [bgcolor=#00FF00]
     3layer at (0,0) size 784x1499
     4  RenderBlock {HTML} at (0,0) size 784x1499
     5    RenderBody {BODY} at (8,8) size 768x1459
     6      RenderBlock (anonymous) at (0,0) size 768x19
     7        RenderText {#text} at (0,0) size 247x19
     8          text run at (0,0) width 247: "All of these blocks should look the same."
     9layer at (8,59) size 320x256
     10  RenderBlock {DIV} at (0,51) size 320x256 [bgcolor=#00FF00]
    1111    RenderInline {SPAN} at (0,0) size 320x65 [color=#008000]
    1212      RenderText {#text} at (0,31) size 320x65
    … …  
    2020        text run at (256,159) width 64: "x"
    2121    RenderText {#text} at (0,0) size 0x0
    22 layer at (8,349) size 320x256
    23   RenderBlock {DIV} at (0,341) size 320x256 [bgcolor=#00FF00]
     22layer at (8,347) size 320x256
     23  RenderBlock {DIV} at (0,339) size 320x256 [bgcolor=#00FF00]
    2424    RenderInline {SPAN} at (0,0) size 320x65 [color=#008000]
    2525      RenderText {#text} at (0,31) size 320x65
    … …  
    3333        text run at (256,159) width 64: "x"
    3434    RenderText {#text} at (0,0) size 0x0
    35 layer at (8,637) size 320x256
    36   RenderBlock {DIV} at (0,629) size 320x256 [bgcolor=#00FF00]
     35layer at (8,635) size 320x256
     36  RenderBlock {DIV} at (0,627) size 320x256 [bgcolor=#00FF00]
    3737    RenderInline {SPAN} at (0,0) size 320x65 [color=#008000]
    3838      RenderText {#text} at (0,31) size 320x65
    … …  
    4646        text run at (256,159) width 64: "x"
    4747    RenderText {#text} at (0,0) size 0x0
    48 layer at (8,925) size 320x256
    49   RenderBlock {DIV} at (0,917) size 320x256 [bgcolor=#00FF00]
     48layer at (8,923) size 320x256
     49  RenderBlock {DIV} at (0,915) size 320x256 [bgcolor=#00FF00]
    5050    RenderInline {SPAN} at (0,0) size 320x65 [color=#008000]
    5151      RenderText {#text} at (0,31) size 320x65
    … …  
    5959        text run at (256,159) width 64: "x"
    6060    RenderText {#text} at (0,0) size 0x0
    61 layer at (8,1213) size 320x256
    62   RenderBlock {DIV} at (0,1205) size 320x256 [bgcolor=#00FF00]
     61layer at (8,1211) size 320x256
     62  RenderBlock {DIV} at (0,1203) size 320x256 [bgcolor=#00FF00]
    6363    RenderInline {SPAN} at (0,0) size 320x65 [color=#008000]
    6464      RenderText {#text} at (0,31) size 320x65

  • trunk/LayoutTests/platform/qt/fast/block/lineboxcontain/replaced-expected.txt

    r98015 r123772  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x165
    4   RenderBlock {HTML} at (0,0) size 800x165
    5     RenderBody {BODY} at (8,8) size 784x149
    6       RenderBlock (anonymous) at (0,0) size 784x21
    7         RenderText {#text} at (0,0) size 555x21
    8           text run at (0,0) width 294: "You should see a green rectangle below. "
    9           text run at (294,0) width 261: "If you see any red, the test has failed."
    10       RenderBlock {DIV} at (0,21) size 320x128 [bgcolor=#FF0000]
     3layer at (0,0) size 800x163
     4  RenderBlock {HTML} at (0,0) size 800x163
     5    RenderBody {BODY} at (8,8) size 784x147
     6      RenderBlock (anonymous) at (0,0) size 784x19
     7        RenderText {#text} at (0,0) size 471x19
     8          text run at (0,0) width 248: "You should see a green rectangle below. "
     9          text run at (248,0) width 223: "If you see any red, the test has failed."
     10      RenderBlock {DIV} at (0,19) size 320x128 [bgcolor=#FF0000]
    1111        RenderBlock {DIV} at (0,0) size 320x128 [bgcolor=#008000]
    1212        RenderText {#text} at (0,0) size 0x0

  • trunk/Source/WebCore/ChangeLog

    r123771 r123772  
    211211        (WebCore::AccessibilityRenderObject::helpText):
    212212        (WebCore::AccessibilityRenderObject::accessibilityDescription):
     213
     2142012-07-26  Vsevolod Vlasov  <vsevik@chromium.org>
     215
     216        Unreviewed r123761 follow-up, inspector closure compilation fix.
     217
     218        * inspector/front-end/Script.js:
     219        (WebInspector.Script.Location.prototype.uiLocation):
     220        * inspector/front-end/ScriptSnippetModel.js:
     221
     2222012-07-26  Patrick Gansterer  <paroga@webkit.org>
     223
     224        Cleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
     225        https://bugs.webkit.org/show_bug.cgi?id=92113
     226
     227        Reviewed by Simon Hausmann.
     228
     229        Cleanup the definition of the two methods across different ports and
     230        replace the calls to them with LocalWindowsContext where possible.
     231
     232        * platform/graphics/GraphicsContext.h:
     233        (GraphicsContext):
     234        * platform/win/ScrollbarThemeWin.cpp:
     235        (WebCore::ScrollbarThemeWin::paintThumb):
    213236
    2142372012-07-26  Vsevolod Vlasov  <vsevik@chromium.org>

  • trunk/Source/WebKit2/ChangeLog

    r123769 r123772  
     12012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
     4        https://bugs.webkit.org/show_bug.cgi?id=92387
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Fix compilation warning in EWK2UnitTestServer.cpp.
     9
     10        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
     11        (EWK2UnitTestServer::EWK2UnitTestServer):
     12
    1132012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
    214
Note: See TracChangeset for help on using the changeset viewer.