Changeset 123841 in webkit


Ignore:
Timestamp:
Jul 27, 2012 12:10:06 AM (12 years ago)
Author:
Csaba Osztrogonác
Message:

[Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
​https://bugs.webkit.org/show_bug.cgi?id=88064

Reviewed by Zoltan Herczeg.

Source/WebKit/qt:

Add missing DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context) function.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetInternalsObject):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Use resetInternalsObject() instead of injectInternalsObject().

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::resetAfterTest):

LayoutTests:

  • platform/qt-5.0-wk2/Skipped: Unskip now passing tests.
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r123837 r123841  
     12012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
     4        https://bugs.webkit.org/show_bug.cgi?id=88064
     5
     6        Reviewed by Zoltan Herczeg.
     7
     8        * platform/qt-5.0-wk2/Skipped: Unskip now passing tests.
     9
    1102012-07-26  Mike Lawther  <mikelawther@chromium.org>
    211

  • trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

    r123803 r123841  
    397397# https://bugs.webkit.org/show_bug.cgi?id=90985
    398398fast/repaint/background-scaling.html
    399 
    400 # [Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
    401 # https://bugs.webkit.org/show_bug.cgi?id=91063
    402 compositing/columns/geometry-map-paginated-assert.html
    403 fast/multicol/shrink-to-column-height-for-pagination.html
    404399
    405400# [Qt] The test fonts used for Qt tests changed to the Liberation font family,
    … …  
    476471editing/selection/vertical-rl-rtl-extend-line-backward-br.html
    477472editing/selection/vertical-rl-rtl-extend-line-backward-p.html
    478 
    479 # REGRESSION(r122768, r122771) made 157 fails on WebKit2
    480 compositing/columns/composited-in-paginated.html
    481 compositing/geometry/fixed-position.html
    482 compositing/geometry/horizontal-scroll-composited.html
    483 compositing/geometry/vertical-scroll-composited.html
    484 compositing/iframes/become-composited-nested-iframes.html
    485 compositing/iframes/overlapped-nested-iframes.html
    486 compositing/layer-creation/fixed-position-under-transform.html
    487 compositing/masks/masked-ancestor.html
    488 compositing/rtl/rtl-absolute-overflow.html
    489 compositing/rtl/rtl-fixed-overflow.html
    490 compositing/tiling/constrained-layer-size.html
    491 css1/box_properties/border.html
    492 css1/box_properties/border_left.html
    493 css1/box_properties/border_left_width.html
    494 css1/box_properties/border_right_width.html
    495 css1/box_properties/border_style.html
    496 css1/box_properties/border_top.html
    497 css1/box_properties/border_width.html
    498 css1/box_properties/clear_float.html
    499 css1/box_properties/float_margin.html
    500 css1/box_properties/float_on_text_elements.html
    501 css1/box_properties/margin_bottom.html
    502 css1/box_properties/margin_inline.html
    503 css1/box_properties/margin_right.html
    504 css1/box_properties/margin_top.html
    505 css1/box_properties/padding.html
    506 css1/box_properties/padding_bottom.html
    507 css1/box_properties/padding_left.html
    508 css1/box_properties/padding_right.html
    509 css1/box_properties/width.html
    510 css2.1/20110323/abspos-containing-block-initial-001.htm
    511 css2.1/20110323/abspos-containing-block-initial-007.htm
    512 css2.1/20110323/abspos-non-replaced-width-margin-000.htm
    513 css2.1/20110323/abspos-replaced-width-margin-000.htm
    514 css2.1/20110323/replaced-intrinsic-ratio-001.htm
    515 editing/deleting/delete-after-span-ws-001.html
    516 editing/deleting/delete-after-span-ws-002.html
    517 editing/deleting/delete-line-end-ws-001.html
    518 editing/deleting/delete-line-end-ws-002.html
    519 editing/input/reveal-contenteditable-on-paste-vertically.html
    520 editing/selection/select-all-001.html
    521 editing/selection/select-all-002.html
    522 editing/selection/select-all-003.html
    523 editing/selection/select-all-004.html
    524 fast/canvas/canvas-bg.html
    525 fast/canvas/fallback-content.html
    526 fast/css-generated-content/table-parts-before-and-after.html
    527 fast/dom/Element/getBoundingClientRect-getClientRects-relative-to-viewport.html
    528 fast/dom/Window/window-scroll-arguments.html
    529 fast/dom/Window/window-xy-properties.html
    530 fast/dom/elementFromPoint-relative-to-viewport.html
    531 fast/dom/scroll-element-to-rect.html
    532 fast/dom/zoom-scroll-page-test.html
    533 fast/events/change-overflow-on-overflow-change.html
    534 fast/events/clientXY-in-zoom-and-scroll.html
    535 fast/events/fire-scroll-event.html
    536 fast/events/input-image-scrolled-x-y.html
    537 fast/events/scale-and-scroll-body.html
    538 fast/events/scroll-after-click-on-tab-index.html
    539 fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html
    540 fast/events/touch/touch-coords-in-zoom-and-scroll.html
    541 fast/flexbox/flex-hang.html
    542 fast/forms/number/number-spinbutton-in-multi-column.html
    543 fast/frames/frame-set-rotation-hit.html
    544 fast/gradients/background-clipped.html
    545 fast/images/gray-scale-jpeg-with-color-profile.html
    546 fast/images/imagemap-scroll.html
    547 fast/multicol/progression-reverse.html
    548 fast/overflow/scroll-vertical-not-horizontal.html
    549 fast/repaint/fixed-tranformed.html
    550 fast/sub-pixel/position-right-aligns-with-container.html
    551 fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html
    552 fast/sub-pixel/table-rows-have-stable-height.html
    553 fast/table/height-percent-test-vertical.html
    554 fast/table/height-percent-test.html
    555 fast/table/wide-colspan.html
    556 fast/table/wide-column.html
    557 fast/transforms/rotated-transform-affects-scrolling-2.html
    558 fast/transforms/selection-bounds-in-transformed-view.html
    559 printing/allowed-page-breaks.html
    560 printing/css2.1/page-break-after-002.html
    561 printing/css2.1/page-break-after-003.html
    562 printing/css2.1/page-break-after-004.html
    563 printing/page-break-always.html
    564 printing/page-break-avoid.html
    565 printing/page-break-before-avoid.html
    566 printing/page-break-display-none.html
    567 printing/zoomed-document.html
    568 svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg
    569 svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
    570 svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg
    571 svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
    572 svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg
    573 svg/W3C-SVG-1.1-SE/pservers-grad-17-b.svg
    574 svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg
    575 svg/W3C-SVG-1.1-SE/types-dom-03-b.svg
    576 svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
    577 svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
    578 svg/W3C-SVG-1.1/filters-turb-02-f.svg
    579 svg/css/path-gradient-stroke-shadow.svg
    580 svg/css/rect-gradient-stroke-shadow.svg
    581 svg/custom/glyph-selection-lang-attribute.svg
    582 svg/custom/gradient-stop-corner-cases.svg
    583 svg/custom/mask-excessive-malloc.svg
    584 svg/custom/massive-coordinates.svg
    585 svg/custom/oversized-pattern-scale.svg
    586 svg/custom/pan-direction.svg
    587 svg/custom/path-update.svg
    588 svg/custom/pattern-excessive-malloc.svg
    589 svg/custom/pointer-events-on-rounded-rect.xhtml
    590 svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml
    591 svg/custom/width-full-percentage.svg
    592 svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg
    593 svg/filters/feImage-late-indirect-update.svg
    594 svg/filters/feMerge-wrong-input.svg
    595 svg/filters/filter-empty-g.svg
    596 svg/overflow/overflow-on-outermost-svg-element-defaults.svg
    597 svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1.svg
    598 svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2.svg
    599 svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3.svg
    600 svg/zoom/page/absolute-sized-document-scrollbars.svg
    601473
    602474# [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing

  • trunk/Source/WebKit/qt/ChangeLog

    r123796 r123841  
     12012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
     4        https://bugs.webkit.org/show_bug.cgi?id=88064
     5
     6        Reviewed by Zoltan Herczeg.
     7
     8        Add missing DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context) function.
     9
     10        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
     11        (DumpRenderTreeSupportQt::resetInternalsObject):
     12        * WebCoreSupport/DumpRenderTreeSupportQt.h:
     13
    1142012-07-26  Zeno Albisser  <zeno@webkit.org>
    215

  • trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp

    r123711 r123841  
    10781078}
    10791079
     1080void DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context)
     1081{
     1082    WebCoreTestSupport::resetInternalsObject(context);
     1083}
     1084
    10801085QImage DumpRenderTreeSupportQt::paintPagesWithBoundaries(QWebFrame* qframe)
    10811086{

  • trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h

    r123711 r123841  
    205205    static void injectInternalsObject(JSContextRef);
    206206    static void resetInternalsObject(QWebFrame*);
     207    static void resetInternalsObject(JSContextRef);
    207208
    208209    static void setInteractiveFormValidationEnabled(QWebPage*, bool);

  • trunk/Tools/ChangeLog

    r123832 r123841  
     12012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
     2
     3        [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
     4        https://bugs.webkit.org/show_bug.cgi?id=88064
     5
     6        Reviewed by Zoltan Herczeg.
     7
     8        Use resetInternalsObject() instead of injectInternalsObject().
     9
     10        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
     11        (WTR::InjectedBundlePage::resetAfterTest):
     12
    1132012-07-26  Ryuan Choi  <ryuan.choi@samsung.com>
    214

  • trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

    r123652 r123841  
    363363    JSGlobalContextRef context = WKBundleFrameGetJavaScriptContext(frame);
    364364#if PLATFORM(QT)
    365     DumpRenderTreeSupportQt::injectInternalsObject(context);
     365    DumpRenderTreeSupportQt::resetInternalsObject(context);
    366366#else
    367367    WebCoreTestSupport::resetInternalsObject(context);
Note: See TracChangeset for help on using the changeset viewer.