Changeset 124552 in webkit

Timestamp:

Aug 2, 2012 7:40:14 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Fix wrong assigned value of BatteryStatus
​https://bugs.webkit.org/show_bug.cgi?id=93058

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-08-02
Reviewed by Kentaro Hara.

There is a wrong change in the bug 92964.
property variable have to be used after assigned value in the setBatteryClient.

• platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::setBatteryClient):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/efl/BatteryProviderEfl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-02  Kihong Kwon  <kihong.kwon@samsung.com>
+
+        [EFL] Fix wrong assigned value of BatteryStatus
+        https://bugs.webkit.org/show_bug.cgi?id=93058
+
+        Reviewed by Kentaro Hara.
+
+        There is a wrong change in the bug 92964.
+        property variable have to be used after assigned value in the setBatteryClient.
+
+        * platform/efl/BatteryProviderEfl.cpp:
+        (WebCore::BatteryProviderEfl::setBatteryClient):
+
 2012-08-02  Arvid Nilsson  <anilsson@rim.com>
 

trunk/Source/WebCore/platform/efl/BatteryProviderEfl.cpp

@@ -153 +153 @@
     }
 
-    double level = property->val.d / 100;
     bool levelChanged = false;
-
     property = static_cast<E_Ukit_Property*>(eina_hash_find(eukitPropertyNames->properties, "Percentage"));
     if (!property)
         return;
+
+    double level = property->val.d / 100;
     if (!clientBatteryStatus || clientBatteryStatus->level() != level)
         levelChanged = true;