Changeset 125025 in webkit


Ignore:
Timestamp:
Aug 8, 2012 5:51:18 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
​https://bugs.webkit.org/show_bug.cgi?id=93253

Patch by Sergey Rogulenko <​rogulenko@google.com> on 2012-08-08
Reviewed by Pavel Feldman.

Renaming DOMNodeHighlighter to InspectorOverlay where necessary.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorOverlay.cpp: Renamed from Source/WebCore/inspector/DOMNodeHighlighter.cpp.

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawOutline):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::highlightRect):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):

  • inspector/InspectorOverlay.h: Renamed from Source/WebCore/inspector/DOMNodeHighlighter.h.

(WebCore):
(HighlightConfig):
(WebCore::Highlight::setColors):
(Highlight):
(InspectorOverlay):
(WebCore::InspectorOverlay::create):

  • inspector/InspectorPageAgent.cpp:
  • inspector/PageDebuggerAgent.cpp:
  • page/GestureTapHighlighter.h:
  • testing/Internals.cpp:
Location:
trunk/Source/WebCore
Files:
15 edited
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r124953 r125025  
    15091509    inspector/ContentSearchUtils.cpp
    15101510    inspector/DOMEditor.cpp
    1511     inspector/DOMNodeHighlighter.cpp
    15121511    inspector/DOMPatchSupport.cpp
    15131512    inspector/IdentifiersFactory.cpp
    … …  
    15411540    inspector/InspectorInstrumentation.cpp
    15421541    inspector/InspectorMemoryAgent.cpp
     1542    inspector/InspectorOverlay.cpp
    15431543    inspector/InspectorProfilerAgent.cpp
    15441544    inspector/InspectorResourceAgent.cpp

  • trunk/Source/WebCore/ChangeLog

    r125022 r125025  
     12012-08-08  Sergey Rogulenko  <rogulenko@google.com>
     2
     3        Web Inspector: renaming DOMNodeHighlighter to InspectorOverlay
     4        https://bugs.webkit.org/show_bug.cgi?id=93253
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Renaming DOMNodeHighlighter to InspectorOverlay where necessary.
     9
     10        * CMakeLists.txt:
     11        * GNUmakefile.list.am:
     12        * Target.pri:
     13        * WebCore.gypi:
     14        * WebCore.vcproj/WebCore.vcproj:
     15        * WebCore.xcodeproj/project.pbxproj:
     16        * inspector/InspectorAllInOne.cpp:
     17        * inspector/InspectorController.cpp:
     18        * inspector/InspectorDOMAgent.cpp:
     19        * inspector/InspectorDOMAgent.h:
     20        * inspector/InspectorOverlay.cpp: Renamed from Source/WebCore/inspector/DOMNodeHighlighter.cpp.
     21        (WebCore::InspectorOverlay::InspectorOverlay):
     22        (WebCore):
     23        (WebCore::InspectorOverlay::paint):
     24        (WebCore::InspectorOverlay::drawOutline):
     25        (WebCore::InspectorOverlay::getHighlight):
     26        (WebCore::InspectorOverlay::setPausedInDebuggerMessage):
     27        (WebCore::InspectorOverlay::hideHighlight):
     28        (WebCore::InspectorOverlay::highlightNode):
     29        (WebCore::InspectorOverlay::highlightRect):
     30        (WebCore::InspectorOverlay::highlightedNode):
     31        (WebCore::InspectorOverlay::update):
     32        (WebCore::InspectorOverlay::drawNodeHighlight):
     33        (WebCore::InspectorOverlay::drawRectHighlight):
     34        (WebCore::InspectorOverlay::drawPausedInDebugger):
     35        * inspector/InspectorOverlay.h: Renamed from Source/WebCore/inspector/DOMNodeHighlighter.h.
     36        (WebCore):
     37        (HighlightConfig):
     38        (WebCore::Highlight::setColors):
     39        (Highlight):
     40        (InspectorOverlay):
     41        (WebCore::InspectorOverlay::create):
     42        * inspector/InspectorPageAgent.cpp:
     43        * inspector/PageDebuggerAgent.cpp:
     44        * page/GestureTapHighlighter.h:
     45        * testing/Internals.cpp:
     46
    1472012-08-08  Chris Guan  <chris.guan@torchmobile.com.cn>
    248

  • trunk/Source/WebCore/GNUmakefile.list.am

    r124953 r125025  
    27352735        Source/WebCore/inspector/DOMEditor.cpp \
    27362736        Source/WebCore/inspector/DOMEditor.h \
    2737         Source/WebCore/inspector/DOMNodeHighlighter.cpp \
    2738         Source/WebCore/inspector/DOMNodeHighlighter.h \
    27392737        Source/WebCore/inspector/DOMPatchSupport.cpp \
    27402738        Source/WebCore/inspector/DOMPatchSupport.h \
    … …  
    28012799        Source/WebCore/inspector/InspectorMemoryAgent.cpp \
    28022800        Source/WebCore/inspector/InspectorMemoryAgent.h \
     2801        Source/WebCore/inspector/InspectorOverlay.cpp \
     2802        Source/WebCore/inspector/InspectorOverlay.h \
    28032803        Source/WebCore/inspector/InspectorPageAgent.cpp \
    28042804        Source/WebCore/inspector/InspectorPageAgent.h \

  • trunk/Source/WebCore/Target.pri

    r124953 r125025  
    734734    inspector/ContentSearchUtils.cpp \
    735735    inspector/DOMEditor.cpp \
    736     inspector/DOMNodeHighlighter.cpp \
    737736    inspector/DOMPatchSupport.cpp \
    738737    inspector/IdentifiersFactory.cpp \
    … …  
    763762    inspector/InspectorInstrumentation.cpp \
    764763    inspector/InspectorMemoryAgent.cpp \
     764    inspector/InspectorOverlay.cpp \
    765765    inspector/InspectorPageAgent.cpp \
    766766    inspector/InspectorProfilerAgent.cpp \
    … …  
    18401840    inspector/ContentSearchUtils.h \
    18411841    inspector/DOMEditor.h \
    1842     inspector/DOMNodeHighlighter.h \
    18431842    inspector/DOMPatchSupport.h \
    18441843    inspector/IdentifiersFactory.h \
    … …  
    18711870    inspector/InspectorInstrumentation.h \
    18721871    inspector/InspectorMemoryAgent.h \
     1872    inspector/InspectorOverlay.h \
    18731873    inspector/InspectorPageAgent.h \
    18741874    inspector/InspectorProfilerAgent.h \

  • trunk/Source/WebCore/WebCore.gypi

    r125020 r125025  
    28222822            'inspector/DOMEditor.cpp',
    28232823            'inspector/DOMEditor.h',
    2824             'inspector/DOMNodeHighlighter.cpp',
    2825             'inspector/DOMNodeHighlighter.h',
    28262824            'inspector/DOMPatchSupport.cpp',
    28272825            'inspector/DOMPatchSupport.h',
    … …  
    28812879            'inspector/InspectorMemoryAgent.cpp',
    28822880            'inspector/InspectorMemoryAgent.h',
     2881            'inspector/InspectorOverlay.cpp',
     2882            'inspector/InspectorOverlay.h',
    28832883            'inspector/InspectorPageAgent.cpp',
    28842884            'inspector/InspectorPageAgent.h',

  • trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj

    r124953 r125025  
    7394073940                        </File>
    7394173941                        <File
    73942                                 RelativePath="..\inspector\DOMNodeHighlighter.cpp"
    73943                                 >
    73944                                 <FileConfiguration
    73945                                         Name="Release|Win32"
    73946                                         ExcludedFromBuild="true"
    73947                                         >
    73948                                         <Tool
    73949                                                 Name="VCCLCompilerTool"
    73950                                         />
    73951                                 </FileConfiguration>
    73952                                 <FileConfiguration
    73953                                         Name="Production|Win32"
    73954                                         ExcludedFromBuild="true"
    73955                                         >
    73956                                         <Tool
    73957                                                 Name="VCCLCompilerTool"
    73958                                         />
    73959                                 </FileConfiguration>
    73960                         </File>
    73961                         <File
    73962                                 RelativePath="..\inspector\DOMNodeHighlighter.h"
    73963                                 >
    73964                         </File>
    73965                         <File
    7396673942                                RelativePath="..\inspector\DOMPatchSupport.cpp"
    7396773943                                >
    … …  
    7473374709                        <File
    7473474710                                RelativePath="..\inspector\InspectorMemoryAgent.h"
     74711                                >
     74712                        </File>
     74713                        <File
     74714                                RelativePath="..\inspector\InspectorOverlay.cpp"
     74715                                >
     74716                                <FileConfiguration
     74717                                        Name="Release|Win32"
     74718                                        ExcludedFromBuild="true"
     74719                                        >
     74720                                        <Tool
     74721                                                Name="VCCLCompilerTool"
     74722                                        />
     74723                                </FileConfiguration>
     74724                                <FileConfiguration
     74725                                        Name="Production|Win32"
     74726                                        ExcludedFromBuild="true"
     74727                                        >
     74728                                        <Tool
     74729                                                Name="VCCLCompilerTool"
     74730                                        />
     74731                                </FileConfiguration>
     74732                        </File>
     74733                        <File
     74734                                RelativePath="..\inspector\InspectorOverlay.h"
    7473574735                                >
    7473674736                        </File>

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r124979 r125025  
    14491449                4E19592D0A39DACC00220FE5 /* MediaQueryExp.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4E1959270A39DACC00220FE5 /* MediaQueryExp.cpp */; };
    14501450                4E19592E0A39DACC00220FE5 /* MediaQueryExp.h in Headers */ = {isa = PBXBuildFile; fileRef = 4E1959280A39DACC00220FE5 /* MediaQueryExp.h */; };
    1451                 4F1442281339FD6200E0D6F8 /* DOMNodeHighlighter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4F1442261339FD6200E0D6F8 /* DOMNodeHighlighter.cpp */; };
    1452                 4F1442291339FD6200E0D6F8 /* DOMNodeHighlighter.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1442271339FD6200E0D6F8 /* DOMNodeHighlighter.h */; settings = {ATTRIBUTES = (Private, ); }; };
    14531451                4F1534DE11B532EC0021FD86 /* EditingBehavior.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1534DD11B532EC0021FD86 /* EditingBehavior.h */; settings = {ATTRIBUTES = (Private, ); }; };
    14541452                4F1534E011B533020021FD86 /* EditingBehaviorTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 4F1534DF11B533020021FD86 /* EditingBehaviorTypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    19701968                7B9184D215758E420092AA93 /* UndoManager.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7B9184CF15758E420092AA93 /* UndoManager.cpp */; };
    19711969                7B9184D315758E420092AA93 /* UndoManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 7B9184D015758E420092AA93 /* UndoManager.h */; };
     1970                7C522D4B15B477E8009B7C95 /* InspectorOverlay.cpp */ = {isa = PBXBuildFile; fileRef = 7C522D4915B477E8009B7C95 /* InspectorOverlay.cpp */; };
     1971                7C522D4C15B478B2009B7C95 /* InspectorOverlay.h */ = {isa = PBXBuildFile; fileRef = 7C522D4A15B477E8009B7C95 /* InspectorOverlay.h */; settings = {ATTRIBUTES = (Private, ); }; };
    19721972                7E33CD01127F340D00BE8F17 /* PurgePriority.h in Headers */ = {isa = PBXBuildFile; fileRef = 7E33CD00127F340D00BE8F17 /* PurgePriority.h */; settings = {ATTRIBUTES = (Private, ); }; };
    19731973                7E37EF2E1339208800B29250 /* SubresourceLoaderCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7E37EF2D1339208800B29250 /* SubresourceLoaderCF.cpp */; };
    … …  
    85878587                4E1959270A39DACC00220FE5 /* MediaQueryExp.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = MediaQueryExp.cpp; sourceTree = "<group>"; };
    85888588                4E1959280A39DACC00220FE5 /* MediaQueryExp.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = MediaQueryExp.h; sourceTree = "<group>"; };
    8589                 4F1442261339FD6200E0D6F8 /* DOMNodeHighlighter.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMNodeHighlighter.cpp; sourceTree = "<group>"; };
    8590                 4F1442271339FD6200E0D6F8 /* DOMNodeHighlighter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMNodeHighlighter.h; sourceTree = "<group>"; };
    85918589                4F1534DD11B532EC0021FD86 /* EditingBehavior.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditingBehavior.h; sourceTree = "<group>"; };
    85928590                4F1534DF11B533020021FD86 /* EditingBehaviorTypes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EditingBehaviorTypes.h; sourceTree = "<group>"; };
    … …  
    91499147                7B9184D015758E420092AA93 /* UndoManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UndoManager.h; sourceTree = "<group>"; };
    91509148                7B9184D115758E420092AA93 /* UndoManager.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = UndoManager.idl; sourceTree = "<group>"; };
     9149                7C522D4915B477E8009B7C95 /* InspectorOverlay.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorOverlay.cpp; sourceTree = "<group>"; };
     9150                7C522D4A15B478B2009B7C95 /* InspectorOverlay.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorOverlay.h; sourceTree = "<group>"; };
    91519151                7C60128060078BB70E367A95 /* DNSResolveQueue.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DNSResolveQueue.cpp; sourceTree = "<group>"; };
    91529152                7E33CD00127F340D00BE8F17 /* PurgePriority.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PurgePriority.h; sourceTree = "<group>"; };
    … …  
    1456614566                                7AABA25714BC613300AA9A11 /* DOMEditor.cpp */,
    1456714567                                7AABA25814BC613300AA9A11 /* DOMEditor.h */,
    14568                                 4F1442261339FD6200E0D6F8 /* DOMNodeHighlighter.cpp */,
    14569                                 4F1442271339FD6200E0D6F8 /* DOMNodeHighlighter.h */,
    1457014568                                7A54881614E432A1006AE05A /* DOMPatchSupport.cpp */,
    1457114569                                7A54881514E432A1006AE05A /* DOMPatchSupport.h */,
    … …  
    1463914637                                7AA51DD3148506A900AD2752 /* InspectorMemoryAgent.cpp */,
    1464014638                                7AA51DD4148506A900AD2752 /* InspectorMemoryAgent.h */,
     14639                                7C522D4915B477E8009B7C95 /* InspectorOverlay.cpp */,
     14640                                7C522D4A15B478B2009B7C95 /* InspectorOverlay.h */,
    1464114641                                4F6FDD621341DEDD001F8EE3 /* InspectorPageAgent.cpp */,
    1464214642                                4F6FDD631341DEDD001F8EE3 /* InspectorPageAgent.h */,
    … …  
    2279322793                                853BF4DB0ABB6B55008647BB /* DOMNode.h in Headers */,
    2279422794                                854075260AD6C66700620C57 /* DOMNodeFilter.h in Headers */,
    22795                                 4F1442291339FD6200E0D6F8 /* DOMNodeHighlighter.h in Headers */,
    2279622795                                85B498FB0ADB340200925CBB /* DOMNodeInternal.h in Headers */,
    2279722796                                85526C370AB0A17E000302EA /* DOMNodeIterator.h in Headers */,
    … …  
    2365723656                                20D629271253690B00081543 /* InspectorInstrumentation.h in Headers */,
    2365823657                                7AA51DD6148506A900AD2752 /* InspectorMemoryAgent.h in Headers */,
     23658                                7C522D4C15B478B2009B7C95 /* InspectorOverlay.h in Headers */,
    2365923659                                4F6FDD651341DEDD001F8EE3 /* InspectorPageAgent.h in Headers */,
    2366023660                                9F0D6B2F121BFEBA006C0288 /* InspectorProfilerAgent.h in Headers */,
    … …  
    2622126221                                8518DD790A9CF31B0091B7A6 /* DOMNamedNodeMap.mm in Sources */,
    2622226222                                853BF4DC0ABB6B55008647BB /* DOMNode.mm in Sources */,
    26223                                 4F1442281339FD6200E0D6F8 /* DOMNodeHighlighter.cpp in Sources */,
    2622426223                                85526C380AB0A17E000302EA /* DOMNodeIterator.mm in Sources */,
    2622526224                                85ACAA8E0A9B759C00671E90 /* DOMNodeList.mm in Sources */,
    … …  
    2682826827                                20D629261253690B00081543 /* InspectorInstrumentation.cpp in Sources */,
    2682926828                                7AA51DD5148506A900AD2752 /* InspectorMemoryAgent.cpp in Sources */,
     26829                                7C522D4B15B477E8009B7C95 /* InspectorOverlay.cpp in Sources */,
    2683026830                                4F6FDD641341DEDD001F8EE3 /* InspectorPageAgent.cpp in Sources */,
    2683126831                                9F0D6B2E121BFEBA006C0288 /* InspectorProfilerAgent.cpp in Sources */,

  • trunk/Source/WebCore/inspector/InspectorAllInOne.cpp

    r124306 r125025  
    2929#include "ContentSearchUtils.cpp"
    3030#include "DOMEditor.cpp"
    31 #include "DOMNodeHighlighter.cpp"
    3231#include "DOMPatchSupport.cpp"
    3332#include "IdentifiersFactory.cpp"
    … …  
    5857#include "InspectorInstrumentation.cpp"
    5958#include "InspectorMemoryAgent.cpp"
     59#include "InspectorOverlay.cpp"
    6060#include "InspectorPageAgent.cpp"
    6161#include "InspectorProfilerAgent.cpp"

  • trunk/Source/WebCore/inspector/InspectorController.cpp

    r124332 r125025  
    3535#include "InspectorController.h"
    3636
    37 #include "DOMNodeHighlighter.h"
    3837#include "Frame.h"
    3938#include "GraphicsContext.h"
    … …  
    5857#include "InspectorInstrumentation.h"
    5958#include "InspectorMemoryAgent.h"
     59#include "InspectorOverlay.h"
    6060#include "InspectorPageAgent.h"
    6161#include "InspectorProfilerAgent.h"

  • trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp

    r125014 r125025  
    4848#include "CookieJar.h"
    4949#include "DOMEditor.h"
    50 #include "DOMNodeHighlighter.h"
    5150#include "DOMPatchSupport.h"
    5251#include "DOMWindow.h"
    … …  
    6968#include "InspectorFrontend.h"
    7069#include "InspectorHistory.h"
     70#include "InspectorOverlay.h"
    7171#include "InspectorPageAgent.h"
    7272#include "InspectorState.h"

  • trunk/Source/WebCore/inspector/InspectorDOMAgent.h

    r124769 r125025  
    3131#define InspectorDOMAgent_h
    3232
    33 #include "DOMNodeHighlighter.h"
    3433#include "EventTarget.h"
    3534#include "InjectedScript.h"
    … …  
    3736#include "InspectorBaseAgent.h"
    3837#include "InspectorFrontend.h"
     38#include "InspectorOverlay.h"
    3939#include "InspectorValues.h"
    4040#include "Timer.h"

  • trunk/Source/WebCore/inspector/InspectorOverlay.cpp

    r125024 r125025  
    3131#if ENABLE(INSPECTOR)
    3232
    33 #include "DOMNodeHighlighter.h"
     33#include "InspectorOverlay.h"
    3434
    3535#include "Element.h"

  • trunk/Source/WebCore/inspector/InspectorOverlay.h

    r125024 r125025  
    2727 */
    2828
    29 #ifndef DOMNodeHighlighter_h
    30 #define DOMNodeHighlighter_h
     29#ifndef InspectorOverlay_h
     30#define InspectorOverlay_h
    3131
    3232#include "Color.h"
    … …  
    122122
    123123
    124 #endif // DOMNodeHighlighter_h
     124#endif // InspectorOverlay_h

  • trunk/Source/WebCore/inspector/InspectorPageAgent.cpp

    r124484 r125025  
    4545#include "CookieJar.h"
    4646#include "DOMImplementation.h"
    47 #include "DOMNodeHighlighter.h"
    4847#include "DOMPatchSupport.h"
    4948#include "DeviceOrientationController.h"
    … …  
    6261#include "InspectorFrontend.h"
    6362#include "InspectorInstrumentation.h"
     63#include "InspectorOverlay.h"
    6464#include "InspectorState.h"
    6565#include "InspectorValues.h"

  • trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp

    r122977 r125025  
    3636
    3737#include "Console.h"
    38 #include "DOMNodeHighlighter.h"
     38#include "InspectorOverlay.h"
    3939#include "Page.h"
    4040#include "PageScriptDebugServer.h"

  • trunk/Source/WebCore/page/GestureTapHighlighter.h

    r105893 r125025  
    4444} // namespace WebCore
    4545
    46 #endif // DOMNodeHighlighter_h
     46#endif // GestureTapHighlighter__h

  • trunk/Source/WebCore/testing/Internals.cpp

    r124304 r125025  
    3131#include "ClientRectList.h"
    3232#include "ComposedShadowTreeWalker.h"
    33 #include "DOMNodeHighlighter.h"
    3433#include "DOMStringList.h"
    3534#include "Document.h"
    … …  
    5150#include "InspectorCounters.h"
    5251#include "InspectorInstrumentation.h"
     52#include "InspectorOverlay.h"
    5353#include "InstrumentingAgents.h"
    5454#include "InternalSettings.h"
Note: See TracChangeset for help on using the changeset viewer.